From: Alexander Shiyan <shc_work@mail.ru>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option
Date: Thu, 13 May 2021 18:12:16 +0300 [thread overview]
Message-ID: <20210513181216.0541f56a180febab295a755e@mail.ru> (raw)
In-Reply-To: <20210511023749.GD3425@dragon>
On Tue, 11 May 2021 10:37:50 +0800
Shawn Guo <shawnguo@kernel.org> wrote:
These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
so AC97 parameters are not used in such cases.
> On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote:
> > The operating mode is used for the AC97 interface only,
> > so lets drop the excess fsl,mode item from SSI node.
>
> Isn't it 'fsl,mode' meant for? I do not follow how it becomes excess.
>
> - fsl,mode: The operating mode for the AC97 interface only.
> "ac97-slave" - AC97 mode, SSI is clock slave
> "ac97-master" - AC97 mode, SSI is clock master
>
> Shawn
>
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > index a4217f564a53..67b2dd510981 100644
> > --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > @@ -225,7 +225,6 @@ &pcie {
> > };
> >
> > &ssi1 {
> > - fsl,mode = "i2s-slave";
> > status = "okay";
> > };
> >
> > --
> > 2.26.2
> >
--
Alexander Shiyan <shc_work@mail.ru>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-13 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 7:53 [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option Alexander Shiyan
2021-04-02 7:53 ` [PATCH RESEND 2/2] ARM: dts: imx6q-icore: " Alexander Shiyan
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
2021-05-13 15:12 ` Alexander Shiyan [this message]
2021-05-13 19:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513181216.0541f56a180febab295a755e@mail.ru \
--to=shc_work@mail.ru \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).