From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <jroedel@suse.de>,
Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API
Date: Fri, 14 May 2021 11:39:12 +0100 [thread overview]
Message-ID: <20210514103912.GA16131@lpieralisi> (raw)
In-Reply-To: <20210511125528.18525-1-heikki.krogerus@linux.intel.com>
On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
> The older device property API is going to be removed.
> Replacing the device_add_properties() call with software
> node API equivalent device_create_managed_software_node().
>
> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Is this really fixing anything ? I am not sure I understand what you
would like to achieve with this tag.
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
With the above comment clarified:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 3912a1f6058e5..e34937e11186a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
> FIELD_GET(ACPI_IORT_NC_PASID_BITS,
> nc->node_flags));
>
> - if (device_add_properties(dev, props))
> + if (device_create_managed_software_node(dev, props, NULL))
> dev_warn(dev, "Could not add device properties\n");
> }
>
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-14 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 12:55 [PATCH] ACPI/IORT: Handle device properties with software node API Heikki Krogerus
2021-05-11 13:51 ` Rafael J. Wysocki
2021-05-14 0:42 ` Hanjun Guo
2021-05-14 10:39 ` Lorenzo Pieralisi [this message]
2021-05-14 13:13 ` Heikki Krogerus
2021-05-17 14:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514103912.GA16131@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).