From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F067C433ED for ; Fri, 14 May 2021 10:41:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45A2361406 for ; Fri, 14 May 2021 10:41:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45A2361406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ycSNt1SZfS+MsHzZfA757tEa+P2F/LwT/TIj/Al+xs=; b=rEm2Q8ekc20V8zi56A+/dHmUZ upBxdPvb1W/7l6toj70jCjkYArML8JlpFo8acQH6cUFlS8zvTyOJd/4HpV+M9vdBQT3cjp39FrZ8Y e25NAUhxVQDEf7fb0ijZCBe0fkNcBLvuYd4NMw+FajtFalDlCpXiDqFma4Ce3fQX2MIM8JfY7aafA ANE1y21nQUppKBVOOJfG+pjCLQTlgm9xxSMkzacvVYRfFo+bShI0RjGwIuG4rsu1glLiudc5/wO7C U3L/v25/CpZX/iDqItkUwiAPYA/V7hSt9j41+jDHmmHHaw2oKQ8i7XVqRjO6hFXccSP9PS8VTPsjj /aPIEh5LA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhVE5-007nLp-4T; Fri, 14 May 2021 10:39:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhVE2-007nKt-8Q for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 10:39:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jzZD5HlANJsJb6AqpkZ+n/aNaGk+hblpn+z3cVE3iD4=; b=uPTOrTUvfoZk6DwXkGYL6oUi11 zIppsuLM/yLgVjA9EVR7zqrURbeCopw2A4SjFcHe+xBb48aMuYqO/v7A3AbgJHB8V70iz0EdwPYkr tqkYsz5v2lsNwiY/oJlUeYklkyVC6QqePgzVAF+otMaMudCibWiVfEGhTAz1oI0PKwVjbqKizfylM pRmOXX4HWzgyP1otqgG9Ss8aFP0flDplDRQ5MFctQYDEm3jpltu3s12gxtswur0alJ1/1SC4751Ms Up7U6L1nDmFw23mdl2KkdSjqRmEQoncwN8pKS9d6Mf28Auni7lWeoztacyJxU0tF+700WoNmTsxSK 1TxNfLWg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhVDz-00BuEb-De for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 10:39:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD8BF1713; Fri, 14 May 2021 03:39:18 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EFCD3F719; Fri, 14 May 2021 03:39:17 -0700 (PDT) Date: Fri, 14 May 2021 11:39:12 +0100 From: Lorenzo Pieralisi To: Heikki Krogerus Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Jean-Philippe Brucker , Joerg Roedel , Eric Auger , Will Deacon , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API Message-ID: <20210514103912.GA16131@lpieralisi> References: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_033919_529561_B2C75F2E X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote: > The older device property API is going to be removed. > Replacing the device_add_properties() call with software > node API equivalent device_create_managed_software_node(). > > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits") Is this really fixing anything ? I am not sure I understand what you would like to achieve with this tag. > Signed-off-by: Heikki Krogerus > --- > drivers/acpi/arm64/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) With the above comment clarified: Acked-by: Lorenzo Pieralisi > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 3912a1f6058e5..e34937e11186a 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, > FIELD_GET(ACPI_IORT_NC_PASID_BITS, > nc->node_flags)); > > - if (device_add_properties(dev, props)) > + if (device_create_managed_software_node(dev, props, NULL)) > dev_warn(dev, "Could not add device properties\n"); > } > > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel