From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@axis.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] arm64: Make ARCH_DMA_MINALIGN configurable
Date: Mon, 17 May 2021 12:04:06 +0100 [thread overview]
Message-ID: <20210517110406.GA1106@arm.com> (raw)
In-Reply-To: <20210517074332.28280-1-vincent.whitchurch@axis.com>
On Mon, May 17, 2021 at 09:43:32AM +0200, Vincent Whitchurch wrote:
> ARCH_DMA_MINALIGN is hardcoded to 128, but this wastes memory if the
> kernel is only intended to be run on platforms with cache line sizes of
> 64 bytes.
>
> Make this configurable (hidden under CONFIG_EXPERT). Setting this to 64
> bytes reduces the slab memory usage of my Cortex-A53-based system by
> ~6%, measured right after startup.
I agree that we waste some memory since the kmalloc caches start from
128 but I don't think a config option is the right.
An option would be to try not to rely on the hard-coded
ARCH_DMA_MINALIGN when the slab caches are created but use
cache_line_size(). It's a bit tricky as the cache_line_size() returned
value may be tweaked by DT or PPTT after the boot caches have been
created (see commit 7b8c87b297a7).
Another option I recall discussing with Arnd about two years ago was to
start with the default 128 at boot but add the smaller slab caches
later, once we have more information. This can be just another 64 byte
cache or even go all the way down to 8 byte if all the devices are
cache coherent.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-17 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 7:43 [PATCH] arm64: Make ARCH_DMA_MINALIGN configurable Vincent Whitchurch
2021-05-17 11:04 ` Catalin Marinas [this message]
2021-05-17 12:01 ` Ard Biesheuvel
2021-05-17 13:35 ` Arnd Bergmann
2021-05-17 14:20 ` Catalin Marinas
2021-05-17 14:15 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517110406.GA1106@arm.com \
--to=catalin.marinas@arm.com \
--cc=arnd@arndb.de \
--cc=kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=vincent.whitchurch@axis.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).