From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D43C433B4 for ; Mon, 17 May 2021 16:38:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C29DA611CC for ; Mon, 17 May 2021 16:38:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C29DA611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=aRdeEv/Yq+qOuTqCVlKxPUidf1YYm0RnDU1XN7ga/0E=; b=bdfTgpty1vrmeYnNeGCxNitzl iyh0EeAMn5ymTVs3tumCP4nQQPo+ucW7yGbAKygpKIvRbU5nJFz7deqOCW1iXb3BtUDRzyIRL0kar CYGPCavoOhkkm9f0Ah3kILtG9WBV1q425fBk6DLxUVdamOWqh2vSdz41YF1SUrfjU6Tdz2pe3twEY WraGjGAAsvTHsSMNFJLpNaeMMEn20ULI1lFxDTCQqq/utUcz0can5ZKvEpT+E4aGiLhyPEIpinkAS wzmMWQ2HqBR8rKTjIaAcNer6yV/YRmCi8melzEFRVIm6gqO+XBptm2kq+Ctgu7QE8S1ew24+j4qUj 908AFZJAg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ligEJ-00FXrJ-NL; Mon, 17 May 2021 16:36:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ligEH-00FXr7-6h for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 16:36:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:References; bh=VLlic6WOZYWN5XP4ZZlMxeAu2S8z9LvxrmhRipPoxLw=; b=RtJrH6LI1WLis+e9nm9+rZtYsS CAKHrWqDEkrFCC/7vjhNAyKO3wyG0wnnNiMWp8+4Pz8TvDwC01FJ55T4VaZJEdxCSJBPOOhf6zupl Y2NrZrLZ6+agpWk9+RganvzGSjwgfZglzL3d3ZeiYmEjzpuSYgjGOZQlkUaFvetur2z3BjRAoZ/L2 fL+yANgVmSuINlpMlCvcnaLaBTKJOFxrL7stEC5fD7jH+msRrgu1m1V2F7h4dsBZxvpLxz2BVbnbz IwJ3t9vEmw0UEHKlLctjUnl87eEK+2aoh7nr3e665Bjrh/TWaZIKbWXbj/QnxPTc4N7jMZFObBmen PcZKy6Rw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ligED-00Dz4x-Oz for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 16:36:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 648FF611BD; Mon, 17 May 2021 16:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621269384; bh=+X4+bVfzpXfIBWRjakB4ifMEjfwf5eB74K2ooB0BvKs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=mrYMtv1M6tHlqyA6CqYBWaIneywFJ8hwyUoaWmJWO1aBoBlYRnCcmyhZMKC0yLyaR L7mvWpGdybVWGaENMBE6mq9gjH0sfYPnaY1+eRq8R+ZOHeLGqZceQDDNgUAU0f4Jvq MmibiOMYL5cSc1+YOUeDBcM1IQIsyMe4+riNcK3g3bdQyJCSbq3WIx37g6RM4islnV tptmI49809/uRmboehthxjM3H/6kET4bnLxDOynWRLSYv7o0+atkGxN/ZW5CMwwhYq 3vMKLyMt36Uaghsjc+qHPKSjyJnedWRE4+zCKZq6d1L1tfMgKtHkfBDF39YZXot178 zFp+kV+EOkf3A== Date: Mon, 17 May 2021 11:36:23 -0500 From: Bjorn Helgaas To: Luca Ceresoli Cc: linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Jingoo Han , Gustavo Pimentel Subject: Re: [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Message-ID: <20210517163623.GA21579@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210517154122.430544-1-luca@lucaceresoli.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_093625_852996_F89A70BD X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 05:41:17PM +0200, Luca Ceresoli wrote: > This is an series of mixed improvements to the DRA7 PCI controller driver: > allow building as a loadabel module, allow to get and enable a clock and a > small cleanup. > > Luca > > Luca Ceresoli (5): > PCI: dwc: export more symbols to allow modular drivers > PCI: dwc: pci-dra7xx: make it a kernel module > PCI: dwc: pci-dra7xx: allow to build as a loadable module > PCI: dwc: pci-dra7xx: remove unused include > PCI: dwc: pci-dra7xx: get an optional clock This driver has a poor record of subject lines: PCI: pci-dra7xx: Prepare for deferred probe with module_platform_driver PCI: dwc: Move dw_pcie_setup_rc() to DWC common code PCI: dwc/dra7xx: Use the common MSI irq_chip PCI: dwc: pci-dra7xx: Fix runtime PM imbalance on error The "PCI: dwc:" ones are fine -- they apply to the shared dwc core, not specifically to dra7xx. The driver-specific ones: PCI: pci-dra7xx: PCI: dwc/dra7xx: PCI: dwc: pci-dra7xx: are redundant and waste space. There's no need to mention "dwc" for dra7xx-specific things, and no need to mention "PCI" twice. We should use the "PCI: dra7xx:" prefix for things specific to this driver. The rest of the subject line should start with a capital letter. The subject line should contain specific information when practical. For example, PCI: dwc: Export dw_pcie_link_up(), dw_pcie_ep_reset_bar() for modular drivers PCI: dra7xx: Allow building as module PCI: dra7xx: Remove unused linux/init.h include PCI: dra7xx: Get optional external clock I would squash 2/5 and 3/5, similar to a98d2187efd9 ("PCI: meson: Build as module by default") and 526a76991b7b ("PCI: aardvark: Implement driver 'remove' function and allow to build it as module"). > drivers/pci/controller/dwc/Kconfig | 6 +++--- > drivers/pci/controller/dwc/pci-dra7xx.c | 21 +++++++++++++++++-- > .../pci/controller/dwc/pcie-designware-ep.c | 1 + > drivers/pci/controller/dwc/pcie-designware.c | 1 + > 4 files changed, 24 insertions(+), 5 deletions(-) > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel