From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02905C433ED for ; Tue, 18 May 2021 10:19:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C255611B0 for ; Tue, 18 May 2021 10:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C255611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6UN4wZd0Breo8/4mpbyxKie32mGZjllH4Fj0FiC61f0=; b=D1691veGieayclYWmzQkgwLta dxvtjgcLPBqOXnKjycTlUJAC8qqQwWZo6ivIiOmvaJYHy6ChXAMq6FguxpyX5gzKQs449faqwHl2E zZ19J/ZpmvSmv/Ej3Aj95+iVSjYzEZHRP6RKTtrN4ZKa98g1NMH6DGoXtGI0hdzrRTu5MfXkBllKN HHZka/JTRZGKj49E18R8o5YOUCJjk+wK0Pi75dy/LXx8iGo9RBLs3Uydq/tOO3S74UzRM5I7ynEhD SIGk69sYYVlrIH8ngVcDTCab2/RPS8OPDauwggJhX/DS/MowsVnj1qlmphozZcDniCvk8L3gPTI3C EIsNX5TQA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liwmh-000KHp-Lz; Tue, 18 May 2021 10:17:08 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liwcw-000HRK-9y for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 10:07:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XcUE59BbQI5VCk62NQ98jAv25zo//emUHUedcxxcgyA=; b=vIxUNOnpZw6INKPLZAdbKH/QgM KX9PFJB97XLVl1JStYdnRVffnLNBJG5/Pv7tp5P7CaHbH9OqlAWic+vqPBWB72jxAoddTJQPtp47O 1VkcnivX+mhTS6fk59jU9/QMn+FjkFGHvTslHH34CLthzhK+GvyCebkQVGSi3rj3NWRtSg9wRfYTy cUyKNG0dKquOA4/rvgEv17btqxxHKayTrFZ2IjjR3T1N4wvLnh2Yza0hne8NXvfWaITWkkd59IhUE 80XwmZ7AOWTeqT6wAiB3OofVpl/8J9apwIXjC9RGVXs17VXZGU0k700v+5e4CwfoBE9zxtgjhaNIc 7hMIiEDw==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liwct-00EXdD-Eq for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 10:07:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XcUE59BbQI5VCk62NQ98jAv25zo//emUHUedcxxcgyA=; b=B+1u6ZG4uJf1OSsB0tVOyeq0N H+f35qC+o3JQhJf0dqEAUIURiaEown3+hepXFL/kFsdRe5AnAXhCIr6odFUcrSryaajMcfXd7lHSV oERv2lMclyCkH88TtgEHbvmIjNuiaaskphGn/68qNsJVObsFzkALdGKWJnX2FP1mqe6ytC45X9SUH JOZlL7c8SLi92/bJOPHxXqYy/CdA1jei51V5eRNuZvzT7bn/n+6/NXPoPu+KSzaxpEWV+9shIdC8z pzsC2s8JthkHOanWWYH+W3ao8o0rzYPudZqRQqUkWQJea5CTgYcaXde0QKP4Qyg7/QjPw/chMtbu+ FgWLQSc9Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44126) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liwcR-00042a-B7; Tue, 18 May 2021 11:06:31 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1liwcN-0007nP-Tc; Tue, 18 May 2021 11:06:27 +0100 Date: Tue, 18 May 2021 11:06:27 +0100 From: "Russell King (Oracle)" To: "Sit, Michael Wei Hong" Cc: "Jose.Abreu@synopsys.com" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "kuba@kernel.org" , "netdev@vger.kernel.org" , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "davem@davemloft.net" , "mcoquelin.stm32@gmail.com" , "Voon, Weifeng" , "Ong, Boon Leong" , "Tan, Tee Min" , "vee.khee.wong@linux.intel.com" , "Wong, Vee Khee" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 2/2] net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet Message-ID: <20210518100627.GT12395@shell.armlinux.org.uk> References: <20210517094332.24976-1-michael.wei.hong.sit@intel.com> <20210517094332.24976-3-michael.wei.hong.sit@intel.com> <20210517105424.GP12395@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_030659_520347_79C110E7 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 11:37:12AM +0000, Sit, Michael Wei Hong wrote: > > From: Russell King > > > > On Mon, May 17, 2021 at 05:43:32PM +0800, Michael Sit Wei Hong > > wrote: > > > Link xpcs callback functions for MAC to configure the xpcs EEE > > feature. > > > > > > The clk_eee frequency is used to calculate the > > MULT_FACT_100NS. This > > > is to adjust the clock tic closer to 100ns. > > > > > > Signed-off-by: Michael Sit Wei Hong > > > > > > What is the initial state of the EEE configuration before the first > > call to stmmac_ethtool_op_set_eee()? Does it reflect the default > > EEE settings? > > The register values before the first call are the default reset values in > the registers. The reset values assumes the clk_eee_i time period is 10ns, > Hence, the reset value is set to 9. > According to the register description, > This value should be programmed such that the > clk_eee_i_time_period * (MULT_FACT_100NS + 1) should be > within 80 ns to 120 ns. > > Since we are using a fixed 19.2MHz clk_eee, which is 52ns, > we are setting the value to 1. Does that hardware default configuration match what is returned by ethtool --show-eee ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel