From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CDEC433B4 for ; Tue, 18 May 2021 12:03:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC164610CD for ; Tue, 18 May 2021 12:03:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC164610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fAtI/ThAGNDmt4dtqinbT5hKBI9bCEY+eJV/89rsviI=; b=pbZ9Lf8zlTf1L7lEcoJnZPuv7 nJ5TDxdgOzD8G0JQZzDsqJQLNscB7RtIYdaeq4MYrkumlwk4OLJK0F9NtkHnzl73LayBVf4HVeOcw +uFtSZHONYVlcEIuTNcaVmqMQUsxtCJGe8zn29yyhvRd06vcab/Rkd7DgjMUen8F4r1qXm2Wyq6U1 T2jtXxRiif5yn8MhEjNddaeFYCrFg9+SVE6pvnndxPfyDJLlyzrj7SOQZCaDnFmYpdGvGYHuC+SZz Pl8yUlmd0O9D+PmB1TV1BiRxiWeB5uNDk08SI7aBfqluOtTdIglfJw2wo65IK81iZE/FZHy3mC0IF urlkoAqkQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liyPv-000hPF-Oc; Tue, 18 May 2021 12:01:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liyPq-000hOh-5v for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 12:01:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1lel3gH0yK6JEo4QIhQRWSw3/QbFc7G9njZHvEgNBFE=; b=FXZqT+EyRs/HgPkqecCqqgOczp bk/RQovy3io4bNUsLUL7j76SZ7puU6GldISb4aOEbIjOgGi17N0JEvI5Pg54mpKPj+i+deNdwk15c kLvR5NASbQEw9CWCrGAu0ok1BBgDCn/60FDxMH2QANux9jxuGMEvBU9japmGh8EhHMTbrrjmnk6jk 9kqkHE4tNfOipZkQOK3PWIX+aT5s98972V+40ORecrfl02UmkTlzres4TPFsBkd63N9Twg3zK1YrW uCcNjYwPRWXgPg5uEpc/M61h6B+BcDzbIDcIDVTru1VWQV1qfQ7+iVMdy9QHsL775hXk6SH7Q93k6 Gz3FOPFw==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liyPn-00Ed5Y-0i for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 12:01:36 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14IC1Xoe022496; Tue, 18 May 2021 07:01:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1621339293; bh=1lel3gH0yK6JEo4QIhQRWSw3/QbFc7G9njZHvEgNBFE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=xPC0UHk/RcfYKAVu0CpYyg7/EPR7Bxsui16JxeuFrrOLdQFmlGN22+PQGkLiyEddR QklKyWyrltKOgpKefdtRqT3NdHTM5SZh6H9oGeMiG9XXI6w1qhxIidIPDzTVmfACgs FZuW/8cQpxu+NE0ISYgTifkbV3+KkjI/r2hTjgXk= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14IC1XgD126896 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 May 2021 07:01:33 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 18 May 2021 07:01:33 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 18 May 2021 07:01:33 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14IC1X7v021298; Tue, 18 May 2021 07:01:33 -0500 Date: Tue, 18 May 2021 07:01:33 -0500 From: Nishanth Menon To: Vaibhav Gupta CC: Rob Herring , Kishon Vijay Abraham , Sekhar Nori , Lokesh Vutla , Praneeth Bajjuri , Gowtham Tammana , , , Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Enable crypto accelerator Message-ID: <20210518120133.73qmsd6uu6dwtjfu@backshift> References: <20210518062630.144154-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518062630.144154-1-vaibhavgupta40@gmail.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_050135_165124_7EE96396 X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:56-20210518, Vaibhav Gupta wrote: > From: Vaibhav Gupta > > Add the node for SA2UL including the random number generator. > > [v_gupta@ti.com: Add address ranges entry in cbass_main] > Signed-off-by: Peter Ujfalusi > Signed-off-by: Vaibhav Gupta I see that you have missed the series Suman posted in [1]. It has a few cleanups of interest. > --- > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 25 ++++++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-am64.dtsi | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index 25b702303637..adbc3c0673f3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -160,6 +160,31 @@ k3_reset: reset-controller { > }; > }; > > + main_crypto: crypto@40900000 { > + compatible = "ti,am64-sa2ul"; > + reg = <0x0 0x40900000 0x0 0x1200>; > + power-domains = <&k3_pds 133 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 133 0>, <&k3_clks 133 1>, <&k3_clks 133 2>; > + clock-names = "pka_in_clk" , "x1_clk" , "x2_clk"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x040900000 0x00 0x040900000 0x0 0x30000>; > + > + status = "okay"; drop this.. > + > + dmas = <&main_pktdma 0xc001 15>, <&main_pktdma 0x4002 15>, > + <&main_pktdma 0x4003 15>; > + dma-names = "tx", "rx1", "rx2"; > + > + eip76d_rng: rng@40910000 { > + compatible = "inside-secure,safexcel-eip76"; > + reg = <0x0 0x40910000 0x0 0x80>; > + interrupts = ; > + clocks = <&k3_clks 133 2>; > + clock-names = "x2_clk"; > + }; > + }; > + > main_pmx0: pinctrl@f4000 { > compatible = "pinctrl-single"; > reg = <0x00 0xf4000 0x00 0x2d0>; > diff --git a/arch/arm64/boot/dts/ti/k3-am64.dtsi b/arch/arm64/boot/dts/ti/k3-am64.dtsi > index 0ae8c844c482..e2bea44a16c5 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64.dtsi > @@ -85,6 +85,7 @@ cbass_main: bus@f4000 { > <0x00 0x78000000 0x00 0x78000000 0x00 0x00800000>, /* Main R5FSS */ > <0x06 0x00000000 0x06 0x00000000 0x01 0x00000000>, /* PCIe DAT1 */ > <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, /* FSS0 DAT3 */ > + <0x00 0x40900000 0x00 0x40900000 0x00 0x00030000>, /* SA2UL */ > > /* MCU Domain Range */ > <0x00 0x04000000 0x00 0x04000000 0x00 0x01ff1400>; I think you might have missed the discussion here:[1] a) Could I suggest you co-ordinate with Suman as to which series should I consider? Suman's looks a lot complete.. b) Considering the potential for TF-A booting Linux without u-boot on HS devices, may I suggest making sure that the dts board files for evm have the nodes disabled by default? [1] https://lore.kernel.org/linux-arm-kernel/20210514221148.m42zldo6lfxn5l4m@underfed/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel