linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, dongas86@gmail.com
Subject: Re: [PATCH 3/4] arm64: mm: drop unused __pa(__idmap_text_start)
Date: Tue, 18 May 2021 13:19:35 +0100	[thread overview]
Message-ID: <20210518121935.GH82842@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20210518101405.1048860-4-aisheng.dong@nxp.com>

On Tue, May 18, 2021 at 06:14:04PM +0800, Dong Aisheng wrote:
> x5 is not used in the following map_memory. Instead,
> __pa(__idmap_text_start) is stored in x3 which is used later.
> 
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>

It might be worth noting that this hasn't been used since commit:

  0370b31e48454d8c ("arm64: Extend early page table code to allow for larger kernels")

Either way:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/head.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> index b70db34458ec..d266b4c6287d 100644
> --- a/arch/arm64/kernel/head.S
> +++ b/arch/arm64/kernel/head.S
> @@ -354,7 +354,6 @@ SYM_FUNC_START_LOCAL(__create_page_tables)
>  #endif
>  1:
>  	ldr_l	x4, idmap_ptrs_per_pgd
> -	mov	x5, x3				// __pa(__idmap_text_start)
>  	adr_l	x6, __idmap_text_end		// __pa(__idmap_text_end)
>  
>  	map_memory x0, x1, x3, x6, x7, x3, x4, x10, x11, x12, x13, x14
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-18 12:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 10:14 [PATCH 0/4] arm64: mm: a few small cleanups Dong Aisheng
2021-05-18 10:14 ` [PATCH 1/4] arm64: mm: remove unneeded SWAPPER_INIT_MAP_SIZE Dong Aisheng
2021-05-18 12:13   ` Mark Rutland
2021-06-15 13:31   ` Catalin Marinas
2021-05-18 10:14 ` [PATCH 2/4] arm64: mm: fix the count comments in compute_indices Dong Aisheng
2021-05-18 12:35   ` Mark Rutland
2021-06-15 13:29     ` Catalin Marinas
2021-05-18 10:14 ` [PATCH 3/4] arm64: mm: drop unused __pa(__idmap_text_start) Dong Aisheng
2021-05-18 12:19   ` Mark Rutland [this message]
2021-06-15 13:32   ` Catalin Marinas
2021-05-18 10:14 ` [PATCH 4/4] arm64: head: fix code comments in set_cpu_boot_mode_flag Dong Aisheng
2021-05-18 12:13   ` Mark Rutland
2021-06-15 13:31   ` Catalin Marinas
2021-06-15 19:18 ` [PATCH 0/4] arm64: mm: a few small cleanups Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210518121935.GH82842@C02TD0UTHF1T.local \
    --to=mark.rutland@arm.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dongas86@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).