From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B58DC433B4 for ; Wed, 19 May 2021 09:54:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEFB1600CC for ; Wed, 19 May 2021 09:54:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEFB1600CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Msd50nSznVBNnHbL+JYdGj/1TUiD1D75BtAsBei5G84=; b=BsifLcJvHj18kUU/8GGto8rWr Turx0PLcs5ajpHqwWo0nAtoyNGKkYOX1J4jlkaZT7TLPZ+JF1NDcF1O5UFtJtqALO0bnWwO9lUR8a EeNiIAmf+lUXHGLkr+/rxU07I/cFbaJM8P5PP1kDwsA/7UkJ63ZR1k7Kf8wiPoCAEiqi3OkMEkhd2 plnyEZwVrLITi/QuGHARPz8DnyDHz3aFIrr1eJSyNbv0mO5PZ4JAt72fK3guZiustJ3owrrMqdSPQ Gbx6ZNmYO37QCi8IXNwexYfCukVV3mOI2d/D6Oj7+etM3iTLQQ6OFZT6ErB3llxDuKXDdr4yel6My ob70WdB6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljIrd-003Vgx-3t; Wed, 19 May 2021 09:51:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljIrZ-003Vfv-Q1 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 09:51:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TNLmWPgrnKU8V3zt/1lqZtlrNetMlAXE0664V9jyc9g=; b=IN1HQB6B5pmBOAlr7WFU5Rb2J2 SOcCQVGns/cvyYXBAwlGSCkDXEwVzlD3ZxWLgMHPSYAfGQTvwWgI6JmKMLjXUFM8FgTVI6sZM+4S3 OfZ+cW7iSjStyzZKajxu7msrEZzVGKaff95U+APh4i9JHnsTKOLM3LgQipBlXSIegRzR0YtrXwGa8 bfsfANU+gnD51X6wNu8Fzgy3Bqx9d3Vugh5M0hT+fViAlmIuVuEbQmcg/m+uSBYcqOfp4O6tLD2Gi T2Vaf297hBgwusNUhks0oI5+nI5+5qAClEQF//5DtPnmgbBXQAIc7+sWg9TQAzjM1fBOedmfvfZ2j EJbw+6KQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljIrW-00FKf2-Sx for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 09:51:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E216101E; Wed, 19 May 2021 02:51:30 -0700 (PDT) Received: from localhost (unknown [10.1.195.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1E0F3F719; Wed, 19 May 2021 02:51:29 -0700 (PDT) Date: Wed, 19 May 2021 10:51:28 +0100 From: Ionela Voinescu To: Valentin Schneider Cc: Sudeep Holla , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Giovanni Gherdovich , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Message-ID: <20210519095128.GC21501@arm.com> References: <20210514095339.12979-1-ionela.voinescu@arm.com> <87fsyk190c.mognet@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87fsyk190c.mognet@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_025135_000739_0371B49D X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Valentin, On Tuesday 18 May 2021 at 14:12:03 (+0100), Valentin Schneider wrote: > Hi, > > On 14/05/21 10:53, Ionela Voinescu wrote: > > Hi all, > > > > These are a few trivial patches to populate cpu capacity information > > using performance information from ACPI's CPPC. > > > > I've tied this functionality to the existing function > > init_freq_invariance_cppc() called in acpi_cppc_processor_probe(). > > This function is renamed to a more generic arch_init_invariance_cppc(). > > > > The patches have been build tested on x86 and more thoroughly tested on > > Juno R2 (arm64), which uses the new functionality, with the following > > results: > > > > > > root@ubuntu:~# dmesg | grep cpu_capacity > > [ 2.157494] init_cpu_capacity_cppc: CPU0 cpu_capacity=38300 (raw). > > [ 2.163699] init_cpu_capacity_cppc: CPU1 cpu_capacity=38300 (raw). > > [ 2.169899] init_cpu_capacity_cppc: CPU2 cpu_capacity=38300 (raw). > > [ 2.176098] init_cpu_capacity_cppc: CPU3 cpu_capacity=38300 (raw). > > [ 2.182296] init_cpu_capacity_cppc: CPU4 cpu_capacity=102400 (raw). > > [ 2.188581] init_cpu_capacity_cppc: CPU5 cpu_capacity=102400 (raw). > > [ 2.194867] cpu_capacity: capacity_scale=102400 > > [ 2.199409] cpu_capacity: CPU0 cpu_capacity=383 > > [ 2.203952] cpu_capacity: CPU1 cpu_capacity=383 > > [ 2.208495] cpu_capacity: CPU2 cpu_capacity=383 > > [ 2.213037] cpu_capacity: CPU3 cpu_capacity=383 > > [ 2.217580] cpu_capacity: CPU4 cpu_capacity=1024 > > [ 2.222209] cpu_capacity: CPU5 cpu_capacity=1024 > > [ 2.226886] init_cpu_capacity_cppc: cpu_capacity initialization done > > > > root@ubuntu:~# tail -n +1 /sys/devices/system/cpu/cpu*/cpu_capacity > > ==> /sys/devices/system/cpu/cpu0/cpu_capacity <== > > 383 > > ==> /sys/devices/system/cpu/cpu1/cpu_capacity <== > > 383 > > ==> /sys/devices/system/cpu/cpu2/cpu_capacity <== > > 383 > > ==> /sys/devices/system/cpu/cpu3/cpu_capacity <== > > 383 > > ==> /sys/devices/system/cpu/cpu4/cpu_capacity <== > > 1024 > > ==> /sys/devices/system/cpu/cpu5/cpu_capacity <== > > 1024 > > > > All works as expected even if ACPI processor support is built as a > > module. > > > > Tested on my Ampere eMAG; this all seems to work fine except for some > scheduler debug stuff that gets confused; see > > http://lore.kernel.org/r/20210518130725.3563132-1-valentin.schneider@arm.com > > With that in mind: > Tested-by: Valentin Schneider Many thanks for testing and fixing the debugfs problem. I'll take a look over your patch. Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel