From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1B1C433B4 for ; Wed, 19 May 2021 13:04:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2D8D60FF1 for ; Wed, 19 May 2021 13:04:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2D8D60FF1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Pu8KvxKVRRPtX3TCuMT6FFJoKjPCnMnJxAWZ1aKwRo=; b=O1OX0wxBBuzxdaa8osJQypyck dVytuuLtVUldVmW1+uqi9rTXutXXRpyurOFrOCgNEsvPalaSMZogWNiLHrjHoMmX3JZP+2of53jqy zeGbj/xF8G5vWOccDxuMfdoso8Quc684U99YYC2odj0HwWDzoOmzRCv7uvWkQQ3GOlR89d/LO6aRy oSjSLaca2b65qFPtz/rx3/fGrQsLWVhtPTq5UC1TQQ+BJg5MYMDi7I8ZAFy0qQAZFws/RIbcorycO hE61jG6y3tjIDKVO/jNgNFqrS20cp9vjTvfxlTRoJOnPlVsI9TUk9dGZ1CZR1HnNGpAaDHQSrHguj TZWegEZkw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljLqp-0040jf-NA; Wed, 19 May 2021 13:03:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKOV-003mFh-0q for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 11:29:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uZQIILAPmQQ9Q3h7u8eLB2Hg7jTeRNCrgKPIvQZb5G8=; b=GU2ZEAxqnxsgWO89VrmnyzsISH 8/g9cmxOOnFhtYhZG0vDruQX9qliOjQW/rCshDzBiU+lEVy/Kv73IvOPzjCUWgYClya7NyZbGj/K/ gxpCImuBGDvbOnzkq11c7o2KGqvBUvJUkHs+5+YrsbzghNkmcTUia6wZB6bEp1kYeE7iMu1OD3yUY vezEF9tBtlCEnyPHJyHRe3e2T7kEzAyxxAAfiij8cgIqcxaNZETLUJZVE47VhAesmIK3mUssPqXP6 CImpLcF410X6X30KvgJXrK2DEPMrhS51WCitPU/BE4aEAawdUrNm0RtpzkayN7SPbACNi1mYRA5Av 3UGm+84w==; Received: from helcar.hmeau.com ([216.24.177.18] helo=deadmen.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKOR-00FPLe-Bx for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 11:29:40 +0000 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1ljKOL-0002kJ-Op; Wed, 19 May 2021 19:29:33 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ljKOI-00076p-DX; Wed, 19 May 2021 19:29:30 +0800 Date: Wed, 19 May 2021 19:29:30 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ebiggers@kernel.org, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 2/7] crypto: aead - disallow en/decrypt for non-task or non-softirq context Message-ID: <20210519112930.sgy3trqczyfok7mn@gondor.apana.org.au> References: <20210519112239.33664-1-ardb@kernel.org> <20210519112239.33664-3-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210519112239.33664-3-ardb@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_042939_426903_0CAB1FC1 X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 01:22:34PM +0200, Ard Biesheuvel wrote: > > crypto_stats_get(alg); > - if (crypto_aead_get_flags(aead) & CRYPTO_TFM_NEED_KEY) > + if (!(alg->cra_flags & CRYPTO_ALG_ASYNC) && > + WARN_ONCE(!in_task() && !in_serving_softirq(), > + "synchronous call from invalid context\n")) > + ret = -EBUSY; I don't think we've ever supported crypto in hard IRQ contexts. So this should be done regardless of ASYNC. Then again, do we really need this since the assumption has always been that the crypto API can only be invoked in user or softirq context? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel