From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E35C433B4 for ; Wed, 19 May 2021 11:53:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F0FB610CC for ; Wed, 19 May 2021 11:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F0FB610CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WgqIMuBbYCLMTBe9jHC0lojpE0/y1a8DD4zi20bs92Q=; b=OEAL4bAGOxyYn2VgCHoE613rA eKk2u0VlGu+ztGC1TrQXrJoi7M2aJzUt7bJJfH43ssApDfVzocQhcnjJbUoZ/o/c08PB0q+KEuazw 2wMuAZVWv/HvWFCTZRQ1r8ERgb/uolPAmPIDTex1PvQ7w9QD0I/O6fkUheYTHxyVACQrHRuo8I37S d56Nt6IhNmcyJr414GE41k3yU7F3XHPTRybTzCcwrtCUDR3lzkT+jbD7or7qUALzSL0g5fmMQKuxW vUYWDLx2wrEjGK4Tk/I9MO5dOj8E451NkhTYT5IyL228mbPQIxQGPX6Dub2/LYev2Rb2uWIhPWtr2 BaBk5NNwA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljKjy-003qr7-V1; Wed, 19 May 2021 11:51:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKjw-003qql-H1 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 11:51:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RgPTTeWeB5vJ2cbA9EMt7C0i86vQG1fsJGhl/SsLlRE=; b=tJVPq+LkzxuJAzMnlq1xsw8irH E0xd2tr8ItoFKn0iCLXOc+PZI27EOo5vE/XvLioBucS5gsISiRy/2K+LNrlLH7DSkqPcMP0KAiBnJ BguxZB1M6rjEm/dpSUfU2MANo+WZ9VDuRUM6G3iWmWI7WRhk5pmHdgBymL2XJfs3yLwjCtwFsPJER RYSXZk1vZr7U2dOh77ILK33vzeeC4XzbXdz+tP/IZVhe/rKbaIzfRLZMzS7fQgdgdx8mn1AIAtiKN bEozzDnfhyWlXaBDx7JF5OEiIacRTgOZPvcqovDTqd8NZmUGkVMo2X4hwoLWyygWqyaLLQXMatQSa hdpi9lkQ==; Received: from helcar.hmeau.com ([216.24.177.18] helo=deadmen.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKjt-00FQes-GA for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 11:51:51 +0000 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1ljKjr-0003hD-T1; Wed, 19 May 2021 19:51:47 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ljKjq-0007AF-Ki; Wed, 19 May 2021 19:51:46 +0800 Date: Wed, 19 May 2021 19:51:46 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Linux Crypto Mailing List , Linux ARM , Eric Biggers , Will Deacon , Android Kernel Team Subject: Re: [PATCH v4 2/7] crypto: aead - disallow en/decrypt for non-task or non-softirq context Message-ID: <20210519115146.bmrlfrchmz5tt2e2@gondor.apana.org.au> References: <20210519112239.33664-1-ardb@kernel.org> <20210519112239.33664-3-ardb@kernel.org> <20210519112930.sgy3trqczyfok7mn@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_045149_562443_9ED6DCC5 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 01:36:37PM +0200, Ard Biesheuvel wrote: > > So if we do need to check this, we should check it here. If we don't, > then we can drop these patches. Historically other things would break in nasty ways if you tried to do crypto in hard IRQ contexts, e.g., overwritten kmap slots back when we had individual slots for each context, but I don't think we've ever found anyone crazy enough to do that to warrant a run-time check. I'd just leave it out for now. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel