From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD02C433B4 for ; Wed, 19 May 2021 14:48:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A70C60FDB for ; Wed, 19 May 2021 14:48:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A70C60FDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RG4KKxtHj5zvdlB4oYgDRUHnqtPrt0iI10N4J5Ka5DU=; b=Y970WqsC5YKJ2xQvtoRo0DsP7 p/T9B8pUAKIiDyAqb6g5+mJQHg7NGFu4wgiscj8IBpmTJavBwCnV8RiQ0Z5+BPPa2OALrIVfDFKmv q5DAu3cp7PqVdmfGdQ7fX6Up5OuH5+uYPQtqH0Xlmm4twEPNn+Iw1sY/a4/9u/REJy4FYmlTZBpmr V6Y4kmoZ8lswznHXyBLB6Xp9Fr95YK1ZHqOSSVcdmhaieaIQDJR+obyrW0r6X8do51dCsVLwqdrir pYkPueiwdJLK8hWf62kVDtvsUaGU6Y2h18isEqocfrBodaXRV2TCAIBSszUoV2KwhygDrBh0d2jyB cNTdurMMw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljNTa-004IyD-TD; Wed, 19 May 2021 14:47:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljNTU-004Ixc-Ft for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 14:47:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D029ZzLZvyjQ5ILfA9CSc2j8cAQLeMPSYlQv+9xM2i8=; b=uFRpa0537vi8YnurIgOW70rHCK xgxwd6Cs+vI7HmZccr+OM8gXJfysozh/NENnycnPxOpbsEI8Rve/HkkgKp4LSMVRkT8tcCrS48OVk aS1s3kZ0NX/sEAwAVhEp5vTtyY29Nm2GLTSYrEUSGJqBLH5Rh0LNJ71PxO4mPUN9htYJKJPDvOT3q oH7sOuY2Tyc/JhjNDrfy3/+TX5GmeVQlTWwojPqvg56YdGlszvL6YTfzoUErRXTwFhdz0/Jpekepv hwBCMHevkcJeLBv+e8YRJyXwyNsP/bwAvByZvJYnbBZEtEPvtTm+Ed3a7dlmGEILi1NSE7AcpvU0d 3Klp9Ucw==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljNTS-00FYzG-0d for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 14:47:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8231731B; Wed, 19 May 2021 07:46:59 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.30.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 468543F73D; Wed, 19 May 2021 07:46:58 -0700 (PDT) Date: Wed, 19 May 2021 15:46:55 +0100 From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, will@kernel.org, joey.gouly@arm.com Subject: Re: [PATCH v2 06/19] arm64: entry: add a call_on_irq_stack helper Message-ID: <20210519144655.GE2797@C02TD0UTHF1T.local> References: <20210519123902.2452-1-mark.rutland@arm.com> <20210519123902.2452-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210519123902.2452-7-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_074702_124029_CFF8B884 X-CRM114-Status: UNSURE ( 8.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 01:38:49PM +0100, Mark Rutland wrote: > +/* > + * void call_on_irq_stack(struct pt_regs *regs, > + * void (*func)(struct pt_regs *)); > + * > + * Calls func(regs) using this CPU's irq stack and shadow irq stack. > + */ > +SYM_FUNC_START(call_on_irq_stack) > +#ifdef CONFIG_SHADOW_CALL_STACK > + stp scs_sp, xzr, [sp, #-16]! > + adr_this_cpu scs_sp, irq_shadow_call_stack, x17 The Kbuild test robot spotted this was leading to a link failure, since `irq_shadow_call_stack` does not exist. I've updated this to: ldr_this_cpu scs_sp, irq_shadow_call_stack_ptr, x17 ... which matches how irq_stack_entry acquires the shadow stack pointer today (and passes a boot test). Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel