From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9ABCC433B4 for ; Wed, 19 May 2021 22:03:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C7F6124C for ; Wed, 19 May 2021 22:03:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C7F6124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UIBk6RQUf7LmNc1W+2r1cf7L466Sw0O/tq70C3zW4ZI=; b=EEc4wj2bx7h/JioZMXHWGZgQE AFQ7mJjYpB0Y43+cxE13vW2MnWBPZH/pb0wD++/ekxz/WIgiF+nqs3ARnmDSno+w9zafAjrZmM4RJ eWLGFDOo4ZzvrjIMHHWYKCeJlYHJFGrNGjQYG1PBjk3oCyvqyl07Gdu6GPIHJkyr2amB8P3FRxmZf 4HTd57FKnlLDQFZndgCQoerQGV1U82wtgSFumwH7IpTWeJJisAr1IozBjuUPTo82fDqXmEK6Fue4e 0zfo/r2pBivJFFNuhlM/E/qdzlUqzddupzu4iIC7s4HtRfrRdAh6zLAs7+GynaMfIYy6PjRW3ihZS LK9OX7OqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljUEi-005CGj-9n; Wed, 19 May 2021 22:00:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljUEe-005CGP-6b for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 22:00:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+8jXhSvt0vD8nlukg0WgiNOcbbeDrEDwOGIBKs9apu8=; b=GKKdV25WsKLJlf9onkqrzuTGDS 2JP3astPOUuQHNhUD57M+DHuWlg47HowPwKGIie16PZ/mbh/VNmxT3D0q4WmeYu4/LvAVSEjO8mQb KkXhi3PGucFEzKYEzFF+T4+7FXukuiXe7hbHXGRhbqLHVUwvyhJaPzON5g9CG7dG3D/no/8Rkx1Qi X1xn96P47X1k5kIzq9bvLmpKdjVEoothn4YObjE746vH3xZ7+DBY1lys+luciBJJ12yUFE6xgA3u5 0/woeIAzFplPiaCyqn6iQ9JXMp2v/HmhsjjHLYfEbB0pJNigEs2dhlq9M7G2rWF+Vfl30iWMOdiO3 WhGbBZrw==; Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljUEa-00FoPP-RV for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 22:00:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1621461602; bh=KLTp9TvJTISdCvfu+UFZy1P5nOgOwGxFLgijoG6hkSc=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=jPs0Hd3lGedJKjDAKYMmQFFKddPNo6gGdrZyUubenneiaCktWI5JbdreHplPL//Md ptO28xKZqbzHYut3uiMcB2/b8Q0TeVzcRJZOJvH3V3kwj08iy9sCnt+67dKjhzcQ36 LG4hDU34wowd7M6vgbaEifkSCGDVxiO0ar8fE/o0= Date: Thu, 20 May 2021 00:00:02 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Saravana Kannan Cc: linux-arm-kernel , linux-sunxi@lists.linux.dev, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, Greg Kroah-Hartman , "Rafael J. Wysocki" , LKML , andre.przywara@arm.com Subject: Re: fw_devlink=on and sunxi HDMI Message-ID: <20210519220002.w6e3jf6m5t45vbob@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Saravana Kannan , linux-arm-kernel , linux-sunxi@lists.linux.dev, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, Greg Kroah-Hartman , "Rafael J. Wysocki" , LKML , andre.przywara@arm.com X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20210516170539.2yxe43qwezonuo3r@core> <20210517082957.sddwy2dv5esbzmo4@core> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_150009_082867_13FE6729 X-CRM114-Status: GOOD ( 23.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Saravana, On Wed, May 19, 2021 at 02:29:48PM -0700, Saravana Kannan wrote: > > Nothing in sun8i_hdmi_phy_probe() depends on anything from > sun8i_dw_hdmi.c other than getting a struct device pointer to use with > dev_err and some devm_* APIs. So it seems pretty straightforward to > fix this so that you don't have one struct device trying to represent > two distinct hardware blocks. What am I missing? > > Anyway, I took a swing at fixing this while preserving the ordering of > the important bits. The changes are fairly trivial/straightforward and > not meant to be final code, but can you test this out please? the patch seems to work, after fixing a few compilation issues. See bellow. Thanks! I think the probe order is reversed, but HDMI works in my case, so I guess that doesn't matter in the end. Or at least it didn't in the short test I made. kind regards, o. >From 0eac644368711f52fffa4246aefc546591cef090 Mon Sep 17 00:00:00 2001 From: Ondrej Jirman Date: Wed, 19 May 2021 23:44:45 +0200 Subject: [PATCH] fix compilation issues --- drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c index c44ed22d8aef0..947b4231f6449 100644 --- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c +++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c @@ -5,6 +5,7 @@ #include #include +#include #include "sun8i_dw_hdmi.h" @@ -748,7 +749,7 @@ int sun8i_hdmi_phy_probe(struct platform_device *pdev) return ret; } -void sun8i_hdmi_phy_remove(struct platform_device *pdev) +int sun8i_hdmi_phy_remove(struct platform_device *pdev) { struct sun8i_hdmi_phy *phy = platform_get_drvdata(pdev); -- 2.31.1 [ 0.307254] platform 1c28000.serial: probe deferral - supplier 1c20800.pinctrl not ready [ 0.307340] platform 1c28400.serial: probe deferral - supplier 1c20800.pinctrl not ready [ 0.307379] platform 1c28c00.serial: probe deferral - supplier 1c20800.pinctrl not ready [ 0.309235] fwnode_links_purge_suppliers: display-engine [ 0.310176] platform 1c0c000.lcd-controller: probe deferral - wait for supplier mixer@200000 [ 0.310228] platform 1c0d000.lcd-controller: probe deferral - wait for supplier mixer@200000 [ 0.311902] platform 1ca0000.dsi: probe deferral - wait for supplier pmic@3a3 [ 0.312287] platform 1ee0000.hdmi: probe deferral - wait for supplier pmic@3a3 [ 0.313076] fwnode_links_purge_suppliers: hdmi-phy@1ef0000 <------ phy probed [ 0.316766] platform 1c21800.lradc: probe deferral - wait for supplier pmic@3a3 [ 0.317258] platform vibrator: probe deferral - wait for supplier pmic@3a3 [ 0.318703] sun6i-rtc 1f00000.rtc: registered as rtc0 [ 0.318748] sun6i-rtc 1f00000.rtc: setting system clock to 2021-05-19T21:40:59 UTC (1621460459) [ 0.318917] sun6i-rtc 1f00000.rtc: RTC enabled [ 0.318938] fwnode_links_purge_suppliers: rtc@1f00000 [ 0.318960] fwnode_links_purge_consumers: reboot-mode@4 [ 0.319185] i2c /dev entries driver .... [ 0.453301] fwnode_links_purge_consumers: port [ 0.453323] fwnode_links_purge_consumers: endpoint [ 0.453346] fwnode_links_purge_consumers: panel@0 [ 0.491868] sun4i-drm display-engine: bound 1100000.mixer (ops 0xffffffc010a44230) [ 0.501830] sun4i-drm display-engine: bound 1200000.mixer (ops 0xffffffc010a44230) [ 0.502915] sun4i-drm display-engine: No panel or bridge found... RGB output disabled [ 0.502956] sun4i-drm display-engine: bound 1c0c000.lcd-controller (ops 0xffffffc010a415a0) [ 0.503466] sun4i-drm display-engine: bound 1c0d000.lcd-controller (ops 0xffffffc010a415a0) [ 0.503545] sun4i-drm display-engine: bound 1ca0000.dsi (ops 0xffffffc010a431c8) [ 0.505330] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller v1.32a with HDCP (sun8i_dw_hdmi_phy) [ 0.507566] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI I2C bus driver [ 0.510717] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xffffffc010a43568) [ 0.514674] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0 [ 0.514932] sun4i-drm display-engine: [drm] Cannot find any crtc or sizes [ 0.515160] fwnode_links_purge_suppliers: hdmi@1ee0000 <------ hdmi probed [ 0.515195] fwnode_links_purge_consumers: ports [ 0.515217] fwnode_links_purge_consumers: port@0 [ 0.515240] fwnode_links_purge_consumers: endpoint [ 0.515264] fwnode_links_purge_consumers: port@1 [ 0.515343] fwnode_links_purge_consumers: endpoint [ 0.517089] input: 1c21800.lradc as /devices/platform/soc/1c21800.lradc/input/input1 [ 0.517358] fwnode_links_purge_suppliers: lradc@1c21800 [ 0.517384] fwnode_links_purge_consumers: button-200 [ 0.517407] fwnode_links_purge_consumers: button-400 [ 0.518414] input: gpio-vibrator as /devices/platform/vibrator/input/input2 [ 0.518582] fwnode_links_purge_suppliers: vibrator > -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel