From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E78C433ED for ; Thu, 20 May 2021 06:33:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCB466105A for ; Thu, 20 May 2021 06:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB466105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:Date:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MtXklrGThK6/Mp7dlJ0fVipOhDAyvijulced9bbmJfQ=; b=YoptFUaXEhLEuC878ZAzRDohQ prFudKXt1tW101hY+bVudokHZbl31Sq0/1bFYeRs4WosUbSIo0Ncdi5yMCfNp5irNWdo4r2PkeyQu Slmv0SFkWsTWeHF/9TbKSYjqNvWEvHvq5QATWvmiqEPBWH7c+uhzLzXtaB2Kc3rrBXhS4ZzwlQbOl TLrXleDUfucObZrtlc30MlHqz7sq/M4ygsL5YbcMUzrBGdeN7cO4JEgTjw2rPxmqtq8ZUWwMoFhn4 4VQhpn7smX+B2AjtmuPgSNUuyT9pZAuaBcWfGNaDG9ihiO4Mu+SPTxK11S6rtHZMDof+xgjAiAwug 0bQFFsR/g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljcD6-006306-Fj; Thu, 20 May 2021 06:31:08 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljcD1-0062zo-SZ for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 06:31:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:Date:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T8MGweMWh8G1Vb1FxsntXZZXVCiDZgcu3o7qGFDrNfw=; b=owvAe053wRb2gCfMPHuHXu0qFI PwDovswcifohdzJyWL1VZlvvSv02qsX2elbggbBIL+PaYcyd6a1O0EMzl+G1hBn/L6TTcsE0smXlk 29ZULHrAbbnhyE6xQpqSpCr3Jzy/GQL4+52Zmg53PkB58IwmU08p/+QC60tEAjl+6dhBcsHUB0fFh hEAeY8n+kFHhpwxT84NoC5xpwLcmLswJevJ4HRjoLljOef8q2yKNXcLY0chZv6b80+S8laUqAcI2l KhLByfcwiuCRTcfLJ0rDsFWScCZLMLZBzdcVgOiyezh9WD1o9ZNiOL1iFGj/z2T5OvEMZM2AyQj2Y Y+NfaF7A==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljcCw-00FzZ7-Mz for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 06:31:00 +0000 Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ljcCt-0002Ac-UD for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 06:30:56 +0000 Received: by mail-ed1-f71.google.com with SMTP id c15-20020a05640227cfb029038d710bf29cso2994190ede.16 for ; Wed, 19 May 2021 23:30:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:organization:mime-version; bh=T8MGweMWh8G1Vb1FxsntXZZXVCiDZgcu3o7qGFDrNfw=; b=ogL1/fuD0Y6nKxEt37qixxTafAB7q5qrxXBbIizr/rx9b7O+VyYOhk+rANrOGyTMPI OBLipkhrTFRtFe6L3TN6Ku68wHdiv+br1WAF9n6MuENhdQL722CGO0wXfuJOuJuOzthM UwTs0rAbkRt4yvuDQ9speQyM1kPKXvqvXFHRtRyvnPQFEwmvBVwayOX2Hsx7h9TjCveJ pNDI85TgB17K60uq5+2fScf6Kq7A/O8aVt3TU5FUUfYwiZCaNOQnFdJsnveTF0XT+6rg dMXSAsx0onLCb2jXsHTjPOCXUOPC7Q5CnfBXCtzmmI/NFH4tbReDeGwcJbsvflg/by95 SDtA== X-Gm-Message-State: AOAM533pDXelz7FQyLkfhcFnNsTef5W17yyJtSrfi8CvEcPFeJ2iXrsk Zu8hh0p0TBDpxCUMosZZZW88yypE8hGRbaniNT3CBT5SFOMU04GelJIOu6nMD0UecmgablPdmzF 5OsL/U6UZgok2JKrRZ6R+FA6Vta/W5imoDKOBpifRvPSMiNNM8olp X-Received: by 2002:a50:ff13:: with SMTP id a19mr3255217edu.300.1621492255640; Wed, 19 May 2021 23:30:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNuPb1H6GgcBejEqtfEk4G+6+0hpLo6D3PmJC9QoZVsHwbgkZ+4/XF36vpbR0o9XtSZq3ixA== X-Received: by 2002:a50:ff13:: with SMTP id a19mr3255207edu.300.1621492255469; Wed, 19 May 2021 23:30:55 -0700 (PDT) Received: from smeagol ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id fb19sm882547ejc.10.2021.05.19.23.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 23:30:54 -0700 (PDT) From: Juerg Haefliger X-Google-Original-From: Juerg Haefliger Date: Thu, 20 May 2021 08:30:52 +0200 To: Joe Perches Cc: Juerg Haefliger , wim@linux-watchdog.org, linux@roeck-us.net, joel@jms.id.au, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: Use sysfs_emit() and sysfs_emit_at() in "show" functions Message-ID: <20210520083052.68a0e1d9@smeagol> In-Reply-To: References: <20210511061812.480172-1-juergh@canonical.com> Organization: Canonical Ltd X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_233058_776666_99372F06 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7492977608523967120==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7492977608523967120== Content-Type: multipart/signed; boundary="Sig_/L_fDvoyzrJmgDY0oW_xHuS="; protocol="application/pgp-signature"; micalg=pgp-sha512 --Sig_/L_fDvoyzrJmgDY0oW_xHuS= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 12 May 2021 21:48:37 -0700 Joe Perches wrote: > On Tue, 2021-05-11 at 08:18 +0200, Juerg Haefliger wrote: > > Convert sprintf() in sysfs "show" functions to sysfs_emit() and > > sysfs_emit_at() in order to check for buffer overruns in sysfs outputs.= =20 > [] > > diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_= wdt.c =20 > [] > > @@ -445,8 +445,9 @@ static ssize_t ziirave_wdt_sysfs_show_firm(struct d= evice *dev, > > =C2=A0 if (ret) > > =C2=A0 return ret; > > =C2=A0 > >=20 > > - ret =3D sprintf(buf, ZIIRAVE_FW_VERSION_FMT, w_priv->firmware_rev.maj= or, > > - w_priv->firmware_rev.minor); > > + ret =3D sysfs_emit(buf, ZIIRAVE_FW_VERSION_FMT, > > + w_priv->firmware_rev.major, > > + w_priv->firmware_rev.minor); > > =C2=A0 > >=20 > > =C2=A0 mutex_unlock(&w_priv->sysfs_mutex); > > =C2=A0 > >=20 > > @@ -468,8 +469,9 @@ static ssize_t ziirave_wdt_sysfs_show_boot(struct d= evice *dev, > > =C2=A0 if (ret) > > =C2=A0 return ret; > > =C2=A0 > >=20 > > - ret =3D sprintf(buf, ZIIRAVE_BL_VERSION_FMT, w_priv->bootloader_rev.m= ajor, > > - w_priv->bootloader_rev.minor); > > + ret =3D sysfs_emit(buf, ZIIRAVE_BL_VERSION_FMT, > > + w_priv->bootloader_rev.major, > > + w_priv->bootloader_rev.minor); > > =C2=A0 > >=20 > > =C2=A0 mutex_unlock(&w_priv->sysfs_mutex); > > =C2=A0 > >=20 > > @@ -491,7 +493,7 @@ static ssize_t ziirave_wdt_sysfs_show_reason(struct= device *dev, > > =C2=A0 if (ret) > > =C2=A0 return ret; > > =C2=A0 > >=20 > > - ret =3D sprintf(buf, "%s", ziirave_reasons[w_priv->reset_reason]); > > + ret =3D sysfs_emit(buf, "%s", ziirave_reasons[w_priv->reset_reason]);= =20 >=20 > All of these formats should probably end with a newline > and the ZIIRAVE__VERSION_FMT defines are to me unnecessary. >=20 I'll send a follow-on patch for that. ...Juerg --Sig_/L_fDvoyzrJmgDY0oW_xHuS= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAmCmAhwACgkQD9OLCQum QrdOUhAAhmiMFmidekLXp9pqzm0r5JwSAY1m4G+OnbZpW9WCaxohD8bivxvVa7Xm 6EQ6SNXkM6joh9iOr0MOawpiWxD2M//Cfuy2XKMSQudbTE4TE8rDD6KbgsBxWzd4 6z82Nsd56uBA87Hrl3pVuVBHtPffIxHZGIc04GQIP24up9hZRmeZZj74trNOSdSb Dtf0zv2qkkWsWNTolj/aVK9oIo/gRYKFYS4Y2pouUyWO9ZKwceJoKdCZtzZjIeUT PIRyAFdd0LR4yVUxIF4pZSixNuL1o03ny5jRIBT8ToYxfS1jielPtsvlva7MWLdW wBACWcOkS6ZvvKdYyFDBmvi/6MOwkrLzPuoVxeMitWMZKVoyKXwff8pCPOLd+IVk qGKNjn1bNT2oi3AgDo6oA13Fl8rrkRpeJPi5aHZtmz0gs/xBsyD55l2tEBuBQREF z6hU4+R7FUak99gLvIVDIaKqmJn6k/1fRoCKr9BokKgS9yqJl8DVxkRNXP1LfaQt 5RO5nsWLmgI5vSW2ScDa8hHBE0eGgaVaLJeRTSyreuTQFNJrAWpgu3Fc4LKUT2JR CXyR+PFBZyNQLv4SomVOztXBN83EO4cBYFebZQF3JERAOdzy4FUvwnuDj+cq//fA Ra6RAuVCO3+yjoIxNZVXpZiVIdPQlYeIIzBNwiSJJh06OXpovqI= =lrYW -----END PGP SIGNATURE----- --Sig_/L_fDvoyzrJmgDY0oW_xHuS=-- --===============7492977608523967120== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7492977608523967120==--