From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F65C433ED for ; Thu, 20 May 2021 13:43:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9291D60240 for ; Thu, 20 May 2021 13:43:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9291D60240 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xM1UYyuysJVxE4j/TawqXpqGyZ25G4VQy+LKWkNX3d4=; b=Q5UaZY77t6H4lv4iEtlcpCj7QS hoq2GgSlVGx5uqZTaJ6TE1nh/08vvoJe1NvYinHUt5ceAKmAKg6Bb38LSM4feyufZ7Hdy+CP+DCu1 eMr1gtAu3EeMEynSWjWMUTIiOnrrNt7xPkqZqLKCqC8C1LEIFHVpiyALZWXkpOlY1tmPXx2iPwnq/ o/nke83/f7LZDcJ6p5Ei+GYD2Imm6+CfjeXpfNCE6zTPT0faDrzlD7dP1/LwFL4l9YXIQDqSU7xiD hx1vpE+4y1s0Rb8SF4wlp58NPKyDUiRTcq8VUUPvBWMxLnln4CH4EHpvgJvZATlxzuhX0gKzmR8Jg E4Qu6q1Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljivs-001Fl9-U8; Thu, 20 May 2021 13:41:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljivr-001Fkr-9S for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 13:41:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NzysMlm/BUH/w03D45s98fi6UMQpfCETbmthl1hZcMc=; b=UEPqaqVRAJCruFKxA6awpbec3/ OieDw/CCU0ZQup1rQ9T96gM/jJpfknTSoljdQQDHWFj/GIv9IVLjmpGfO7wT8LO0kRRMlhzwN9Ojt uh9qPEami1WmBY8qr9iWhL/pvhEOdWj9y42CSQeeIFO9+uTk+a9BVz13cy+Rog62qyOn0Mg5uv8rP /vic0enfEq+3CQyfJzIkcUaAONg1/ld2K120t7hgOfFvm2LLZi3lOZRki44SDGwERvSqvT3taKtZH ev40G5jLYHfsk+XDBS6RaDW+D7V9ZmV1CSDmvJD+1EPmbYU1dYrM7E025Kced+9Ucke5nIa6W8NnM H69qsl2Q==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljivn-00GNcI-TZ for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 13:41:45 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14KDfeRf038341; Thu, 20 May 2021 08:41:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1621518100; bh=NzysMlm/BUH/w03D45s98fi6UMQpfCETbmthl1hZcMc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vLB1IazODqqfLSF4SRyxPeVKfUiQtkNqCRJHIbcEQWq29Oa2A4HjBHl0q7IVeeZ+3 Rp+4Q2i12cZNS53OxEbrUI7HfPS/MOwBG7x7DLcieBTX6oYdlU+IxLERV6DYRh5m3Y zSRa2wJhEH5/9/eZJAoKpj1aZVNX0Fd6glirq8pk= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14KDfep3112909 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 20 May 2021 08:41:40 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 20 May 2021 08:41:40 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 20 May 2021 08:41:40 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14KDfeuO094474; Thu, 20 May 2021 08:41:40 -0500 Date: Thu, 20 May 2021 08:41:40 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Tero Kristo , Rob Herring , , , , Lokesh Vutla Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Fix external refclk input to SERDES Message-ID: <20210520134140.qzjl7td7ojoqudok@snippet> References: <20210512151209.27560-1-kishon@ti.com> <20210512151209.27560-2-kishon@ti.com> <20210512185157.q5sr2xqf3w5igfte@imagines> <68c95cf1-84fa-2194-7bb1-e3c60e7f1fc0@ti.com> <20210513140137.5uvftgtsku3xfobz@engraving> <81b7dc76-0918-0a95-5715-cf701e638bbe@ti.com> <20210517140519.4ltzvw3k74z72urz@dingo> <3529e35f-0bef-fd8c-515a-6d4552f2467d@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3529e35f-0bef-fd8c-515a-6d4552f2467d@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_064144_079587_F8C4FFD9 X-CRM114-Status: GOOD ( 26.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18:48-20210520, Kishon Vijay Abraham I wrote: > Hi Nishanth, > > On 17/05/21 7:35 pm, Nishanth Menon wrote: > > On 14:00-20210517, Kishon Vijay Abraham I wrote: > >> Hi Nishanth, > >> > >> On 13/05/21 7:31 pm, Nishanth Menon wrote: > >>> On 17:41-20210513, Kishon Vijay Abraham I wrote: > >>>> Hi Nishanth, > >>>> > >>>> On 13/05/21 12:21 am, Nishanth Menon wrote: > >>>>> On 20:42-20210512, Kishon Vijay Abraham I wrote: > >>>>>> Rename the external refclk inputs to the SERDES from > >>>>>> dummy_cmn_refclk/dummy_cmn_refclk1 to cmn_refclk/cmn_refclk1 > >>>>>> respectively. Also move the external refclk DT nodes outside the > >>>>>> cbass_main DT node. Since in j721e common processor board, only the > >>>>>> cmn_refclk1 is connected to 100MHz clock, fix the clock frequency. > >>>>>> > >>>>>> Fixes: afd094ebe69f ("arm64: dts: ti: k3-j721e-main: Add WIZ and SERDES PHY nodes") > >>>>> > >>>>> Assume we want this part of 5.13 fixes? > >>>> > >>>> This doesn't fix any functionality. Okay for me to go in 5.14 along with > >>>> the rest of the series. > >>> > >>> > >>>>> > >>>>>> Signed-off-by: Kishon Vijay Abraham I > >>>>>> --- > >>>>>> .../dts/ti/k3-j721e-common-proc-board.dts | 4 ++ > >>>>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 58 ++++++++++--------- > >>>>>> 2 files changed, 34 insertions(+), 28 deletions(-) > >>>>>> > >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>>>> index 60764366e22b..86f7ab511ee8 100644 > >>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>>>> @@ -635,6 +635,10 @@ > >>>>>> status = "disabled"; > >>>>>> }; > >>>>>> > >>>>>> +&cmn_refclk1 { > >>>>>> + clock-frequency = <100000000>; > >>>>>> +}; > >>>>>> + > >>>>>> &serdes0 { > >>>>>> serdes0_pcie_link: link@0 { > >>>>>> reg = <0>; > >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>>>> index c2aa45a3ac79..002a0c1520ee 100644 > >>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>>>> @@ -8,6 +8,20 @@ > >>>>>> #include > >>>>>> #include > >>>>>> > >>>>>> +/ { > >>>>>> + cmn_refclk: cmn-refclk { > >>>>>> + #clock-cells = <0>; > >>>>>> + compatible = "fixed-clock"; > >>>>>> + clock-frequency = <0>; > >>>>>> + }; > >>>>>> + > >>>>>> + cmn_refclk1: cmn-refclk1 { > >>>>> > >>>>> Just curious: why cant we use the standard nodenames with clock? > >>>> > >>>> We can use standard names here. Is there any defined nodename for > >>>> clocks? clk or clock? Don't see $nodename defined for clocks in > >>>> dt-schema repository. > >>> > >>> Looking at the fixed-clock example, lets go with clock > >> > >> Since I have two clocks here adding clock@0 and clock@1 introduces the > >> following error. > >> /home/a0393678/repos/linux-wip/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: > >> /: clock@0: 'anyOf' conditional failed, one must be fixed: > >> 'reg' is a required property > >> 'ranges' is a required property > >> > >> The current "fixed-clock" binding doesn't allow adding "reg" property. > >> We'll stick to non standard names? or do you think the binding has to be > >> fixed? > > > > Look at other fixed-clock examples in other arm64 examples > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mm.dtsi#n147 > > is a good one.. Binding is fine, IMHO. > > Ah Thanks. It only has to be prefixed with clock-. Yep - also, though I think it is self evident, I will explicitly state as well: since dts should represent hardware, using names like "dummy" does'nt belong to dts - it would indicate something of a software construct. Knowing what you are trying to describe, I do understand it is not a "software construct", but please avoid using similar naming which may create misunderstanding. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel