From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109ACC433ED for ; Thu, 20 May 2021 14:18:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBBCB611AE for ; Thu, 20 May 2021 14:18:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBBCB611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xPYudBTwVmsInY0R522JmxpPWM8R08rfs1tRwx2REf8=; b=N+fBE4dlUv1YGr4fj1qabud9oO F+NHMw2woxU4ijhQHXkT+gu5xxrbEoGz/ZaJGaf9V3plGj0Pfyp/JvTT+4uuL2y2ul0NBfxqiLkb2 SoSnnvWZ58twK4F/Jv901bptvvOauSv+B0DXwlWjiZakyTTCP6l4Lt3GYVXuhjlG34lM59PciQlGq 46G9WDXgpAFk6fgaiFkjq6SskapQFOnc6kOqtDQFSju3fexIg5eyfNUD7USWyr+RgIWdOZtFAsuHh N0dogJ613dMDwPEUUNAQjrlQjm7r8c4q9OztcUeGIWSFgMeh42oeHb/HcFOptZ5SfoGQlCUefnof+ 0Eab/FbQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljjTR-001QLk-Hz; Thu, 20 May 2021 14:16:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljjT3-001QBO-9d for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 14:16:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2yBURacJyAaRxjbBSlP+agTfT28gWdOYW2NWQlY+kkg=; b=VCDUMYpCEIyIBrC2/NVSZy8Fv3 U1r1Y1oUjoB90/3NSWw5d1slkFAw0hfSmBo82cI05ubFkRy1yQfRhJchKiuhYWIHIQH/WoPP/g8ge CS5x3JRVyLAfOncOZnJgYrwDYb28n+7qs2FiMw8KoZUtxkoBsB/FzdMl4PvN6BJFmAv07wqW65ub/ cAI+yFgXv/74O/9vohohUhrb+mrySZ/VEI7rIDYB3DNWgh9gVLQQlLe+pncvuzkYXuT4rYd48AbgU jTnR7aNrIshKiQEJVVzekYO7ctWzF1nhcOYPGhrmmzkGFsJzNeo4I2Sg/n6hdeRqQAfCyjiTR7Nhd vvA4V2Eg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljjSz-00GPpd-DD for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 14:16:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B8A811D4; Thu, 20 May 2021 07:15:59 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.7.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB0563F73B; Thu, 20 May 2021 07:15:57 -0700 (PDT) Date: Thu, 20 May 2021 15:15:55 +0100 From: Mark Rutland To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com Subject: Re: [PATCH v3 07/18] arm64: Downgrade flush_icache_range to invalidate Message-ID: <20210520141555.GJ17233@C02TD0UTHF1T.local> References: <20210520124406.2731873-1-tabba@google.com> <20210520124406.2731873-8-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520124406.2731873-8-tabba@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_071601_516401_E0926E67 X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 01:43:55PM +0100, Fuad Tabba wrote: > Since __flush_dcache_area is called right before, > invalidate_icache_range is sufficient in this case. > > Rewrite the comment to better explain the rationale behind the > cache maintenance operations used here. > > No functional change intended. > Possible performance impact due to invalidating only the icache > rather than invalidating and cleaning both caches. > > Reported-by: Catalin Marinas > Reported-by: Will Deacon > Link: https://lore.kernel.org/linux-arch/20200511110014.lb9PEahJ4hVOYrbwIb_qUHXyNy9KQzNFdb_I3YlzY6A@z/ > Signed-off-by: Fuad Tabba Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/machine_kexec.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 90a335c74442..a03944fd0cd4 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -68,10 +68,14 @@ int machine_kexec_post_load(struct kimage *kimage) > kimage->arch.kern_reloc = __pa(reloc_code); > kexec_image_info(kimage); > > - /* Flush the reloc_code in preparation for its execution. */ > + /* > + * For execution with the MMU off, reloc_code needs to be cleaned to the > + * PoC and invalidated from the I-cache. > + */ > __flush_dcache_area(reloc_code, arm64_relocate_new_kernel_size); > - flush_icache_range((uintptr_t)reloc_code, (uintptr_t)reloc_code + > - arm64_relocate_new_kernel_size); > + invalidate_icache_range((uintptr_t)reloc_code, > + (uintptr_t)reloc_code + > + arm64_relocate_new_kernel_size); > > return 0; > } > -- > 2.31.1.751.gd2f1c929bd-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel