From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B03C433ED for ; Fri, 21 May 2021 01:55:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9875561246 for ; Fri, 21 May 2021 01:55:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9875561246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UPR80Vej2b/OfLS6yJ2VNchpm7zSUGN7NYZPmuSoEeM=; b=azkPV5UIDXg1gUZnC6UrB4+Af3 RaxzqgaG1U5XuisnmI1I7Zpny4rz1nJwWXebwh6fQGVauOdJs4y1kqjRkABIT5Z2PyAdHqfGHeey2 LffWHXM8nT8W9dK32NmMP9zq2L3iOzlkXswEJXOkihWBy5RlIwT1zPbh+JONrWL2nxYukrbT97ksn W99DuMtZuyIMdro1kImS0Iwwefh2Th0gcXXmkITtsNWuHimgTw9FzFlY8E889RaJSoGW/V73BnKjk wFGTBW+sDSO71zO1aN72YoS/RsuhE/gVYI8dA+IBGhZA1iVgBkqhaTLh3ih+kzkYB6nTdMCFLtkgU QE3CWFNg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuL0-003My7-BI; Fri, 21 May 2021 01:52:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuKb-003Moc-58 for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 01:52:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TeR6dx8Rqr3ByExvzXzaPr3AoEZSg27P4QPA34TUl50=; b=pvJ0Wb+F/UnSlP/YZ8i85R2dZH mI4ixQWHrQrfvddw8TIM64uq52Ykfe6/ZWaFu4MSJY5ikB1AtmBu7jznGz3eush8bdCGf8it1ceUS ezIDrgdM3yMO65wXnhp9gtEcaZviEa3bZvaYJhDAN/aoAeXNIVdJJiOC6qgzseQT+qNqG83d4Y1z7 RYpL2b71IWaIwYQSy0t659Sstv90Hx+5U8oGyWDjP93pEOfLgmQAvOnPFAoyrGI2x4lw3MNc/caVJ ceJsdBBZ01Ox8bQkLYd9mncAs4CRpvhwrW6PiHwDBm70vkCYZQWdgSYdLaucUo53chYBe2EzwjXOr jA6GVPxg==; Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljuKY-00Gl0D-KM for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 01:52:03 +0000 Received: by mail-pl1-x62d.google.com with SMTP id t9so1686278ply.6 for ; Thu, 20 May 2021 18:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TeR6dx8Rqr3ByExvzXzaPr3AoEZSg27P4QPA34TUl50=; b=MGywRptRl4M03Loj0uWb0Q68foEF2W7FLLb6e2Y3yaSpAS41cQJOIlc+Yodwrt14+B o5A8zY9VfTUFffOgbb7ZCroEftruHMd3VvG0Xksws27jXojgM5CKt9ZQ5MknLgvgetlm Qozs9MN+rdGEoiOix5e5xIOU3ppyzW4RuIi+A7iMMzjkpBE9NtZLzOaIAVmamQr4RsCW ft1FDBQy++SQwvzxEx/ipWcZ+SL7sMpanfO1ViUsK6G98HM469/Z48/lA6lPpBAdNbQw bFaHu86UWSMGHMRuqp5UMqyqmk9RU9qLDXzaT4bnkhcZHGFh/CR3h1Z0NlgRXQu4zGzX CrCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TeR6dx8Rqr3ByExvzXzaPr3AoEZSg27P4QPA34TUl50=; b=swNM1kYrYTEWM8hZoMRvuuZn2z95xRQeFL4ai+QaJIkLBifVqbdvzSykAfDEZdwlqs C2HoAxzct741aZBo49Aw+QmGdIYwxs2qLEotmTjAPnWdv/8cVYoO9bUqSHzFKjW8k0nO L3Q81nOlEsybRaclNSHX6Sqf7mk/3sppaBMgaATF5QkWTXohXYBd5G7Kp9F1pRGyymv2 GFUV+sfqcYg3JsSUgfVVb4bne8GHZkqranOoykNp88KY3Y72qAIvyrR/H5rDt/vS/UK5 /vCtPEw6731U283tJH9ZbfF4BldEA3WUQaE1+QpumLgYii2QmzYMDFraZ8mJe1YkBYMq dJqQ== X-Gm-Message-State: AOAM530Q43W1iLa2WzaLktaRs6+8LT3V9zkAzuYoZcod1W5HLN2NgX+D AUrMeOphRxWZ+hBGfsnITL8= X-Google-Smtp-Source: ABdhPJyIynOYYSDS+EbUq2ewNtwe4ZXjkjDPNl8WBvxs05rpGvv+SWNeotnMz6g0roHINjQ+ss8nrg== X-Received: by 2002:a17:90a:4404:: with SMTP id s4mr8354235pjg.218.1621561921013; Thu, 20 May 2021 18:52:01 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id u6sm2538958pjy.51.2021.05.20.18.51.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 May 2021 18:52:00 -0700 (PDT) Date: Thu, 20 May 2021 18:51:53 -0700 From: Tao Ren To: Guenter Roeck Cc: Wim Van Sebroeck , Joel Stanley , Andrew Jeffery , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Tao Ren , Amithash Prasad Subject: Re: [PATCH] watchdog: aspeed: fix hardware timeout calculation Message-ID: <20210521015153.GA19153@taoren-ubuntu-R90MNF91> References: <20210417034249.5978-1-rentao.bupt@gmail.com> <20210417042048.GA109800@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210417042048.GA109800@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_185202_705219_BE932CC6 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wim, Not sure if I looked at the wrong repository/branch, and looks like the patch is not included. Do you have any further suggestions? Or should I send out v2 in case it's missed? Thanks, Tao On Fri, Apr 16, 2021 at 09:20:48PM -0700, Guenter Roeck wrote: > On Fri, Apr 16, 2021 at 08:42:49PM -0700, rentao.bupt@gmail.com wrote: > > From: Tao Ren > > > > Fix hardware timeout calculation in aspeed_wdt_set_timeout function to > > ensure the reload value does not exceed the hardware limit. > > > > Fixes: efa859f7d786 ("watchdog: Add Aspeed watchdog driver") > > Reported-by: Amithash Prasad > > Signed-off-by: Tao Ren > > Reviewed-by: Guenter Roeck > > > --- > > drivers/watchdog/aspeed_wdt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c > > index 7e00960651fa..507fd815d767 100644 > > --- a/drivers/watchdog/aspeed_wdt.c > > +++ b/drivers/watchdog/aspeed_wdt.c > > @@ -147,7 +147,7 @@ static int aspeed_wdt_set_timeout(struct watchdog_device *wdd, > > > > wdd->timeout = timeout; > > > > - actual = min(timeout, wdd->max_hw_heartbeat_ms * 1000); > > + actual = min(timeout, wdd->max_hw_heartbeat_ms / 1000); > > > > writel(actual * WDT_RATE_1MHZ, wdt->base + WDT_RELOAD_VALUE); > > writel(WDT_RESTART_MAGIC, wdt->base + WDT_RESTART); > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel