From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB19C433B4 for ; Fri, 21 May 2021 02:08:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7296D600CD for ; Fri, 21 May 2021 02:08:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7296D600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cd6OhOnT38goTYJk/DnSVhwOZso8Vcs8+DtjBetKb7o=; b=AGVjwMRc6BUhO+2fqP7G6TR0IM KWMdueq+au8rqY5CWjdHELK83/gSDgkyCIgqRm//v+PJrAx1SPg+p7JpMp/1kurHh8DLv1ZLfNKa6 5hsJ41e5L/YWqUY0QuVM5L2SdgGHJVg/Q+bbg1EOeQJcVTxG5cl4w+BwjXLPEqLAJ/Rv0OFt+xgrB aDZx5Oc4+0pRV2X3UNICfSAQ7iprR/WcIBRBuLN/gUAdbYSTATEtsuUhkmMAa30qp3dFgUJvCLEAf sBySh+2tKsZIJM11FRQOSxoLAalKLOQc8KqFh+HZO1aBvGJvLlMjdPHse1zxUA6/TwOhb4zq8J0kC PvB0YxGw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuXz-003QkE-CG; Fri, 21 May 2021 02:05:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuSx-003PpS-Da for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 02:00:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9fB9txKIQZNMl67yv7ERq72Q+6wcnvrLhnIU26tnTf4=; b=JG+hNnFJaRgvRRD8nTXTp7B2Sg vSe+gwh7ExGUym37i/8fW0cofaNlThVNRWiZ23e7xHoyO/m6RljqRAH796yEqPG0afh+ulgVP8FoI zKuzManig0DtQkMFJO/zWL8KeW4Jh/KPucvwUawdaeUH/dgAKluUX9hjSeDCyxJ9VsdnOPfDeXWA4 MuDcbr8n7Clrm55mcKv2GIG+yfYfAJfUYhH3t4vqjI/hYaWuWOpI/l9FYodih8rgadiAUETdPeReW HCGvJBBwG1UacPZfy2+hyNJXBtwKkAWfbfme5vaDa8eZIl3UDWy4VIAMFvTLJ3yzlyPIAmi7KnH+k ziZnBX1A==; Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljuSu-00GlH8-K6 for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 02:00:41 +0000 Received: by mail-pj1-x1031.google.com with SMTP id h20-20020a17090aa894b029015db8f3969eso5695875pjq.3 for ; Thu, 20 May 2021 19:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9fB9txKIQZNMl67yv7ERq72Q+6wcnvrLhnIU26tnTf4=; b=An1xKWU/mWO08cY0cP24LyKkNnOv5zCCLUdnglRtraCTvQQzxVh9tTfYP1YanUjoR8 gFtYTxBnypDtTZJxyxQ1tMDJtzdMMTs5rHApnAEd/aQWzVn+hLHmzuypSaML2xrdpRCW +atdTnZ2DCoPjdD9qdm1EhlEDGaoVnmocolZmRF7sErnz5ofewaQGpXASxT8QxwUiUai nj86+/F36GPfLpYIIDyoKPdhyetIbbr07I+lFT1YwrnBmgBe0t2Svn7GZ5BNKqRlLY2/ CGzlvZ+aIKnYSNNGv4xYAR9uUG2Ao2Igzhd1uppZXRCZB6hTlZNwDp4EPHaQ6nKsT/a/ loIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9fB9txKIQZNMl67yv7ERq72Q+6wcnvrLhnIU26tnTf4=; b=AyN1x9GkallSxjETDz4WoVdPOfW18lPreomt/1gJjvmbqb4zAioNQwqQ1QF9FOaZbj HF0t1ixRwmkd9jHwxnVlwisbfl8/ntFupD1CL6C5OPRti0GyT6b0Kppvnke1wpowjNd9 oEWfnQ6l7iV1MeOb3A80161rt3flO86gAHWFrpFrrfOwAPQu1kbQMUnN3NQq0nULQHTu olU6pLy8ulUSKHBYmPJxFCL4QJ2/uEIhac+PIJgmUm+l/LUZGtOM7bpChDyQep1ET38N lNCF9STBVpKB6bZ//Q4KExq4/ESvIz7aGVd7UdnaUS+MpwDCH2Id4EGKUr0Dhes9+BP7 allQ== X-Gm-Message-State: AOAM532nAyBM5S0PMkZ1RpzuyTOVUotn9I/Xq8b1fZa05iJBVQQTpwKS uZflfSl9t6YWInXyRqG59jM= X-Google-Smtp-Source: ABdhPJwBofzBAXoo5pDmXX4ye8/TsvSpB7pKcMIb3pVYhLkIdagqbQ5wvHtXHUJZRNsbTl2FgNx8tA== X-Received: by 2002:a17:90a:f811:: with SMTP id ij17mr8130069pjb.63.1621562439317; Thu, 20 May 2021 19:00:39 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id w74sm2869555pfd.209.2021.05.20.19.00.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 May 2021 19:00:39 -0700 (PDT) Date: Thu, 20 May 2021 19:00:34 -0700 From: Tao Ren To: Jamin Lin Cc: Joel Stanley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED I2C DRIVER" , Brendan Higgins , open list , Rob Herring , Rayn Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , Steven Lee , "moderated list:ARM/ASPEED MACHINE SUPPORT" Subject: Re: [PATCH 1/3] i2c: aspeed: avoid new registers definition of AST2600 Message-ID: <20210521020033.GB19153@taoren-ubuntu-R90MNF91> References: <20210519080436.18975-1-jamin_lin@aspeedtech.com> <20210519080436.18975-2-jamin_lin@aspeedtech.com> <20210520033140.GA3656@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520033140.GA3656@aspeedtech.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_190040_681506_B0085ED6 X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jamin, On Thu, May 20, 2021 at 11:31:41AM +0800, Jamin Lin wrote: > The 05/19/2021 22:59, Joel Stanley wrote: > > On Wed, 19 May 2021 at 08:05, Jamin Lin wrote: > > > > > > The register definition between AST2600 A2 and A3 is different. > > > This patch avoid new registers definition of AST2600 to use > > > this driver. We will submit the path for the new registers > > > definition of AST2600. > > > > The AST2600 v9 datasheet says that bit 2 selects between old and new > > register sets, and that the old register set is the default. > > > > Has the default changed for the A3?, and the datasheet is incorrect? > > > > Does the A3 still support the old register set? > > > We suggest user to use the new i2c driver for AST2600 and we will sumbit > it. This driver is used to AST2500 and AST2400 SOCs. Change this > driver to check global register of i2c to avoid user build the wrong driver. If I understand correctly, the answer implies old register set is still supported in A3 although aspeed suggest people using the new driver/mode? Can you please share more context behind the suggestion? Such as new register mode has better performance? Or some known issues that were deteted in old mode are fixed in new register mode? Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel