linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	devicetree@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vivek Unune" <npcomplete13@gmail.com>,
	"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [PATCH V3 robh dt/next] dt-bindings: mfd: add Broadcom CRU
Date: Fri, 21 May 2021 16:06:03 +0100	[thread overview]
Message-ID: <20210521150603.GJ2549456@dell> (raw)
In-Reply-To: <CAL_JsqL0kP7eBafRkX2eNQ5_ihJgkPhsjdi3vKCzqOXo+C-HUw@mail.gmail.com>

On Fri, 21 May 2021, Rob Herring wrote:

> On Fri, May 21, 2021 at 8:51 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 21 May 2021, Rob Herring wrote:
> >
> > > On Fri, May 21, 2021 at 2:31 AM Lee Jones <lee.jones@linaro.org> wrote:
> > > >
> > > > On Fri, 21 May 2021, Rafał Miłecki wrote:
> > > >
> > > > > On 21.05.2021 09:12, Lee Jones wrote:
> > > > > > On Thu, 20 May 2021, Rob Herring wrote:
> > > > > >
> > > > > > > On Wed, May 19, 2021 at 1:40 PM Rafał Miłecki <zajec5@gmail.com> wrote:
> > > > > > > >
> > > > > > > > From: Rafał Miłecki <rafal@milecki.pl>
> > > > > > > >
> > > > > > > > CRU is a block used in e.g. Northstar devices. It can be seen in the
> > > > > > > > bcm5301x.dtsi and this binding documents its proper usage.
> > > > > > > >
> > > > > > > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > > ---
> > > > > > > > Rob: would you take this patch through your dt/next?
> > > > > > >
> > > > > > > I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is
> > > > > > > already upstream. For ac5f8197d15c, I could get a stable branch from
> > > > > > > Linus, but I can't take some random github branch. Even if I got a
> > > > > > > stable branch for that, that's a lot of extra work for me for 1 patch
> > > > > > > compared to waiting til next cycle.
> > > > > > >
> > > > > > > My suggestion is get a stable branch/tag from Linus, merge that into
> > > > > > > the Broadcom branch and then apply this patch. Though really, Linus
> > > > > > > needed to know the dependency when applying the patch if he doesn't
> > > > > > > rebase his tree. (I realize the dependency probably happened because
> > > > > > > of the review).
> > > > > > >
> > > > > > > >
> > > > > > > > V2: Use complete binding & change additionalProperties to false
> > > > > > > > V3: Use clock-controller@ for clocks
> > > > > > > >
> > > > > > > > NOTICE: this patch is based on top of the linux-next as it requires:
> > > > > > > > ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema")
> > > > > > > > 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema")
> > > > > > > > AND merged git@github.com:Broadcom/stblinux.git devicetree/next as it requires:
> > > > > > > > 8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema")
> > > > > > > >
> > > > > > > > This is reworked version of the
> > > > > > > > [PATCH robh next] dt-bindings: bus: add Broadcom CRU
> > > > > > > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210309142241.16259-1-zajec5@gmail.com/
> > > > > > > > ---
> > > > > > > >   .../devicetree/bindings/mfd/brcm,cru.yaml     | 86 +++++++++++++++++++
> > > > > > > >   1 file changed, 86 insertions(+)
> > > > > > > >   create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml
> > > > > >
> > > > > > What's the dependency here?  It's a new file that doesn't reference anything.
> > > > >
> > > > > Without dependencies it will cause warnings for those running "dt_binding_check".
> > > >
> > > > No one runs that, it's full of warnings. ;)
> > >
> > > That's dtbs_check on dts files which is full of warnings.
> > > dt_binding_check for the schema does not have warnings (well, there's
> > > a couple typically because either the bindings aren't reviewed or the
> > > dependencies are ignored).
> > >
> > > > > I didn't find it critical so I thought Rob can take in on a promise of
> > > > > what is queued for the next release. It appears Rob has more strict
> > > > > rules so I'll just have to wait for stuff to land in Linus's tree :)
> > >
> > > I care less if other trees break as long as linux-next doesn't.
> > >
> > > > Rob isn't the one taking the patch. :D
> > > >
> > > > I'll apply it in a few days, unless Rob shouts real-loud!
> > >
> > > I've said it before, MFD and their child bindings need to be applied
> > > in 1 tree. If you can't make that happen, then don't apply binding
> > > patches.
> >
> > I'm not aware of MFD patches applied anywhere else.
> >
> > AFAIK, they all come through me.
> 
> Obviously not, or we wouldn't be having this discussion. The key part
> is 'AND their child bindings'.

I see.  That makes more sense.

> The child bindings can't go in via each
> subsystem because they are dependencies of the main MFD binding
> schema.

There is now more of a build-time dependency issue over the
documentation than there is the C-code.

That sounds so wrong to me.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-05-21 15:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  6:28 [PATCH robh dt/next] dt-bindings: mfd: add Broadcom CRU Rafał Miłecki
2021-04-20 20:00 ` Rob Herring
2021-05-19  8:20 ` [PATCH V2 " Rafał Miłecki
2021-05-19 15:29   ` Rob Herring
2021-05-19 18:32   ` Rob Herring
2021-05-19 18:40   ` [PATCH V3 " Rafał Miłecki
2021-05-20 18:22     ` Rob Herring
2021-05-21  7:12       ` Lee Jones
2021-05-21  7:20         ` Rafał Miłecki
2021-05-21  7:31           ` Lee Jones
2021-05-21 12:54             ` Rob Herring
2021-05-21 13:51               ` Lee Jones
2021-05-21 14:46                 ` Rob Herring
2021-05-21 15:06                   ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521150603.GJ2549456@dell \
    --to=lee.jones@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=npcomplete13@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).