From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B410C47078 for ; Fri, 21 May 2021 16:13:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4B40613DB for ; Fri, 21 May 2021 16:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4B40613DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6dEYvOH0P4p6xtH6jlOsYC/sJr4v+aO1SDkIiR/6Ja0=; b=kU/3cheMv8VP0oYnB0L/YzY/BK jWIbWeq6uR9WDS8USlt+RPzxLKA+OjhNKZ/6nkMi1JKcqqFhKCpVH5k5/Y5T3Ev3s7UVjCxo/zxuf 9L40PlG37ni1A8xjV8hddF269c7oP63ibETEWCclEAE1eSS9A9Dh593+NEAg96XbSmCQriKHB14LT 3sgdWED4iUervnSAUJmduVw2izJkcZLwCGsM5Lwhh3SzbeiC+ZWraBH1aK0jy2JgnuomK4mbXwGAL j+plxjJBmtf5Y3Ta5zOur7gz/0Xclz6TKKbM7yTN163hudNsURVqXCLHWY24yOtjXUql3h/eUC20K XIU2Tn/w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk7kH-000CGf-1e; Fri, 21 May 2021 16:11:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk7kB-000CG7-Jt for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 16:11:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ycqm3j0wX7C/S/ptvTlgoHJH/8ZDovU44aQpexyvdnU=; b=vwuiOUHTwJZe9pDfJsw1o74UJ7 8BA2GqX/m1c5oE2LjKL2Wm1E350iRnrtdc9FdU4ahqVLR0bTY0wmITegYOJi2eKBnSOV+wxXiohwk 03e+h/ME2XDDqiGXLDYTABFiHw2mxjWavF0aztgkXkbG1p8rO1QC00prhR6pB8jEasfXCnkMOwi++ zmtnvwlr178hgCu2onXnvsqsX/kOLyvz14mba18eMIiMron07HWB9yiJJpVkuADNf8V9AF98Ur6Vf QZI5pg31dFyW/rftTW+py6nCczmiyLybTmGJtIeWuipT5uJq2zru0ap5s6yIEiXfRY8cXFa6COlBc Lb7Qvs/w==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk7k9-00HGZf-6P for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 16:11:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BC12613DB; Fri, 21 May 2021 16:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621613480; bh=FNm3jXDRWoCbHZUTEZ8FokhLVtkukv3XsTG0pBzmCNU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pzjPEFKSOYGIVYk5X+06MjnSj+zbF9uPA3+xtNQf31RQJJqJ8JVI5nwbY4d+SYK9u nv/8OayJ21Sztmy0ci0rAku1MnBOHXrgzRHFn1v0yhUjLNSL5AU679ECBfG8VaqwlG l4/zpYHHvBW+CpXy/02qwPlf9EGtdftKNAaAEzxkPU8vQDpFW/m/i57FU3aXo2v2I5 79ErOLvQQD7beWhlcZkMGbINB7Lx7W7B2NhG/iUXGJzZz6tOD0K/ZK+28PXppHqhls fNONnG/6uDG61qsBMapKZjVYjmrKh1jwavLZZ4Iim8rRPda8fyx8vVyyRLArwAmtuW aP7sf32GFf+cA== Date: Fri, 21 May 2021 17:11:17 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 1/2] arm64: Introduce stack trace reliability checks in the unwinder Message-ID: <20210521161117.GB5825@sirena.org.uk> References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-2-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20210516040018.128105-2-madvenka@linux.microsoft.com> X-Cookie: Do not write below this line. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_091121_276466_49ACAB73 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0305900534601538057==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0305900534601538057== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rJwd6BRFiFCcLxzm" Content-Disposition: inline --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, May 15, 2021 at 11:00:17PM -0500, madvenka@linux.microsoft.com wrote: > Other reliability checks will be added in the future. ... > + frame->reliable = true; > + All these checks are good checks but as you say there's more stuff that we need to add (like your patch 2 here) so I'm slightly nervous about actually setting the reliable flag here without even a comment. Equally well there's no actual use of this until arch_stack_walk_reliable() gets implemented so it's not like it's causing any problems and it gives us the structure to start building up the rest of the checks. The other thing I guess is the question of if we want to bother flagging frames as unrelaible when we return an error; I don't see an issue with it and it may turn out to make it easier to do something in the future so I'm fine with that. --rJwd6BRFiFCcLxzm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCn26QACgkQJNaLcl1U h9BRjwf+NUkllMR4DUBzihQYZz8gFCBdrphJycb1capE54XA922TiNiSHdNs6Un2 og9xrHSmjkris4pNB4/EoZ8drNtDgp3x8Rwgg7RbRhA0xujYmOoWGJuhdEuUEjID jlkGNpt3oRJgBtEl3evUCSmXW0GK5a3emGmYA1yzUtuCFNIU4IfwO6r0d9R4Vc0U koUUak44PssXvqETo+iCX8BFh1dCVB8hTrPQJRpTjxHUcljYUxRK5/7aT1pj2L/R viAnHaZVX5h7RHy4oc/kKUG5jEY4WWdZembkRUhVjbYy+tNc5SLGNi9Gd3G8BxJw YGsb0HGPBSkXuoM3WVDdcHpNRe3/Hw== =FYp0 -----END PGP SIGNATURE----- --rJwd6BRFiFCcLxzm-- --===============0305900534601538057== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0305900534601538057==--