From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EA7C4707A for ; Fri, 21 May 2021 17:38:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A3AF61168 for ; Fri, 21 May 2021 17:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A3AF61168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IoaNIjnF7rd3rIcu9BQHEL9Zr5y+gMA5yjtpzeP1m+E=; b=WnJuDM8xbqGAd817wCVlwoI3Hw zby8BqnoWpYe873goRfKanwZ7eY7rbxxTKgHK/BfEmq9Dto/1HjIUPzI208UN2U0H4ZXsVjhy5d8t 5+5XgOxgs9NjdyQew1iz1Viut50ps3stbugX3yPuCRi4NZsJwoW9oBm3/ikUN0vY7EcPLB02bv2sK RZe/bY5ZL6lZpJdBfCtNY7ra6tosjUNX55zY4Vn5PBYFH5+vw/Q3CgirmtGvZKpk8Hkp4EDqKd4yD 9xDkZL3Yg3eorcDQG1kRP7r1KycAO7I2zby5JYqpIuG0kcFdFi7m+FqdxNq9nuvwTmOSv2V0fhIZh 33x5YMVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk94X-000XXP-Mo; Fri, 21 May 2021 17:36:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk94R-000XWZ-H6 for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 17:36:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xsZwyz8bU4yD245jhx9rPS0/zoGZWsugEiI8VeaXwz4=; b=f8xkgqFAB768V92z7wukPgh65f v8LAQNSSz/MVlBWXqvE5zM65HrGWy80s3iKBERnOoK01TDwTY+iGls9YsBpB7/c5VjmFQFufmnUcY GSTwwU1XsSwtxpGnEPJ+SZaoBoqRgVYY8bCEZawnzzJVjsrlXbSMOt5yKkY/t3PucMcR43HbL3N2v HBfhwyFfIE/2mtx5eZC40br9nYvpmFbHv7aJe60loPooSyY+rp7uMCsW08ygIB/LMZiyYyMSyfP0W nBJr4IDwb5JvTVXboFGXhg2n6BVvxcoK6Vbp9HZ9oMmY3pVqrnlM0/j8B0VWXDfRc4k6iihaJUNLO 75l4rYXg==; Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk94O-00HJml-Ee for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 17:36:22 +0000 Received: by mail-oo1-xc33.google.com with SMTP id o14-20020a4a384e0000b029020ec48a2358so2662432oof.13 for ; Fri, 21 May 2021 10:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=xsZwyz8bU4yD245jhx9rPS0/zoGZWsugEiI8VeaXwz4=; b=CTE2dQFpKlqhV9xA3GSGL8nDvpghVK9LimwK1q3I8P0dnbBZqSYYbFz55efe5eyVDt Qit5eNZ2mo8/DdfUIQtWsHmKZWItaKl9jpUZUxi5un1GFMYhTc7fb9BRsYpHaF8a1A7F gdnOzm3Vo8MRhsJtXus9p2hh6CGz1j/jQWGHew+EzO1DuP9nVxvKY2CQh99vvyU/uOwM yQlHV3e74CVYPd+P2IJrQbwbH8bynY9hHkGTlrHQ4ghvd9aZpKvOXlOvq8YGwb/LG7gM 1EB5cyNm7AsaN15riAgXWNW/RJ4KC9uZHXb0KFLpfCw7Xm/mOA0LPg8vck01Yv4JoowH pNNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=xsZwyz8bU4yD245jhx9rPS0/zoGZWsugEiI8VeaXwz4=; b=EySJq5S/dlIyH7mW/mq1q6HbM7sCowyqRyeZOQtll4I+RSjUXBQSrwUXU5e+WYirk9 dZdh2yx6gAClM4ELTUz0bk9s5OWWf5+Yhwq4dglnfZR0APcosrM7txoTvIKdQA7YMzQL qoSpbdgdUgHLz6y0moF02GXLaCqTiglCQNzFA8hCNrk7VlYukUYYT8PZkHoGHANAfMFS uPv54FOscUwktCiuuZdSK6jHpL6veHqPLljgS/pJNbjKoSsKATmX8mDvdC4N7b2EnNtM UqmhyRav/uEZJK89Myw75Ab0OO446lW4t+vFsKYXExFLll1TNjCMMkEyqWxCF7lxVied gacA== X-Gm-Message-State: AOAM533WWB/tTFP/utNNvN5ugYsiMda3Divc/8gIAEUePPUHsUtknmgL WLR7NZVSH7BpvHfvScS+kg== X-Google-Smtp-Source: ABdhPJzbCHFdLAdHPLmr/dH91nFshv8QRe7ey6knMySKTHguizVh3ISRUyFZezmXrFL/yp5yhV0qcQ== X-Received: by 2002:a4a:c88f:: with SMTP id t15mr9071550ooq.84.1621618579446; Fri, 21 May 2021 10:36:19 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id f2sm1373733otp.77.2021.05.21.10.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 10:36:18 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:9c8f:21cb:3961:b550]) by serve.minyard.net (Postfix) with ESMTPSA id 95ABE180105; Fri, 21 May 2021 17:36:17 +0000 (UTC) Date: Fri, 21 May 2021 12:36:16 -0500 From: Corey Minyard To: Andrew Jeffery Cc: openipmi-developer@lists.sourceforge.net, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, tmaimon77@gmail.com, linux-aspeed@lists.ozlabs.org, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, tali.perry1@gmail.com, robh+dt@kernel.org, chiawei_wang@aspeedtech.com, linux-arm-kernel@lists.infradead.org, benjaminfair@google.com, arnd@arndb.de, zweiss@equinix.com Subject: Re: [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Message-ID: <20210521173616.GK2921206@minyard.net> References: <20210510054213.1610760-1-andrew@aj.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510054213.1610760-1-andrew@aj.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_103620_536085_B94EE5C1 X-CRM114-Status: GOOD ( 27.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 03:11:57PM +0930, Andrew Jeffery wrote: > Hello, > > This is the 3rd spin of the series refactoring the keyboard-controller-style > device drivers in the IPMI subsystem. This is a nice set of cleanups outside of just allowing raw access. I'll let you handle Zev's comments and a few of mine. I almost hate to ask this, but would there be value in allowing the BT driver to use this abstract interface? Or maybe it would be just too hard to get a common abstraction, more work than it's worth. It's surprising that more people don't want BT as it's vastly superior to KCS. Just a thought for now. I guess there's SMIC, but hopefully nobody wants that. -corey > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > Cover letter: > https://lore.kernel.org/linux-arm-kernel/20210319061952.145040-1-andrew@aj.id.au/ > > Patches: > https://lore.kernel.org/linux-arm-kernel/20210319062752.145730-1-andrew@aj.id.au/ > > Several significant changes in v3: > > 1. The series is rebased onto v5.13-rc1 > > 2. v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, > so they're no-longer required in the series. > > 3. After some discussion with Arnd[1] and investigating the serio subsystem, > I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor > (patch 11/16 in this series). The adaptor allows us to take advantage of the > existing chardevs provided by serio. > > [1] https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917@www.fastmail.com/ > > Finally, I've also addressed Zev Weiss' review comments where I thought it was > required. These comments covered a lot of minor issues across (almost) all the > patches, so it's best to review from a clean slate rather than attempt to review > the differences between spins. > > Previously: > > Changes in v2 include: > > * A rebase onto v5.12-rc2 > * Incorporation of off-list feedback on SerIRQ configuration from > Chiawei > * Further validation on hardware for ASPEED KCS devices 2, 3 and 4 > * Lifting the existing single-open constraint of the IPMI chardev > * Fixes addressing Rob's feedback on the conversion of the ASPEED KCS > binding to dt-schema > * Fixes addressing Rob's feedback on the new aspeed,lpc-interrupts > property definition for the ASPEED KCS binding > > Please test and review! > > Andrew > > Andrew Jeffery (16): > ipmi: kcs_bmc_aspeed: Use of match data to extract KCS properties > ipmi: kcs_bmc: Make status update atomic > ipmi: kcs_bmc: Rename {read,write}_{status,data}() functions > ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi > ipmi: kcs_bmc: Turn the driver data-structures inside-out > ipmi: kcs_bmc: Split headers into device and client > ipmi: kcs_bmc: Strip private client data from struct kcs_bmc > ipmi: kcs_bmc: Decouple the IPMI chardev from the core > ipmi: kcs_bmc: Allow clients to control KCS IRQ state > ipmi: kcs_bmc: Don't enforce single-open policy in the kernel > ipmi: kcs_bmc: Add serio adaptor > dt-bindings: ipmi: Convert ASPEED KCS binding to schema > dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices > ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration > ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet > ipmi: kcs_bmc_aspeed: Optionally apply status address > > .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 106 +++ > .../bindings/ipmi/aspeed-kcs-bmc.txt | 33 - > drivers/char/ipmi/Kconfig | 27 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/kcs_bmc.c | 526 ++++----------- > drivers/char/ipmi/kcs_bmc.h | 92 +-- > drivers/char/ipmi/kcs_bmc_aspeed.c | 635 +++++++++++++----- > drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 568 ++++++++++++++++ > drivers/char/ipmi/kcs_bmc_client.h | 48 ++ > drivers/char/ipmi/kcs_bmc_device.h | 22 + > drivers/char/ipmi/kcs_bmc_npcm7xx.c | 94 ++- > drivers/char/ipmi/kcs_bmc_serio.c | 151 +++++ > 12 files changed, 1582 insertions(+), 722 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml > delete mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt > create mode 100644 drivers/char/ipmi/kcs_bmc_cdev_ipmi.c > create mode 100644 drivers/char/ipmi/kcs_bmc_client.h > create mode 100644 drivers/char/ipmi/kcs_bmc_device.h > create mode 100644 drivers/char/ipmi/kcs_bmc_serio.c > > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel