From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA977C4707E for ; Fri, 21 May 2021 20:18:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8CAF61164 for ; Fri, 21 May 2021 20:18:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8CAF61164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=runtux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WWBLZZ7CCaXAvhzEegPsLCJ+icTo3MnXxhMthljz6sI=; b=A2NviLh8jYtXIXZYkrc9Zppatx 0wsA/9jHxY50EgHJEvu88rg7oL3Zyybzp6/3IOfuJf3ntG9+rgCTXMkEZhCNCr5v7iEciypHg48zw 5hLJHcxHz1q4s47+jHnF/kzW9i+Tri7z/IoR67qMNTUW9Ni+2f3B/Xs7vb2y9Y8cJPgKrtz8l3fD7 WdjtkV3pgTb6X96xzgdtEW78NrgOEbqHH60icSsue0A11AWdXF5dWm1gdgvSB3lR/N63Vp3zc+k6K vyPLCQ4yUE6ZNn33w2jwpKrd5sXRA7/mwmYtNdt+mUZWjISNLM59Zle29BBNt4mkc5jnIEWizmLi9 elWtlq2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkBZt-00108i-Kz; Fri, 21 May 2021 20:17:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkBZn-00108E-VH for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 20:16:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YOf85zY0al/ByydROmpHWySRarnSlzDktjhZrpBEUCU=; b=hmee9vRzw1cpJfYVKdUqWrx2JE SSmGtlk+3w/cTPxnb0wjGfc5Eh3KqfUBRoKMn4KbR24pjkKF+/bgN5tVKFy0Ii34m61YOHkVJtwWy dHqvax4oaoYopaBqFHsV3KZVrmkg/T5vgXNSpWotxG1NufXffEaeqkokCy8FMpt6f/CbzDntUqAgf A3gkO17zUo9LrGJWwXlhhzJo8QBJzy3LNL9WuIvoj2L6hwtJgKT1QBGPfe3RypBYw1ERXY23TJnaI z0UQn3H5SlXQ6bQqEXLwZdrxmxm15DHlF59TUywMWjYxQhrQPk6/wH+A09puhhuBMzm/3vk+WSzsm uagO0/pQ==; Received: from tux.runtux.com ([176.9.82.136]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkBZk-00HP13-TB for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 20:16:54 +0000 Received: from localhost (localhost [127.0.0.1]) by tux.runtux.com (Postfix) with ESMTP id A67A36F00A; Fri, 21 May 2021 22:16:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at tux.runtux.com Received: from tux.runtux.com ([127.0.0.1]) by localhost (tux2.runtux.com [127.0.0.1]) (amavisd-new, port 10026) with LMTP id iCAZBfAfgrdo; Fri, 21 May 2021 22:16:46 +0200 (CEST) Received: from bee.priv.zoo (62-99-217-90.static.upcbusiness.at [62.99.217.90]) (Authenticated sender: postmaster@runtux.com) by tux.runtux.com (Postfix) with ESMTPSA id C17A26EF63; Fri, 21 May 2021 22:16:45 +0200 (CEST) Received: by bee.priv.zoo (Postfix, from userid 1002) id 09F0246E; Fri, 21 May 2021 22:16:44 +0200 (CEST) Date: Fri, 21 May 2021 22:16:44 +0200 From: Ralf Schlatterbeck To: Andre Przywara Cc: Mark Brown , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Message-ID: <20210521201644.ksjgsjvdud2wblbe@runtux.com> References: <20210520100656.rgkdexdvrddt3upy@runtux.com> <20210521173011.1c602682@slackpad.fritz.box> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521173011.1c602682@slackpad.fritz.box> X-ray: beware User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_131653_118629_F842FA39 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 05:30:11PM +0100, Andre Przywara wrote: > On Thu, 20 May 2021 12:06:56 +0200 > Ralf Schlatterbeck wrote: > So if I get your last email correctly, your intention was to make this > Mirko's patch, which you just send? Yes. > In this case the authorship should stay with him (git commit --amend > --author "..."), and you add your S-o-b (his first, your's next). > If you use git format-patch & git send-email, it will take care of > formatting this correctly (inserting a "From" line into the body). I was using format-patch but editing the result. Would a 'Date' line in the body also be OK? The patch is really from 2019... I have it correctly in my git but was unaware that additional header lines in the body are ok. > One formatting thing below: > > sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg); > > + /* Finally enable the bus - doing so before might raise SCK to HIGH */ > > + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, > > + sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG) > > + | SUN6I_GBL_CTL_BUS_ENABLE); > > The "|" on the new line looks a bit odd. What about you utilise "reg" > here, as the other access do, to make this more readable? > reg = sun6i_spi_read(...); > reg |= ... > sun6i_spi_write(..., reg); I've fixed this and will resubmit. Thanks, Ralf _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel