archive mirror
 help / color / mirror / Atom feed
* [PATCH] bus: ti-sysc: Fix flakey idling of uarts and stop using swsup_sidle_act
@ 2021-05-22  5:07 Tony Lindgren
  0 siblings, 0 replies; only message in thread
From: Tony Lindgren @ 2021-05-22  5:07 UTC (permalink / raw)
  To: linux-omap
  Cc: Nishanth Menon, Carl Philipp Klemm, Grygorii Strashko,
	Sicelo A . Mhlongo, Dave Gerlach, Greg Kroah-Hartman,
	Ivan Jelincic, linux-kernel, Sebastian Reichel, Faiz Abbas,
	Pavel Machek, Keerthy, Merlijn Wajer, linux-arm-kernel

Looks like the swsup_sidle_act quirk handling is unreliable for serial
ports. The serial ports just eventually stop idling until woken up and
re-idled again. As the serial port not idling blocks any deeper SoC idle
states, it's adds an annoying random flakeyness for power management.

Let's just switch to swsup_sidle quirk instead like we already do for
omap3 uarts. This means we manually idle the port instead of trying to
use the hardware autoidle features when not in use.

For more details on why the serial ports have been using swsup_idle_act,
see commit 66dde54e978a ("ARM: OMAP2+: hwmod-data: UART IP needs software
control to manage sidle modes"). It seems that the swsup_idle_act quirk
handling is not enough though, and for example the TI Android kernel
changed to using swsup_sidle with commit 77c34c84e1e0 ("OMAP4: HWMOD:
UART1: disable smart-idle.").

Fixes: b4a9a7a38917 ("bus: ti-sysc: Handle swsup idle mode quirks")
Cc: Carl Philipp Klemm <>
Cc: Ivan Jelincic <>
Cc: Merlijn Wajer <>
Cc: Pavel Machek <>
Cc: Sebastian Reichel <>
Cc: Sicelo A. Mhlongo <>
Signed-off-by: Tony Lindgren <>
 drivers/bus/ti-sysc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -1466,9 +1466,9 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
 	/* Uarts on omap4 and later */
 	SYSC_QUIRK("uart", 0, 0x50, 0x54, 0x58, 0x50411e03, 0xffff00ff,
 	SYSC_QUIRK("uart", 0, 0x50, 0x54, 0x58, 0x47422e03, 0xffffffff,
 	/* Quirks that need to be set based on the module address */
 	SYSC_QUIRK("mcpdm", 0x40132000, 0, 0x10, -ENODEV, 0x50000800, 0xffffffff,

linux-arm-kernel mailing list

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-22  5:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22  5:07 [PATCH] bus: ti-sysc: Fix flakey idling of uarts and stop using swsup_sidle_act Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).