From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD59CC04FF3 for ; Mon, 24 May 2021 19:00:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87A1761413 for ; Mon, 24 May 2021 19:00:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87A1761413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yCTin17H4RUGkvGjCriEXfPk2S/ZrCZ7VEGQUQULU5E=; b=mTdX6+9Tm3sruD NqvOzUITbx+wC7In7KmsOAlodVETT/ouyJHcYjWKOOhvP6mUkKsDjqKZ2uNwV8iAnW4jQlAq0o+yt mj/LnoouMiHej6GuGVsnemjDQkkTzzIFLzQnVVMOExJ8KYC9aedmbtft8Mt2ZvcQExo/zhgLI9/Lp a1KuzCc27vwiIQPwvxeDC8rbT5JNqVE8EYYYzXtj7qeojXrn5pWAjnVhyVC3FpMrNkfmWCbQiVEif DDqzuJbNGDieNFKV2CasrzdbIJKfqQIuF11SxNOv6b3AsCKmtXtyR2MX++x6/mN7BUd/2nyfWfe9F 2BEsWkKfnI1J6PUuufJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llFlm-001ZOC-NY; Mon, 24 May 2021 18:57:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llAxS-000y6K-W6 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 13:49:28 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A67761370; Mon, 24 May 2021 13:49:23 +0000 (UTC) Date: Mon, 24 May 2021 14:49:21 +0100 From: Catalin Marinas To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 02/21] arm64: Allow mismatched 32-bit EL0 support Message-ID: <20210524134920.GB14645@arm.com> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-3-will@kernel.org> <20210521102523.GB6675@arm.com> <20210524120550.GA14913@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210524120550.GA14913@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_064927_077270_E753DD8D X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 24, 2021 at 01:05:50PM +0100, Will Deacon wrote: > On Fri, May 21, 2021 at 11:25:23AM +0100, Catalin Marinas wrote: > > On Tue, May 18, 2021 at 10:47:06AM +0100, Will Deacon wrote: > > > +static bool has_32bit_el0(const struct arm64_cpu_capabilities *entry, int scope) > > > +{ > > > + if (!has_cpuid_feature(entry, scope)) > > > + return allow_mismatched_32bit_el0; > > > + > > > + if (scope == SCOPE_SYSTEM) > > > + pr_info("detected: 32-bit EL0 Support\n"); > > > + > > > + return true; > > > +} > > > > We may have discussed this before: AFAICT this will print 32-bit EL0 > > detected even if there's no 32-bit EL0 on any CPU. Should we instead > > print 32-bit EL0 detected on CPU X when allow_mismatched_32bit_el0 is > > passed? It would also give us an indication of the system configuration > > when people start reporting bugs. > > The function above only runs if we've detected 32-bit support via > aa64pfr0_el1, so I think we're ok. We also have a print when we detect the > mismatch (see enable_mismatched_32bit_el0()). It makes sense, you removed the .desc from the arm64_features entry as well. Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel