archive mirror
 help / color / mirror / Atom feed
From: Ralf Schlatterbeck <>
To: Andre Przywara <>
Cc: Mark Brown <>,
	Maxime Ripard <>, Chen-Yu Tsai <>,
	Jernej Skrabec <>,,,,,
	Mirko Vogt <mirko-dev|>
Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug
Date: Mon, 24 May 2021 18:24:33 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, May 24, 2021 at 01:33:01PM +0100, Andre Przywara wrote:
> - Single patch set series don't bother to have a "1/1" after the
>   "PATCH".
> - You are expected to increase the version number when you send a new
>   version, to show that *this* is better than the previous post and
>   this version should be merged. Otherwise the maintainer might pick
>   the wrong version. "git format-patch -v2" and "git send-email" will
>   automatically take care of this.

OK I'll keep that in mind.

> Please keep in mind that text after the dashes doesn't make it in it
> repo, so this information would be lost there. Also, in general links in
> commit messages are somewhat frowned upon, since they tend to 404
> sooner or later. So ideally you can put a condensed version of your
> findings into the commit message? Don't worry if it grows long, it is
> not uncommon to have a 2 page commit message for a one-liner patch.

This was intentional, the commit message is only the upper part.
The Links were meant to give a lot of details why the patch fixes
something. I think the commit message already explains the condensed
findings. I've put this additional explanation text after the '---' to
not need an additional Patch 0/1 email ;-)

Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:
Reichergasse 131, A-3411 Weidling       email:

linux-arm-kernel mailing list

  reply	other threads:[~2021-05-24 22:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 10:06 [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Ralf Schlatterbeck
2021-05-21 16:30 ` Andre Przywara
2021-05-21 20:16   ` Ralf Schlatterbeck
2021-05-21 20:19   ` Ralf Schlatterbeck
2021-05-24 12:33     ` Andre Przywara
2021-05-24 16:24       ` Ralf Schlatterbeck [this message]
2021-05-25 14:35     ` Mark Brown
2021-05-27 11:39       ` Ralf Schlatterbeck
2021-06-05 14:06         ` Mirko Vogt
2021-06-14 14:47           ` Ralf Schlatterbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --cc=mirko-dev| \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).