From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8D8C2B9F7 for ; Tue, 25 May 2021 02:17:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EB0A6141D for ; Tue, 25 May 2021 02:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EB0A6141D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pb7R1i1f4hm0tztXzSU2vuu1ZxJUvJsU18zSWRnU6M8=; b=e+PnYyNMtsXZj2 oifdPMBZzyTDmEOJwIkQ6WFGCjdgiSxh7QCzkaLE2ZY7YUwbDWyT6iBEQKfRFdj+aP64QmScMO3/W OFqMj3GuzYT5ELGXeUGq168nBLa+bHG73Osf2kNDnHLY5tV/5wf8sbTPJ+VWwiQtrjDw5Sz9jpUze 3GgqGtDKKWhEJ28TF1xt9U0RbmTAvIpDxtk4FTBfyWteanyXXQw/vJ481qWcTKGfULVOufzxAOy65 zd6fNYxzjzVyaSotffEE2tDb/91Sfii1LWe1GE3kE/5Be6eRCA1LAwr1SYptoKn2COvCK0YX76i7y 8L1tdHpKAHeyRQSbMoPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llMas-002sPX-AV; Tue, 25 May 2021 02:14:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llHw7-001upP-Md for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 21:16:33 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 12A3161411; Mon, 24 May 2021 21:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621890991; bh=mRnyDFN9b6UZo7ExIpoCS1Ag3C643iFCcpo734zRGCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gv410r2BRUDANSAPKB8ulTCmMz3xgrZs+zFG3qwTKFnj5tX7oM7oEsWRtUuFQjTHw KEZdiVT442rky6YopzQxT6EgGAYl/Qx1mNi2G/A+Khc9b5zxmoqGAEvYGpEy+MEeir lXZP3q3+POQ8YfUU0G5Ph8ht6iGaN5ckwqJ3x3XYMU/aaafJxK5cbMo7yop6llVmLN kP59n1m3Hl0csB/3KZyMrMM7qSgW8GdPFUk3WzXE2OgbuyVnCvbvBzxZ35EUZ/vBif 4O5GxIlWN0fseWNHD4GuUQwQW2zN0RM3F8Zr6VnZZaKk1OusutexIhpklZJOQeYeT6 UFlQVspooUKMg== Date: Mon, 24 May 2021 22:16:25 +0100 From: Will Deacon To: Qais Yousef Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 11/21] sched: Split the guts of sched_setaffinity() into a helper function Message-ID: <20210524211624.GG15545@willie-the-truck> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-12-will@kernel.org> <20210521164101.lwq5wr4mbb32co6l@e107158-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521164101.lwq5wr4mbb32co6l@e107158-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_141631_811484_69123A5E X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 05:41:01PM +0100, Qais Yousef wrote: > On 05/18/21 10:47, Will Deacon wrote: > > In preparation for replaying user affinity requests using a saved mask, > > split sched_setaffinity() up so that the initial task lookup and > > security checks are only performed when the request is coming directly > > from userspace. > > > > Signed-off-by: Will Deacon > > --- > > kernel/sched/core.c | 110 +++++++++++++++++++++++--------------------- > > 1 file changed, 58 insertions(+), 52 deletions(-) > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 9512623d5a60..808bbe669a6d 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -6788,9 +6788,61 @@ SYSCALL_DEFINE4(sched_getattr, pid_t, pid, struct sched_attr __user *, uattr, > > return retval; > > } > > > > -long sched_setaffinity(pid_t pid, const struct cpumask *in_mask) > > +static int > > +__sched_setaffinity(struct task_struct *p, const struct cpumask *mask) > > { > > + int retval; > > cpumask_var_t cpus_allowed, new_mask; > > + > > + if (!alloc_cpumask_var(&cpus_allowed, GFP_KERNEL)) > > + return -ENOMEM; > > + > > + if (!alloc_cpumask_var(&new_mask, GFP_KERNEL)) > > + return -ENOMEM; > > Shouldn't we free cpus_allowed first? Oops, yes. Now fixed. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel