From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A7FC2B9F8 for ; Tue, 25 May 2021 17:03:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 592CB61417 for ; Tue, 25 May 2021 17:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 592CB61417 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oSSbPIDOexRFPGoTqiDRYanUvrlMgKoqb74TthOen4E=; b=R+Vpte1u4EwTXJ JX55ENJ0g/LaDvjvhp3wX6UfryWdH5WcWZysOWvE9QmQgKZvYUUefY+OPsIGEM2DazXRHO6ekK9oT RhJo11ZK57dpYAOZdzxqWAi2hJ2hK21LWYpMAh9C/FTB+3FpQr+CyDMy2F04aHaRm62qp4HjLT5L+ 0+4rw/bzuvhvN1AdUNrJXCWWi+qbq0gqNiIatEvWNitwlfz3lcDLvLw2sJlSSIuat/YOJa5C8YfFw 6wiNHIE+Vw0YZKBd/JmFI/DNUaJXaJzcm6KL3QEQB6hWXbudnUrpA/0dE5is5UiTPP67EILQBa/Sq mvVn2LbzUOw7gGDdJCrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llaPc-006fEX-79; Tue, 25 May 2021 17:00:17 +0000 Received: from mail-eopbgr10079.outbound.protection.outlook.com ([40.107.1.79] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llaBV-006Xvd-Vz for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 16:45:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcT818MfJMylMqkEiWKE+aA0d+tvCUxFRoGYKmlgQgo=; b=5qIjEHEEyZ/95atG6sKmuY+ubPJ0RtqsfAwIuLgUe1/2AZ3n+LSqei/n6Z+kC+fuqYE4Q09mXlMe5pZ2qgaCAkz6SyoJgo4hmQJ5szagL+5M6rVedqXRp7opKPBd2j02/IwZ27IjtaaDF4oFHffX/RWbEefxRrn1uY4uHAh1mzk= Received: from DB6PR07CA0086.eurprd07.prod.outlook.com (2603:10a6:6:2b::24) by AM8PR08MB6593.eurprd08.prod.outlook.com (2603:10a6:20b:364::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Tue, 25 May 2021 16:45:34 +0000 Received: from DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::22) by DB6PR07CA0086.outlook.office365.com (2603:10a6:6:2b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Tue, 25 May 2021 16:45:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT017.mail.protection.outlook.com (10.152.20.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 25 May 2021 16:45:34 +0000 Received: ("Tessian outbound 6c8a2be3c2e7:v92"); Tue, 25 May 2021 16:45:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 106cdca5bd108eae X-CR-MTA-TID: 64aa7808 Received: from f358ddcfbf97.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F0CA1452-5A2B-40AC-ABC7-A6194911B30F.1; Tue, 25 May 2021 16:45:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f358ddcfbf97.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 25 May 2021 16:45:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kIHhawaB4/n0HeaSbr1UAZ41FQyDrjkCsHglIHQIjFkx7SGGWCOAgks+Jw8YodS8LeMSKPVI98vyZlsHZta0YuIxjEdYMK8HodvxDvs+YuBtiwSjkHYlOxGE+MN4BZ84txG+LYyx1alcWwh3GsPFAknOjlaX2s1L3mmjvbOQhQFK8bQlurkmH2iedlLmZSFYRUkwIMHObVObWETSeew5PlNOepy2WVFQtWdbwv7d46bQaB2MSiwT1Ek7SkDn7MPxgipoyNobiWOOpn5KX93AYPAnbW4mxSSrPjcDVnhGh/EBkru6CFoBDEdmz7OIngMmL0EptXI+Ef9hhoKeHKR59g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcT818MfJMylMqkEiWKE+aA0d+tvCUxFRoGYKmlgQgo=; b=nfwEx4eO43eJZx2ML3nCKSaVrohOTwbQpOJgfoUFBb4X8a0QBb+FK2TAHy+IKsxGd8zQl/xOqV05IjxGQ38fqrj/o9K6KtqrWiZoHngZOZ/tx94VjIQpyAyEys16F3fT9IpAKIxZbfF7YbfyV1xGdP7FfgDoJGR7FpS1QJ/9JCdnW04SgwvNJbOTzi2UNK0W4ZOwkn/z8Wm4WOGaaKH8W2zo0nAMoCD7F+9jPSamAil+hDJU0Mgp2O+jLZKHoiJTYt9d72DMix/BxnSCd3GItWARkhbRMXSI2ghH42fYhgo9H67itumZMsNFAGWyaKpgmDr2XW506zxeOOQNvJ88Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcT818MfJMylMqkEiWKE+aA0d+tvCUxFRoGYKmlgQgo=; b=5qIjEHEEyZ/95atG6sKmuY+ubPJ0RtqsfAwIuLgUe1/2AZ3n+LSqei/n6Z+kC+fuqYE4Q09mXlMe5pZ2qgaCAkz6SyoJgo4hmQJ5szagL+5M6rVedqXRp7opKPBd2j02/IwZ27IjtaaDF4oFHffX/RWbEefxRrn1uY4uHAh1mzk= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) by DB7PR08MB3818.eurprd08.prod.outlook.com (2603:10a6:10:7e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Tue, 25 May 2021 16:45:27 +0000 Received: from DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039]) by DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039%5]) with mapi id 15.20.4150.027; Tue, 25 May 2021 16:45:27 +0000 Date: Tue, 25 May 2021 17:45:24 +0100 From: Joey Gouly To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, will@kernel.org, nd@arm.com Subject: Re: [PATCH v2 02/19] arm64: entry: unmask IRQ+FIQ after EL0 handling Message-ID: <20210525164524.GP35816@e124191.cambridge.arm.com> References: <20210519123902.2452-1-mark.rutland@arm.com> <20210519123902.2452-3-mark.rutland@arm.com> Content-Disposition: inline In-Reply-To: <20210519123902.2452-3-mark.rutland@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.49] X-ClientProxiedBy: LNXP265CA0061.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::25) To DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124191.cambridge.arm.com (217.140.106.49) by LNXP265CA0061.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 25 May 2021 16:45:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc2ab023-211c-4448-aca9-08d91f9c8477 X-MS-TrafficTypeDiagnostic: DB7PR08MB3818:|AM8PR08MB6593: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2150;OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tB6ylinejUdWEK1s1XVWdJ+utZ/+swsPjlzxqGjMJxZ79OTIrMYonfsX6MgKmD6P1rC7CKe6GdjwGAcDSJ06i/sWXHMnvwLjM0wsGx/L5AYoIvIJmUZAKjvTSc3td/zv63YF76gBcSiDlXheRwAB5buMKdS8sEi1ywfq9g04evFYuKsmyBBGFAtqacWfpnBhMqeViPs+s+TlolehOS2hziz08EmVKAoHoxJxCSgJymb6dcSIKtAdHIHtYHtrQC8ApJncuSUNICsYiuaGcROM+UvQxrk6xALzspc7ptt39LyT8yzwLCQA3/rqGaKi837qSKqKNUUJQbIGvftpa4NVEhqHl8ERTrM7wnIIVyyZeY91qCNvaAhIRpSctwj467v+zC/33fxhDCpB38ORdJ0xYzbqmjlPfggqnL9FSmwW9qB7ow9e+p0HdBiD0EhgmY5H7wF+MX1xUzOOU85mGtXf+d7gmLCbrnnWnTfwGR0wHe4JxfK/Tgg5FceEqEX/sAEDTLGKNxf0duInFivf7Bq6JaT9W48lkBrImhb81/e+hehgndnzOo+QEmjYH5UcfLnih9wp11+bvkdQeulDUAVYj60xcNNNliYgQWjAYBfDk9seJtwNduXKO01Po8q5MPqy+lgh0k/yjYmelIxdfqGUlw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR08MB5433.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(83380400001)(8936002)(4326008)(186003)(26005)(6862004)(1076003)(66946007)(38350700002)(33656002)(7696005)(38100700002)(16526019)(498600001)(956004)(52116002)(86362001)(2906002)(5660300002)(55016002)(6636002)(66476007)(44832011)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Zrq+/s/NZLTZHBSqhB6xZL2IKIyJuMd1rBbFcmZn7+z+CrD1XCm+OoJPQUXw?= =?us-ascii?Q?stbLWmwHE43TJqNtmrlpztCAEKwmRnRS2cuMRWWe/6V+rH5vu2KboGn7Skwm?= =?us-ascii?Q?WIFI6IQdfS/MF7uQMcIjdTzLOA5jhQyPXmnBKO6t59IyP9b/wFWCZIVqbtgG?= =?us-ascii?Q?eKE2AOoQWVhlpV2fkFAWqlM7TdVSTWoyTsflO3p6RvX3JfMwlOJ5YvgBlSp4?= =?us-ascii?Q?dzinhJvmUK34vRbMV7rU62HPWMLSOCKfztr737TY+T2fybfwpn4S3EF6MYIG?= =?us-ascii?Q?PJ7j2yC2UQiZftUj2/AiHonZ1XcB8f+rl1+qcb06m4XTZeM89vy2MqQm4nH6?= =?us-ascii?Q?yTjAkqR+op7MNFE6un09t7B4hpEgCsQ4G5S+wsvKEhBr3/fwbxlaxTthpM8p?= =?us-ascii?Q?mwAJ9zp8vNKuZVK07BS9glrRnX1dfaD/BRF9Rj5932M1gIH8lZel4qsWCfuu?= =?us-ascii?Q?YThpuGtbNfnvJ0zn5bQ7VeOnEqbqQ6KKAYzp+cxKuQcGGGTetns8mlQ/rHuu?= =?us-ascii?Q?p/OxxjCA7xY+kjzMxZFOs465oJPwq6RUKh8DOfmQUNGZEtQYi0mrdkEKnhsN?= =?us-ascii?Q?LTAud5XIICrcB+yb368w5dEL3o7WhmMkRS5dPPFhn9uM8hNPKZseVsixn7xO?= =?us-ascii?Q?F5Wo3zUp32clVrje3J1/qMzpP6W4Y6/2sEgJhNmKPH/VZf3CRnV9EVREQcIg?= =?us-ascii?Q?KpklXAjAo4DpyKHOR6XqMOD9x9EVO6CNIqNcg6HP8qjuuw3SeGm2zBwcis95?= =?us-ascii?Q?7xC1nO3mks0AymdRG2rGAw9STgoJKEubLX8DLDcSxAJ9zApJPBSmLJhCf3dl?= =?us-ascii?Q?MgyGUijyHIC8AsQec2AnPF6NbPaDYN8g7vfohV7v7XPDlAkLGobWyItWiu8h?= =?us-ascii?Q?A8e3UIDJyP2xx8KLGuhkXLu6AeTdBYnSHtbJfUg+fass/Ej3a6dLal/ueCEz?= =?us-ascii?Q?8ZjHnMLUjhRCBJdRshgz0PdnlYmdrNMw3EijxLZ9tYeVCG17+kYKKktvzUP9?= =?us-ascii?Q?rBflIPEaPas0KB+LKVz0oYXVMruxRz8oNIyd2bJdFOYr2sKQ1tI4rX2QILuW?= =?us-ascii?Q?YIg9vN9J2HqBwNBP/NmWIXclGlcidzXT8+2JCZKw2NOxBJuc5cnZCGnG5HtZ?= =?us-ascii?Q?rxMvnwvqovJpTILlo3jUOxsF9gx1Zx4z/3spHYTFkwcwmPSORvFhn7pB+mJ0?= =?us-ascii?Q?yYdmqn++uxMDVycKT0s8DNHZeXjlrmJ1FNZ5MZDaJWAJeWyJfRXWqkNt/cA4?= =?us-ascii?Q?qhxZoDwFoATAUUvE/R4Wnw+pXDqBMSAz/vCclHHcAHp0730I8j/VlwSliKu/?= =?us-ascii?Q?ZDDpMMRet4DP3j4Ni1cKnZCj?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3818 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b695e00d-eb6b-4339-f5cd-08d91f9c7faf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w7WnmiMAu5od37GxRpioEyW+jfmEFL+L7Ewq3DUPwh32z7F7tC3nJgadMlJEk0G2csAVXZIoczTbwYM8w6c/fr9RhsXzmPDeO5qy+anREbLNFXg0hkgg5a/C/nOkmcDDrFyMv9cBawW2KoFwGq2Gfo5DbPaZskEnDD4ucUqJ3OpFyJtyQ/SRehGiqlSgKTP80C3GmhoqcOJWQfG7I0LuZQGyscaVSralaZfmGSGrz+cw4eQ3ZYnsVhVHx/ia0rqzyEyB9E8tzUlrwdXtDAfuJAAgwT8VfLkFKLRFeLSZS9fjT0d4D8lKBR2qz5/W03fZ/C+g5RXDOLjtQK6enUvJ0n/CIgbhY+ziGYAh1o78PDQigUvzYBxclkIabrTywdiv1oXZZritLxAhJ1+zI5rVjYoB2pJOfxtGTbQLwEVFH8GflcZOWtD9S0SURvqp9DFyPdZSZJBvNo7I2OvPEVOa2zDfWhjMcimOUvxu+Oa8+ovZ7yX3NgmZmOhwP3fJW1AtBlKskBHLFtduKaO1Zr68US1gudtejeq4ATwcIEKefiwOMSI5OqIp0JHp/KsElcJ/8kOohE4PWPcRC/6+/hbt2M8Uu/31oCQ0RJVfowSLTnt65x4fQI4eM99BpzKywkEh9TrKq4fXlNJYzm1NzmwTzYjvvageAosk26Ez2jgKq+8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(376002)(136003)(346002)(46966006)(36840700001)(2906002)(186003)(55016002)(70206006)(7696005)(26005)(956004)(33656002)(1076003)(336012)(82310400003)(356005)(316002)(16526019)(6636002)(86362001)(8936002)(8676002)(47076005)(4326008)(5660300002)(6862004)(81166007)(36860700001)(82740400003)(70586007)(83380400001)(44832011)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 16:45:34.7350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc2ab023-211c-4448-aca9-08d91f9c8477 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6593 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_094538_140829_DB4D6353 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 01:38:45PM +0100, Mark Rutland wrote: > For non-fatal exceptions taken from EL0, we expect that at some point > during exception handling it is possible to return to a regular process > context with all exceptions unmasked (e.g. as we do in > do_notify_resume()), and we generally aim to unmask exceptions wherever > possible. > > While handling SError and debug exceptions from EL0, we need to leave > some exceptions masked during handling. Handling SError requires us to > mask SError (which also requires masking IRQ+FIQ), and handing debug > exceptions requires us to mask debug (which also requires masking > SError+IRQ+FIQ). > > Once do_serror() or do_debug_exception() has returned, we no longer need > to mask exceptions, and can unmask them all, which is what we did prior > to commit: > > 9034f6251572a474 ("arm64: Do not enable IRQs for ct_user_exit") > > ... where we had to mask IRQs as for context_tracking_user_exit() > expected IRQs to be masked. > > Since then, we realised that our context tracking wasn't entirely > correct, and reworked the entry code to fix this. As of commit: > > 23529049c6842382 ("arm64: entry: fix non-NMI user<->kernel transitions") > > ... we consistently call context_tracking_user_exit() later as part of > ret_to_user. Prior to this we can transiently unmask exceptions (e.g. as > part of do_notify_resume), and we always mask all exceptions prior to > calling context_tracking_user_exit(). > > Thus, there's no longer a reason to leave IRQs or FIQs masked at the end > of el0_dbg() or el0_error(), so let's bring these into line with other > EL0 exceptions handlers and unmask all exceptions after the handler is > finished. > We discussed some changes to the commit message offline, otherwise: Reviewed-by: Joey Gouly _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel