From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFF6C2B9F8 for ; Tue, 25 May 2021 18:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6215C6140E for ; Tue, 25 May 2021 18:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6215C6140E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=S3ZP2k/c1uajqPG3dmB25tTWwS9/1bbQKv917cqm5Sc=; b=3FU6AwvkBEdVXI OrwDLZxyY1KY0Rx4Bjzl8soJsguYVVavjtyY1UMmva9kTmdA13YjB+IGVIACcKfnkghRMdv2KI7yA mB09KrZHETwbnxL2uIXw202Zqb40BJZ9zA2u5RSiE8T1HNNTT52y2DxQhAG2cSeThpie9KV/uSt03 mPDxiNYHixqpM4ME16UxNPNNnENv0wN0hSbXMTmwzQplCNIMAVJ5xM1+OgmgZTDv2IhCIA57l1dOR KUeSVBWeSTwOdlTpzoKVRKGMiJ9bQPe1uylj+kdguwtVA3QHOkkKqMvB186VlrYhAKJiA3ERi6IvX AuZMc+vZiJUrzLoSapvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llbrs-007I6F-Lw; Tue, 25 May 2021 18:33:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llbrn-007I4w-PX for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 18:33:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DDC4168F; Tue, 25 May 2021 11:33:11 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0A5DD3F719; Tue, 25 May 2021 11:33:09 -0700 (PDT) From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, mark.rutland@arm.com, maz@kernel.org, will@kernel.org Subject: [PATCH v3 00/20] arm64: entry: migrate more code to C Date: Tue, 25 May 2021 19:32:42 +0100 Message-Id: <20210525183302.56293-1-mark.rutland@arm.com> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_113323_997939_C2BC86AB X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series (based on v5.13-rc2) migrates most of the remaining exception triage assembly to C. All the exception vectors are given C handlers, so that we can defer all decision making to C code, and the assembly code can be made simpler and more uniform. At the same time, I've tried to consolidate all the entry sequencing (e.g. reading exception registers and calling accounting code) in entry-common.c so that this is easier to maintain. I was recently informed that `noinstr` wasn't protecting entry sequences from KCOV instrumentation, so I've refactored things so that we can avoid this by preventing KCOV instrumentation for the entirety of entry-common.c. I've done likewise for the low-level idle sequences which have the same problems with instrumentation when RCU isn't watching, etc. I've stopped short of converting the ret_to_user / work_pending loop. Converting this cleanly will probably need something like the wrappers generated by SYSCALL_DEFINE() to handle the common entry/exit logic, and this is easier to build once all the handlers have been converted to C. Similar is true for portions of kernel_entry and kernel_exit that could be converted to C. It should also be possible to generate the vectors and their associated assembly handlers in one go by placing these in separate sections and using .pushsection and .popsection. I've held off doing this for now as this probably requires some changes to the linker script, and regardless it should be easier to make that change atop this series. So far this has seen some light boot testing, and a day's worth of fuzzing under Syzkaller, which I intend to leave to soak for a while. I've pushed the series to my arm64/entry/rework branch on kernel.org: https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/entry/rework git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/entry/rework I've tagged this version as arm64-entry-rework-20210525. Since v1 [1] * Rebase to v5.13-rc2 * Fold NMI entry/exit sequencing into entry-common.c * Make NMI entry/exit helpers private to entry-comomn.c * Prevent KCOV instrumentation of entry-common.c * Prevent KCOV instrumentation of idle code Since v2 [2]: * Correct commit message description in patch 2 * Use `el0t` prefix for EL0 handlers for consistency with `el1h` and `el1t` * Remove `user_exit_irqoff` macro * Remove leftover bad_mode() prototype * Add patch to replace el1_inv() with a direct call to __panic_unhandled() * Accumulate Reviewed-by tags * Typo fixes [1] https://lore.kernel.org/r/20210510155621.52811-1-mark.rutland@arm.com [2] https://lore.kernel.org/r/20210519123902.2452-1-mark.rutland@arm.com Thanks, Mark. Mark Rutland (20): arm64: remove redundant local_daif_mask() in bad_mode() arm64: entry: unmask IRQ+FIQ after EL0 handling arm64: entry: convert SError handlers to C arm64: entry: move arm64_preempt_schedule_irq to entry-common.c arm64: entry: move preempt logic to C arm64: entry: add a call_on_irq_stack helper arm64: entry: convert IRQ+FIQ handlers to C arm64: entry: organise entry handlers consistently arm64: entry: organise entry vectors consistently arm64: entry: consolidate EL1 exception returns arm64: entry: move bad_mode() to entry-common.c arm64: entry: improve bad_mode() arm64: entry: template the entry asm functions arm64: entry: handle all vectors with C arm64: entry: fold el1_inv() into el1h_64_sync_handler() arm64: entry: split bad stack entry arm64: entry: split SDEI entry arm64: entry: make NMI entry/exit functions static arm64: entry: don't instrument entry code with KCOV arm64: idle: don't instrument idle code with KCOV arch/arm64/include/asm/exception.h | 34 +++- arch/arm64/include/asm/processor.h | 2 - arch/arm64/include/asm/sdei.h | 3 + arch/arm64/kernel/Makefile | 5 +- arch/arm64/kernel/entry-common.c | 250 ++++++++++++++++++++++++-- arch/arm64/kernel/entry.S | 360 ++++++++++--------------------------- arch/arm64/kernel/idle.c | 69 +++++++ arch/arm64/kernel/process.c | 74 -------- arch/arm64/kernel/sdei.c | 48 +---- arch/arm64/kernel/traps.c | 40 +---- arch/arm64/mm/fault.c | 7 - 11 files changed, 432 insertions(+), 460 deletions(-) create mode 100644 arch/arm64/kernel/idle.c -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel