Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on rockchip/for-next robh/for-next v5.13-rc3 next-20210525] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-IOMMU-driver-for-rk356x/20210525-201749 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: powerpc-randconfig-s031-20210525 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/bd6c989c628be7c8ac1f8aeb9f301bd3a6e0a078 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Benjamin-Gaignard/Add-IOMMU-driver-for-rk356x/20210525-201749 git checkout bd6c989c628be7c8ac1f8aeb9f301bd3a6e0a078 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/iommu/rockchip-iommu.c:1384:19: error: 'rk_dma_addr_dte' undeclared here (not in a function); did you mean 'rk_dma_addr_dte_v2'? 1384 | .dma_addr_dte = &rk_dma_addr_dte, | ^~~~~~~~~~~~~~~ | rk_dma_addr_dte_v2 vim +1384 drivers/iommu/rockchip-iommu.c 0f181d3cf7d984b Jeffy Chen 2018-03-23 1378 ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1379 static struct rk_iommu_ops iommu_data_ops_v1 = { ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1380 .pt_address = &rk_dte_pt_address, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1381 .mk_dtentries = &rk_mk_dte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1382 .mk_ptentries = &rk_mk_pte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1383 .dte_addr_phys = &rk_dte_addr_phys, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 @1384 .dma_addr_dte = &rk_dma_addr_dte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1385 .dma_bit_mask = DMA_BIT_MASK(32), ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1386 }; ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1387 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org