From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F259C47089 for ; Thu, 27 May 2021 13:42:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 485A860FEE for ; Thu, 27 May 2021 13:42:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 485A860FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kiGAWBPmfBNg3T6G+9xXaSVYkyBX5A3+pzAunODFaOc=; b=hMhoqrbAN+OjwX QfATjGYQIiWuaPWViMwXJu7IvkwnX4yGAjgPMYYCh3dxabQhvgaexszoehppJJzLeFD5Jh+SbYgxj L2JpDXUY1dKFcoP9GjVBP1j91Ow5qHUvV1/it0i0OLuERfAPcUkA/8y2GTl3gxF0+bZWt9FNkjjoD kI3T2yoMrBpD1RXVCO1MgTeAvoCE2g0znfj/Ud/qBtdZWpzy9Egs3Uo2n9QJkr9RCkCvur4stjDvN 1P/4NgR2tQdEbdf5adbq3L0/qPtef7g9MZ6YwLC1L+mv7sqs3EQkS0CsOgW8Qk2fHgvtlXe6Hg6EE X0Df3WkPXQEBP9HxhLOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmGF3-006MAE-DD; Thu, 27 May 2021 13:40:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmG3f-006Gbb-Jr for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 13:28:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5679B14FF; Thu, 27 May 2021 06:28:16 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 739EB3F73D; Thu, 27 May 2021 06:28:15 -0700 (PDT) Date: Thu, 27 May 2021 14:28:12 +0100 From: Cristian Marussi To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot Subject: Re: [PATCH v2 1/4] firmware: arm_scmi: fix deps arm-smccc-discovery deps in Kconfig Message-ID: <20210527132812.GU28060@e120937-lin> References: <20210521134055.24271-1-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521134055.24271-1-etienne.carriere@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_062819_744210_97812206 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Etienne, On Fri, May 21, 2021 at 03:40:51PM +0200, Etienne Carriere wrote: > ARM_SCMI_PROTOCOL depends one either MAILBOX or HAVE_ARM_SMCCC_DISCOVERY, > not MAILBOX only. This change fixes this in Kconfig file and driver > private header file. > > Signed-off-by: Etienne Carriere > --- > No change since v1 > --- > drivers/firmware/Kconfig | 2 +- > drivers/firmware/arm_scmi/common.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index db0ea2d2d75a..a9c613c32282 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -9,7 +9,7 @@ menu "Firmware Drivers" > config ARM_SCMI_PROTOCOL > tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > depends on ARM || ARM64 || COMPILE_TEST > - depends on MAILBOX > + depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY > help > ARM System Control and Management Interface (SCMI) protocol is a > set of operating system-independent software interfaces that are > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 228bf4a71d23..8685619d38f9 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -331,7 +331,7 @@ struct scmi_desc { > }; > > extern const struct scmi_desc scmi_mailbox_desc; > -#ifdef CONFIG_HAVE_ARM_SMCCC > +#ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY > extern const struct scmi_desc scmi_smc_desc; > #endif > This seems reasonable to me as of now, but I have to say in the original virtio-scmi series from Peter this issue is tackled a bit differently: (https://lore.kernel.org/linux-arm-kernel/20210511002040.802226-1-peter.hilber@opensynergy.com/) adding something like ARM_SCMI_HAVE_SHMEM and ARM_SCMI_HAVE_MSG and then make mailbox and smc transport select HAVE_SHMEM while virtio selects HAVE_MSG and keeping ARM_SCMI_PROTOCOL depends on either of those. I found such approach a bit better in term of abstraction indeed, but given that such virtio-scmi series I'm reworking is still probably a bit further down the line in terms of posting, I think that your solution is good enough for now if Sudeep agrees with it, and we can switch to the above mentioned HAVE_* abstractions once virtio-scmi is pushed forward. Reviewed-by: Cristian Marussi Thanks, Cristian > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel