From: Will Deacon <will@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Tue, 1 Jun 2021 13:46:31 +0100 [thread overview]
Message-ID: <20210601124630.GB28025@willie-the-truck> (raw)
In-Reply-To: <1620302579-5949-1-git-send-email-tiantao6@hisilicon.com>
On Thu, May 06, 2021 at 08:02:59PM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/perf/arm_pmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index d4f7f1f..6bcfc52 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
> }
>
> irq_flags = IRQF_PERCPU |
> - IRQF_NOBALANCING |
> + IRQF_NOBALANCING | IRQF_NO_AUTOEN |
> IRQF_NO_THREAD;
>
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> -
> err = request_nmi(irq, handler, irq_flags, "arm-pmu",
> per_cpu_ptr(&cpu_armpmu, cpu));
Please can you update drivers/perf/qcom_l2_pmu.c at the same time?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-01 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 12:02 [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-01 12:46 ` Will Deacon [this message]
2021-06-01 13:00 ` tiantao (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601124630.GB28025@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).