From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828B7C47080 for ; Tue, 1 Jun 2021 13:54:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B4661376 for ; Tue, 1 Jun 2021 13:54:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47B4661376 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ab2ZG3X6HteH1XsWihZq3U82eI9jcYf/9GFVwZmkFaM=; b=zLAi0N1MgNt2RP 9EST/4zWxQVa5NJwyMPXap0pOgAbTgzBfWf57JtOR3j2T+5RkYKqKin/OZ+j6c7e0Nu4RVQbAIWyg jdDg9p4J9W8rD1OS31XBl9/8bpIa9euOBQ0JsECcVl0c0SDbDUMz1aOFKedNgQICyythRP4EVYXlq e5umgCsG6VnrSgbFhkCNKvugIG7HHBRvwjKhrNlDwKWforDJ4vZ+Do3Df4edgY8Lx3G8WhHO5x6Ym lRTZRTkIXukErnr9T1wnOAnJa4SEulbhtTnsWPEwdP85gydazeNfZbBs7adlGJq0q/oVeiY+efXp+ p7Zzzxkju5fLla0Qa8xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo4pq-00GtTR-8k; Tue, 01 Jun 2021 13:53:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo4pm-00GtSN-Ge for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 13:53:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D57A86D; Tue, 1 Jun 2021 06:53:28 -0700 (PDT) Received: from bogus (unknown [10.57.72.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82FFD3F719; Tue, 1 Jun 2021 06:53:27 -0700 (PDT) Date: Tue, 1 Jun 2021 14:53:22 +0100 From: Sudeep Holla To: Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-kernel , Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet Subject: Re: [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem to json schema Message-ID: <20210601135322.z2ct3arrk67r3uvq@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-2-sudeep.holla@arm.com> <20210527202554.GA1351447@robh.at.kernel.org> <20210531081548.jxovuqattu2fg73o@bogus> <20210531082002.spu73u7n35n53lqp@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_065330_670074_28C15EA4 X-CRM114-Status: GOOD ( 30.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 08:37:57AM -0500, Rob Herring wrote: > On Mon, May 31, 2021 at 3:20 AM Sudeep Holla wrote: > > > > On Mon, May 31, 2021 at 09:15:48AM +0100, Sudeep Holla wrote: > > > On Thu, May 27, 2021 at 03:25:54PM -0500, Rob Herring wrote: > > > > On Wed, May 26, 2021 at 07:28:00PM +0100, Sudeep Holla wrote: > > > > > Move the SRAM and shared memory binding for SCPI into the existing > > > > > Generic on-chip SRAM. We just need to update the compatible list and > > > > > there-by remove the whole old text format binding for the same. > > > > > > > > > > Cc: Rob Herring > > > > > Cc: Kevin Hilman > > > > > Cc: Neil Armstrong > > > > > Cc: Jerome Brunet > > > > > Signed-off-by: Sudeep Holla > > > > > --- > > > > > .../devicetree/bindings/arm/arm,scpi.txt | 15 --------------- > > > > > Documentation/devicetree/bindings/sram/sram.yaml | 1 + > > > > > 2 files changed, 1 insertion(+), 15 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt b/Documentation/devicetree/bindings/arm/arm,scpi.txt > > > > > index bcd6c3ec471e..bcb8b3d61e68 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt > > > > > +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt > > > > > @@ -56,21 +56,6 @@ Sub-nodes > > > > > node. It can be non linear and hence provide the mapping of identifiers > > > > > into the clock-output-names array. > > > > > > > > > > -SRAM and Shared Memory for SCPI > > > > > -------------------------------- > > > > > - > > > > > -A small area of SRAM is reserved for SCPI communication between application > > > > > -processors and SCP. > > > > > - > > > > > -The properties should follow the generic mmio-sram description found in [3] > > > > > - > > > > > -Each sub-node represents the reserved area for SCPI. > > > > > - > > > > > -Required sub-node properties: > > > > > -- reg : The base offset and size of the reserved area with the SRAM > > > > > -- compatible : should be "arm,scp-shmem" for Non-secure SRAM based > > > > > > > > > + - arm,scpi-shmem > > > > > > > > Which is correct? There's not a single other occurrance in the kernel > > > > tree of either. > > > > > > > > > > Right I was thinking removing it but wasn't sure if any downstream DTS > > > have used this as it has been in the binding for a while now. > > > > > > > Sent it too early before I completed, we don't have explicit check for > > these compatible in the code. We just use phandles directly. > > But which one is correct? "arm,scp-shmem" or "arm,scpi-shmem" > Ah sorry I misread earlier. Indeed it should be "arm,scp-shmem", I messed up while converting. > I can fix up when applying. > I am posting v2 once I fix the scmi regulators. I also have couple of other fixes you have suggested. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel