From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88553C47080 for ; Tue, 1 Jun 2021 18:29:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52DA4613AE for ; Tue, 1 Jun 2021 18:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52DA4613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pU7KedpHOw6s5xHmqKN+EyQzIAMHl93M0fJ5hBLh2sQ=; b=fr+Jf/Zm4V5bgP 84AYw2762YuAumWK1mm1xrumxq+Nfn2QfY9//Rs2sqsgNv646Qa1U1lpaPOgQvESWJaCp0pZ51OR4 QwigzXQ/Br7irayvYi1rGA262/lgh1lsPaGSS7c95T21LtsGwhMYzPUi02aT6K4DCXWD3evF3jBb4 YF04n4EITNAS3rqHBYie3QVGYuQKATwIYvT9u6fKlsNVDYY1mfJu06+8FVURZm0RZjewnX29QXTZv AiDkVwUgmiTWDvn7o/p0/PpNPy7OgYNFE6HTJ+OrJwu7SDhSoiealNB9eU2pMYqxuqvWqd3p0o/T2 GJ3SpR4/nlX1yGPyqaSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo96z-000Njd-P1; Tue, 01 Jun 2021 18:27:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo96H-000NNb-9a for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 18:26:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F237660FDC; Tue, 1 Jun 2021 18:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622572008; bh=CNHMGt+lUfofmK63cGx7mvHlRK92fm9p/lC+BpODjto=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DZ5kpGZtvgtSYaTgqAAT3Cnr82ykh33gpe4qc6RNSmu1H+vPvZf1Ri8SWjwoJIleh hGyllpdAOhGKVe9mT+2YS+3i7QYl/yz9oTohuu2L1X8G04ZgJvrFABxX6cDaZ7Y00o I1OBakuIe5HOphCjHXkVMuH7H+Q44611pm9UsOn3QteWVYYUoNhZTCPjH+2eIcTLYf VhovsIRdIRTMHMX2op7Z6DTfAyjCpDpUeEeB3xeCT6VosM7Dk2Ahsu3Oz6UrYCvNav QjdjoUvWGZiKvlyhYQp68tsEU+z3Z57uyHCa0XvgChqVV60yuLIEO6e7z9cY6207U8 A5aiUJ47X06TA== Date: Tue, 1 Jun 2021 19:26:44 +0100 From: Will Deacon To: Mark Rutland Cc: Robin Murphy , catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/8] arm64: Import latest version of Cortex Strings' memcmp Message-ID: <20210601182644.GA29456@willie-the-truck> References: <2889de2d41054f3f508fb3addad784a3606ef383.1622128527.git.robin.murphy@arm.com> <20210527165214.GA39198@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210527165214.GA39198@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_112649_413320_531059C6 X-CRM114-Status: GOOD ( 33.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 27, 2021 at 05:52:14PM +0100, Mark Rutland wrote: > On Thu, May 27, 2021 at 04:34:41PM +0100, Robin Murphy wrote: > > From: Sam Tebbs > > > > Import the latest version of the former Cortex Strings - now > > Arm Optimized Routines - memcmp function based on the upstream > > code of string/aarch64/memcmp.S at commit e823e3a from > > https://github.com/ARM-software/optimized-routines > > > > Note that for simplicity Arm have chosen to contribute this code > > to Linux under GPLv2 rather than the original MIT license. > > Thanks for adding this! It would be nice if we could make this slightly > more explicit, e.g. > > | Arm hold the copyright on this code, and have chosen to contribute it > | to linux under GPL v2 rather than the original MIT license. > > ... but I don't think that requires a respin. > > > > > Signed-off-by: Sam Tebbs > > [ rm: update attribution and commit message ] > > Signed-off-by: Robin Murphy > > --- > > arch/arm64/lib/memcmp.S | 330 ++++++++++++++-------------------------- > > 1 file changed, 111 insertions(+), 219 deletions(-) > > > > diff --git a/arch/arm64/lib/memcmp.S b/arch/arm64/lib/memcmp.S > > index c0671e793ea9..498f0d9941d9 100644 > > --- a/arch/arm64/lib/memcmp.S > > +++ b/arch/arm64/lib/memcmp.S > > @@ -1,247 +1,139 @@ > > /* SPDX-License-Identifier: GPL-2.0-only */ > > /* > > - * Copyright (C) 2013 ARM Ltd. > > - * Copyright (C) 2013 Linaro. > > + * Copyright (c) 2013-2020, Arm Limited. > > 2021 too, presumably. ;) > > > * > > - * This code is based on glibc cortex strings work originally authored by Linaro > > - * be found @ > > - * > > - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/ > > - * files/head:/src/aarch64/ > > + * Adapted from the original at: > > + * https://github.com/ARM-software/optimized-routines/blob/master/string/aarch64/memcmp.S > > */ > > Could we please note the commit ID in the comment, too? e.g. we can > place that in the URL: > > https://github.com/ARM-software/optimized-routines/blob/e823e3abf5f89ecb/string/aarch64/memcmp.S > > I've checked that the below matches the code in the file referenced > above, and AFAICT, the only change I see in the body of the function is > dropping PTR_ARG() and SIZE_ARG(), which are not necessary as the kernel > itself is not built with ILP32. The local definition of L() also seems > fine to me. > > On the assumption that the code was correct to begin with, this looks > good to me. With the minor fixups above: > > Acked-by: Mark Rutland I've applied this as-is with your Ack, but I haven't yet put it into linux-next. Please can you (or Robin) send patches on top to address the above? Sorry for rushing a bit, but I'd like to get CKI chewing on this ASAP and didn't want to wait for a respin if it's just cosmetic stuff pending. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel