From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D98C47092 for ; Wed, 2 Jun 2021 10:19:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73C67613BF for ; Wed, 2 Jun 2021 10:19:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73C67613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3HzyxaoUnQRLzl1v8NAxmlUBo/7VqJryPF+nFt/MmVg=; b=ISO4kWM3N1qmZl qMdgfqu1xhVG4O5NSpVSyxq9TrXbpVPNNIaOGLLzEdvxRsKE9pIiTtu2c4abZXAYbirIJgtSnuLnp rG6PwtzEjAd0xsVJDYkDq1erDDOJfmFPRzps4J1NIwKswi42HQqpG3YLKgA39x7YK22+fEP7tD+i7 5erq8/wreg4mmuDSoZRcpFxL+FgkFpZD/DdcuKzXV8mL+HZ5s7I8YlKRMNOe+ikI2j3jTEkX62EJ3 Ijq6B9QndXUiKfrriPsM01fWfmRmyIPIee3jU7km1tAt+ncrhY0PPZHXfshVXmMza0X7oVhMBrP0r 4lbmIcvMKh9K2wG2xovQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNwW-003FCD-Nx; Wed, 02 Jun 2021 10:17:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNwN-003EXN-Vq for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 10:17:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fmGY2nI0Vp6TsNVIwXBzebajJgSbQrncqCC+od0RbVA=; b=Bme3nUMcHhzLBe47U302hAVD7 ncr3HnbXsgya5LaTfL5cUlqWe0l+aWayODB1FTdohKpCOvbRoQ9B5NnSQC1hUjNpypqjR1fN1PQQF EmLpbZonirz2e3YoyOSThY5E0lix2TkdHs3RvKZ0WGQcpvRJWo7jl7+Sd4pVhY9wMQGID428NDAfR tDLuzxegmwbAPhvf3aMw5EigGcS1DyMbXmGmpdGrXKm5On/nK+b3sKLInwrMzmYfvmfGD9qH1w87q T7nUNYMl8o6oRG4qxx6w4zkv0PQiQ1rzn5cCLH4uIl5EHEqyBrncopbDV0wF8U1cy2fU8CovyJrSN XzqrCiGYw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44608) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loNuF-0000xC-Gl; Wed, 02 Jun 2021 11:15:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loNuD-00011p-IK; Wed, 02 Jun 2021 11:15:21 +0100 Date: Wed, 2 Jun 2021 11:15:21 +0100 From: "Russell King (Oracle)" To: Mike Rapoport Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christian Borntraeger , David Hildenbrand , Heiko Carstens , Thomas Bogendoerfer , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org Subject: Re: [RFC/RFT PATCH 2/5] memblock: introduce generic memblock_setup_resources() Message-ID: <20210602101521.GD30436@shell.armlinux.org.uk> References: <20210531122959.23499-1-rppt@kernel.org> <20210531122959.23499-3-rppt@kernel.org> <20210601135415.GZ30436@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_031736_067540_D5FAD8B3 X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 02, 2021 at 11:33:10AM +0300, Mike Rapoport wrote: > On Tue, Jun 01, 2021 at 02:54:15PM +0100, Russell King (Oracle) wrote: > > On Mon, May 31, 2021 at 03:29:56PM +0300, Mike Rapoport wrote: > > > + code_resource.start = __pa_symbol(_text); > > > + code_resource.end = __pa_symbol(_etext)-1; > > > + rodata_resource.start = __pa_symbol(__start_rodata); > > > + rodata_resource.end = __pa_symbol(__end_rodata)-1; > > > + data_resource.start = __pa_symbol(_sdata); > > > + data_resource.end = __pa_symbol(_edata)-1; > > > + bss_resource.start = __pa_symbol(__bss_start); > > > + bss_resource.end = __pa_symbol(__bss_stop)-1; > > > > This falls short on 32-bit ARM. The old code was: > > > > - kernel_code.start = virt_to_phys(_text); > > - kernel_code.end = virt_to_phys(__init_begin - 1); > > - kernel_data.start = virt_to_phys(_sdata); > > - kernel_data.end = virt_to_phys(_end - 1); > > > > If I look at one of my kernels: > > > > c0008000 T _text > > c0b5b000 R __end_rodata > > ... exception and unwind tables live here ... > > c0c00000 T __init_begin > > c0e00000 D _sdata > > c0e68870 D _edata > > c0e68870 B __bss_start > > c0e995d4 B __bss_stop > > c0e995d4 B _end > > > > So the original covers _text..__init_begin-1 which includes the > > exception and unwind tables. Your version above omits these, which > > leaves them exposed. > > Right, this needs to be fixed. Is there any reason the exception and unwind > tables cannot be placed between _sdata and _edata? > > It seems to me that they were left outside for purely historical reasons. > Commit ee951c630c5c ("ARM: 7568/1: Sort exception table at compile time") > moved the exception tables out of .data section before _sdata existed. > Commit 14c4a533e099 ("ARM: 8583/1: mm: fix location of _etext") moved > _etext before the unwind tables and didn't bother to put them into data or > rodata areas. You can not assume that all sections will be between these symbols. This isn't specific to 32-bit ARM. If you look at x86's vmlinux.lds.in, you will see that BUG_TABLE and ORC_UNWIND_TABLE are after _edata, along with many other undiscarded sections before __bss_start. So it seems your assumptions in trying to clean this up are somewhat false. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel