From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D22EBC47083 for ; Wed, 2 Jun 2021 16:14:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 965CE6192E for ; Wed, 2 Jun 2021 16:14:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 965CE6192E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zWEaVYY+HcmqijpeL33cGJfeQ+nDmgLOD16cbBbTSz8=; b=iJaVssfNDvv1/j W+xLUmOefF1ZwC5Y9Y8Ja1mpuzYQ9E0mJIKOGMoXIDnlncxwfgG/p3vPMFQrimE0Gd/jgXLfAZvh0 7fQ23EYh9EC6eP5ot2/PrCm1fhYbLDPYyMlJO/7tVZ32M4z8ORtgexrSdCjm6Iw+hzfH9Zh8uDcWI GrquSJdxY0Xj7nnKowhdYfQTHut3iYz4s9gS51wZzKEpl2mpzfDA/yU25AlZl9jZ5J6cPnrLBZpVJ s3OjpRiCBLdtHwxhx/xnxll/7yWX1zoZUxmDlb9fzFBn/PXKsNkx/ZK/LB4flqJwWUSZd+0sJX8Z1 ti44/Q7xPbEYHgrzDXrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTU5-0054Il-QE; Wed, 02 Jun 2021 16:12:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTQS-0052tQ-L3 for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 16:09:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC5F012FC; Wed, 2 Jun 2021 09:08:59 -0700 (PDT) Received: from bogus (unknown [10.57.72.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E5D13F73D; Wed, 2 Jun 2021 09:08:57 -0700 (PDT) Date: Wed, 2 Jun 2021 17:08:53 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, Sudeep Holla , vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v2 1/5] firmware: arm_scmi: reset_rx_to_maxsz during async commands Message-ID: <20210602160853.mui3xdr7v4cmmwn2@bogus> References: <20210601102421.26581-1-cristian.marussi@arm.com> <20210601102421.26581-2-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210601102421.26581-2-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_090900_778438_29A6613F X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 11:24:17AM +0100, Cristian Marussi wrote: > During an async commands execution the rx buffer len is at first set to > max_msg_sz when the synchronous part of the command is first sent; once > the synchronous part completes the transport layer waits for the delayed > response which will be processed using the same xfer descriptor initially > allocated, but synchronous response received at the end of the xfer will > have shrunk the rx buffer len to the effective payload response length. > > Raise the rx buffer length again to max_msg_sz while waiting for the > delayed response, while adding an informational error message. > > Fixes: 58ecdf03dbb9 ("firmware: arm_scmi: Add support for asynchronous commands and delayed response") > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 66eb3f0e5daf..75141b90ae53 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -513,8 +513,16 @@ static int do_xfer_with_response(const struct scmi_protocol_handle *ph, > xfer->async_done = &async_response; > > ret = do_xfer(ph, xfer); > - if (!ret && !wait_for_completion_timeout(xfer->async_done, timeout)) > - ret = -ETIMEDOUT; > + if (!ret) { > + /* rx.len would have been shrunk in the sync do_xfer above */ > + reset_rx_to_maxsz(ph, xfer); Won't this race with delayed response notification ? I think so, let me know if not and how. Can't we have this before we fetch the response into xfer ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel