From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB1FC47083 for ; Wed, 2 Jun 2021 17:11:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E7AE61028 for ; Wed, 2 Jun 2021 17:11:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E7AE61028 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pie5iTqD+GZkT+nB0G9XIVx6xIPLtIPvmBh9GzUhOhg=; b=POo8WBrV7G2xqn QOkxi4C3qNFU2xSzOL/ioZfiQaVtg+vhskEpc6rE6+4ZQ07NnOmrS4PK8msU3Dgx+zQ3znXfFQCFO nm2x252SJVCSt0gvZ2vFg5zrKET19hdEAbBeW7Yw7fvPOmgs3/2F02EDSQNDvv8hIB5FqHI7VsE9C YSougvhxG6avY5Ot/50Msp4TGerBh+2xrfFA1kMEInXIm4Kousl3dT+gc3kmmznIwI4ahdnX80Lrt OXYFidWX4+PC1mVkJPG66O0oHUju66vm4K2UU1KikRnYfDbPh5l8Faq++An0tYWKD/7UQbhylj4ZZ zRmN1eOmvPiZt04t8B6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loUMH-005O2w-Gy; Wed, 02 Jun 2021 17:08:45 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loUCR-005JiW-31; Wed, 02 Jun 2021 16:58:36 +0000 Received: by mail-ot1-f47.google.com with SMTP id h19-20020a9d6f930000b02903c0c4560e99so3074051otq.1; Wed, 02 Jun 2021 09:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Zf5qRUfCpeGGvJMUCSGIUbY/+04iGlClb4uduIjNhR0=; b=Uuuo9ws0DYQywYahxMpRi8BRGVKDiO+E28cxp5qLzlSRL1+jmnHDLlwKK6gCPPvGKC 8t/i+KmBMXzJT8nbEOL1d9jfzzbm3Y7QcyCU0b6xG3PrnLeF4y8q3WK0iro6U9nhdiLN u5gtxilmA2m1U1eI/Zk+91XutCRIdM7bCS7kzC98Hl98i302I46mfCfyvsjr+TxwyW/L +tLw2qmoImyHYighcKwyHUb9Tiu4C5swHLnrGjS790JBnZkGChpbtQFMoJ+828V0V0Ht NzBILqrqWEn0MRxbuY8/o2mkpw5VkTzP+WOM5few8246DmqUwbTglFgZTl0Ivu4AXL5N 8igA== X-Gm-Message-State: AOAM530pXjImhWrO0MBf9ZtrEwNLujZJZYtiUaH7z2Kg9x/Uo3WUQ1tF 3DJgngkILbX8VOpHF24mxA== X-Google-Smtp-Source: ABdhPJx1wdxS3bAZXIYWDE40ru5uXYnHiXfbK4Phi9RGSYCkcilqMyYnar4EpNED8xQ5RgHOGXF/TQ== X-Received: by 2002:a9d:1d21:: with SMTP id m30mr27563140otm.145.1622653109495; Wed, 02 Jun 2021 09:58:29 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l128sm90445oif.16.2021.06.02.09.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 09:58:28 -0700 (PDT) Received: (nullmailer pid 3566137 invoked by uid 1000); Wed, 02 Jun 2021 16:58:27 -0000 Date: Wed, 2 Jun 2021 11:58:27 -0500 From: Rob Herring To: Hector Yuan Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com Subject: Re: [PATCH v12 2/2] dt-bindings: cpufreq: add bindings for MediaTek cpufreq HW Message-ID: <20210602165827.GA3558170@robh.at.kernel.org> References: <1622307153-3639-1-git-send-email-hector.yuan@mediatek.com> <1622307153-3639-3-git-send-email-hector.yuan@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1622307153-3639-3-git-send-email-hector.yuan@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_095835_184284_7239E36C X-CRM114-Status: GOOD ( 24.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 30, 2021 at 12:52:33AM +0800, Hector Yuan wrote: > From: "Hector.Yuan" > > Add devicetree bindings for MediaTek HW driver. > > Signed-off-by: Hector.Yuan > --- > .../bindings/cpufreq/cpufreq-mediatek-hw.yaml | 71 ++++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml > new file mode 100644 > index 0000000..1aa4d54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/cpufreq/cpufreq-mediatek-hw.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek's CPUFREQ Bindings > + > +maintainers: > + - Hector Yuan > + > +description: > + CPUFREQ HW is a hardware engine used by MediaTek > + SoCs to manage frequency in hardware. It is capable of controlling frequency > + for multiple clusters. > + > +properties: > + compatible: > + const: mediatek,cpufreq-hw > + > + reg: > + minItems: 1 > + maxItems: 2 > + description: | > + Addresses and sizes for the memory of the > + HW bases in each frequency domain. > + > + "#performance-domain-cells": > + description: > + Number of cells in a performance domain specifier. Typically 0 for nodes > + representing a single performance domain and 1 for nodes providing > + multiple performance domains (e.g. performance controllers), but can be > + any value as specified by device tree binding documentation of particular > + provider. > + enum: [ 0, 1 ] Can't you restrict this to be 1 for Mediatek h/w? Even if you sometimes have a single domain, it's probably more simple for the driver if this is fixed. > + > +required: > + - compatible > + - reg > + - "#performance-domain-cells" > + > +additionalProperties: true Should be false. > + > +examples: > + - | > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55"; > + enable-method = "psci"; > + performance-domains = <&performance 0>; > + reg = <0x000>; > + }; > + }; > + > + /* ... */ > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + performance: performance-controller@11bc00 { > + compatible = "mediatek,cpufreq-hw"; > + reg = <0 0x0011bc10 0 0x120>, <0 0x0011bd30 0 0x120>; > + > + #performance-domain-cells = <1>; > + }; > + }; > -- > 1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel