From: Herbert Xu <herbert@gondor.apana.org.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-crypto@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Corentin Labbe <clabbe@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/3 v4] crypto: ixp4xx: convert to platform driver
Date: Thu, 3 Jun 2021 20:30:32 +0800 [thread overview]
Message-ID: <20210603123032.GE6161@gondor.apana.org.au> (raw)
In-Reply-To: <20210525083048.1113870-1-linus.walleij@linaro.org>
On Tue, May 25, 2021 at 10:30:46AM +0200, Linus Walleij wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ixp4xx_crypto driver traditionally registers a bare platform
> device without attaching it to a driver, and detects the hardware
> at module init time by reading an SoC specific hardware register.
>
> Change this to the conventional method of registering the platform
> device from the platform code itself when the device is present,
> turning the module_init/module_exit functions into probe/release
> driver callbacks.
>
> This enables compile-testing as well as potentially having ixp4xx
> coexist with other ARMv5 platforms in the same kernel in the future.
>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Tested-by: Corentin Labbe <clabbe@baylibre.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v3->v4:
> - No changes, just resending with the other patches.
> ChangeLog v2->v3:
> - No changes, just resending with the other patches.
> ChangeLog v1->v2:
> - Rebase on Corentin's patches in the cryptodev tree
> - Drop the compile test Kconfig, it will not compile for
> anything not IXP4xx anyway because it needs the NPE and QMGR
> to be compiled in and those only exist on IXP4xx.
> ---
> arch/arm/mach-ixp4xx/common.c | 26 ++++++++++++++++++++++++
> drivers/crypto/ixp4xx_crypto.c | 37 ++++++++++++----------------------
> 2 files changed, 39 insertions(+), 24 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-03 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:30 [PATCH 1/3 v4] crypto: ixp4xx: convert to platform driver Linus Walleij
2021-06-03 12:30 ` Herbert Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-24 15:07 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603123032.GE6161@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=kaloz@openwrt.org \
--cc=khalasa@piap.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).