From: Yu Kuai <yukuai3@huawei.com>
To: <sean.wang@kernel.org>, <linus.walleij@linaro.org>,
<matthias.bgg@gmail.com>
Cc: <linux-mediatek@lists.infradead.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <yukuai3@huawei.com>,
<yi.zhang@huawei.com>
Subject: [PATCH] pinctrl: mediatek: fix build error without CONFIG_PINCTRL_MTK
Date: Thu, 3 Jun 2021 22:06:18 +0800 [thread overview]
Message-ID: <20210603140618.3044976-1-yukuai3@huawei.com> (raw)
If CONFIG_PINCTRL_MT8365 is set without CONFIG_PINCTRL_MTK,
following build errors will be triggered:
aarch64-linux-gnu-ld: drivers/pinctrl/mediatek/pinctrl-mt8365.o: in function `mtk_pinctrl_probe':
pinctrl-mt8365.c:(.text+0x20): undefined reference to `mtk_pctrl_init'
aarch64-linux-gnu-ld: drivers/pinctrl/mediatek/pinctrl-mt8365.o: in function `mt8365_spec_pull_set':
pinctrl-mt8365.c:(.text+0x64): undefined reference to `mtk_pctrl_spec_pull_set_samereg'
aarch64-linux-gnu-ld: drivers/pinctrl/mediatek/pinctrl-mt8365.o: in function `mt8365_ies_smt_set':
pinctrl-mt8365.c:(.text+0xbc): undefined reference to `mtk_pconf_spec_set_ies_smt_range'
aarch64-linux-gnu-ld: pinctrl-mt8365.c:(.text+0xf0): undefined reference to `mtk_pconf_spec_set_ies_smt_range'
aarch64-linux-gnu-ld: drivers/pinctrl/mediatek/pinctrl-mt8365.o:(.data+0xa0): undefined reference to `mtk_eint_pm_ops'
Fix it by adding the dependency that CONFIG_PINCTRL_MT8365 will be
relied on CONFIG_PINCTRL_MTK.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/pinctrl/mediatek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index b27c2070559a..3ec12651d4ef 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -157,6 +157,7 @@ config PINCTRL_MT8365
bool "Mediatek MT8365 pin control"
depends on OF
depends on ARM64 || COMPILE_TEST
+ depends on PINCTRL_MTK
default ARM64 && ARCH_MEDIATEK
config PINCTRL_MT8516
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-06-03 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 14:06 Yu Kuai [this message]
2021-06-07 8:08 ` [PATCH] pinctrl: mediatek: fix build error without CONFIG_PINCTRL_MTK Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603140618.3044976-1-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).