linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap'
@ 2021-06-03 14:58 kernel test robot
  2021-06-03 20:05 ` Stephen Boyd
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2021-06-03 14:58 UTC (permalink / raw)
  To: Peter Collingbourne
  Cc: kbuild-all, linux-clk, linux-arm-kernel, Stephen Boyd, Lee Jones,
	Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-versatile
head:   419b3ab6987f2a108cc4710030184365b17467ac
commit: 419b3ab6987f2a108cc4710030184365b17467ac [1/1] clk: versatile: remove dependency on ARCH_*
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?id=419b3ab6987f2a108cc4710030184365b17467ac
        git remote add clk https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
        git fetch --no-tags clk clk-versatile
        git checkout 419b3ab6987f2a108cc4710030184365b17467ac
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
   coherent.c:(.text+0x3bc): undefined reference to `memremap'
   s390-linux-ld: coherent.c:(.text+0x500): undefined reference to `memunmap'
   s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
   coherent.c:(.text+0xae6): undefined reference to `memunmap'
   s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
   irq-al-fic.c:(.init.text+0x98): undefined reference to `of_iomap'
   s390-linux-ld: irq-al-fic.c:(.init.text+0x596): undefined reference to `iounmap'
   s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
   clk-fixed-mmio.c:(.text+0x9a): undefined reference to `of_iomap'
   s390-linux-ld: clk-fixed-mmio.c:(.text+0xe6): undefined reference to `iounmap'
   s390-linux-ld: drivers/clk/versatile/clk-versatile.o: in function `cm_osc_setup':
>> clk-versatile.c:(.init.text+0xbc): undefined reference to `of_iomap'
   s390-linux-ld: drivers/clk/versatile/clk-sp810.o: in function `clk_sp810_of_setup':
>> clk-sp810.c:(.init.text+0x174): undefined reference to `of_iomap'
   s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
   timer-of.c:(.init.text+0xcc): undefined reference to `of_iomap'
   s390-linux-ld: timer-of.c:(.init.text+0x8ee): undefined reference to `iounmap'
   s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
   timer-of.c:(.init.text+0xb9a): undefined reference to `iounmap'
   s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
   timer-microchip-pit64b.c:(.init.text+0x150): undefined reference to `of_iomap'
   s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0xc78): undefined reference to `iounmap'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28432 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap'
  2021-06-03 14:58 [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap' kernel test robot
@ 2021-06-03 20:05 ` Stephen Boyd
  2021-06-04  7:24   ` Linus Walleij
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Stephen Boyd @ 2021-06-03 20:05 UTC (permalink / raw)
  To: Peter Collingbourne, kernel test robot
  Cc: kbuild-all, linux-clk, linux-arm-kernel, Lee Jones, Linus Walleij

Quoting kernel test robot (2021-06-03 07:58:13)
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-versatile
> head:   419b3ab6987f2a108cc4710030184365b17467ac
> commit: 419b3ab6987f2a108cc4710030184365b17467ac [1/1] clk: versatile: remove dependency on ARCH_*
> config: s390-allmodconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?id=419b3ab6987f2a108cc4710030184365b17467ac
>         git remote add clk https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
>         git fetch --no-tags clk clk-versatile
>         git checkout 419b3ab6987f2a108cc4710030184365b17467ac
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

Probably ought to depend on HAS_IOMEM. Linus or Lee?

----8<----
diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
index 792315d893db..481de5657d85 100644
--- a/drivers/clk/versatile/Kconfig
+++ b/drivers/clk/versatile/Kconfig
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
 menu "Clock driver for ARM Reference designs"
+	depends on HAS_IOMEM
 
 config ICST
 	bool "Clock driver for ARM Reference designs ICST"

> 
> All errors (new ones prefixed by >>):
> 
>    s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
>    coherent.c:(.text+0x3bc): undefined reference to `memremap'
>    s390-linux-ld: coherent.c:(.text+0x500): undefined reference to `memunmap'
>    s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
>    coherent.c:(.text+0xae6): undefined reference to `memunmap'
>    s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
>    irq-al-fic.c:(.init.text+0x98): undefined reference to `of_iomap'
>    s390-linux-ld: irq-al-fic.c:(.init.text+0x596): undefined reference to `iounmap'
>    s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
>    clk-fixed-mmio.c:(.text+0x9a): undefined reference to `of_iomap'
>    s390-linux-ld: clk-fixed-mmio.c:(.text+0xe6): undefined reference to `iounmap'
>    s390-linux-ld: drivers/clk/versatile/clk-versatile.o: in function `cm_osc_setup':
> >> clk-versatile.c:(.init.text+0xbc): undefined reference to `of_iomap'
>    s390-linux-ld: drivers/clk/versatile/clk-sp810.o: in function `clk_sp810_of_setup':
> >> clk-sp810.c:(.init.text+0x174): undefined reference to `of_iomap'
>    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
>    timer-of.c:(.init.text+0xcc): undefined reference to `of_iomap'
>    s390-linux-ld: timer-of.c:(.init.text+0x8ee): undefined reference to `iounmap'
>    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
>    timer-of.c:(.init.text+0xb9a): undefined reference to `iounmap'
>    s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
>    timer-microchip-pit64b.c:(.init.text+0x150): undefined reference to `of_iomap'
>    s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0xc78): undefined reference to `iounmap'
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap'
  2021-06-03 20:05 ` Stephen Boyd
@ 2021-06-04  7:24   ` Linus Walleij
  2021-06-04  8:15   ` Lee Jones
  2021-06-07 14:21   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2021-06-04  7:24 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Peter Collingbourne, kernel test robot, kbuild-all, linux-clk,
	Linux ARM, Lee Jones

On Thu, Jun 3, 2021 at 10:05 PM Stephen Boyd <sboyd@kernel.org> wrote:

> Quoting kernel test robot (2021-06-03 07:58:13)
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-versatile
> > head:   419b3ab6987f2a108cc4710030184365b17467ac
> > commit: 419b3ab6987f2a108cc4710030184365b17467ac [1/1] clk: versatile: remove dependency on ARCH_*
> > config: s390-allmodconfig (attached as .config)
> > compiler: s390-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?id=419b3ab6987f2a108cc4710030184365b17467ac
> >         git remote add clk https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
> >         git fetch --no-tags clk clk-versatile
> >         git checkout 419b3ab6987f2a108cc4710030184365b17467ac
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Probably ought to depend on HAS_IOMEM. Linus or Lee?

Probably! Not that I know how S390 access it's IO (Arnd knows)
I bet it has big iron port-mapped IO or something.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
for the patch.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap'
  2021-06-03 20:05 ` Stephen Boyd
  2021-06-04  7:24   ` Linus Walleij
@ 2021-06-04  8:15   ` Lee Jones
  2021-06-07 14:21   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2021-06-04  8:15 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Peter Collingbourne, kernel test robot, kbuild-all, linux-clk,
	linux-arm-kernel, Linus Walleij

On Thu, 03 Jun 2021, Stephen Boyd wrote:
65;6200;1c
> Quoting kernel test robot (2021-06-03 07:58:13)
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-versatile
> > head:   419b3ab6987f2a108cc4710030184365b17467ac
> > commit: 419b3ab6987f2a108cc4710030184365b17467ac [1/1] clk: versatile: remove dependency on ARCH_*
> > config: s390-allmodconfig (attached as .config)
> > compiler: s390-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?id=419b3ab6987f2a108cc4710030184365b17467ac
> >         git remote add clk https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
> >         git fetch --no-tags clk clk-versatile
> >         git checkout 419b3ab6987f2a108cc4710030184365b17467ac
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> 
> Probably ought to depend on HAS_IOMEM. Linus or Lee?

That would be my best guess also.

> ----8<----
> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
> index 792315d893db..481de5657d85 100644
> --- a/drivers/clk/versatile/Kconfig
> +++ b/drivers/clk/versatile/Kconfig
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
>  menu "Clock driver for ARM Reference designs"
> +	depends on HAS_IOMEM
>  
>  config ICST
>  	bool "Clock driver for ARM Reference designs ICST"
> 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
> >    coherent.c:(.text+0x3bc): undefined reference to `memremap'
> >    s390-linux-ld: coherent.c:(.text+0x500): undefined reference to `memunmap'
> >    s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
> >    coherent.c:(.text+0xae6): undefined reference to `memunmap'
> >    s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
> >    irq-al-fic.c:(.init.text+0x98): undefined reference to `of_iomap'
> >    s390-linux-ld: irq-al-fic.c:(.init.text+0x596): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
> >    clk-fixed-mmio.c:(.text+0x9a): undefined reference to `of_iomap'
> >    s390-linux-ld: clk-fixed-mmio.c:(.text+0xe6): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clk/versatile/clk-versatile.o: in function `cm_osc_setup':
> > >> clk-versatile.c:(.init.text+0xbc): undefined reference to `of_iomap'
> >    s390-linux-ld: drivers/clk/versatile/clk-sp810.o: in function `clk_sp810_of_setup':
> > >> clk-sp810.c:(.init.text+0x174): undefined reference to `of_iomap'
> >    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
> >    timer-of.c:(.init.text+0xcc): undefined reference to `of_iomap'
> >    s390-linux-ld: timer-of.c:(.init.text+0x8ee): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
> >    timer-of.c:(.init.text+0xb9a): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
> >    timer-microchip-pit64b.c:(.init.text+0x150): undefined reference to `of_iomap'
> >    s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0xc78): undefined reference to `iounmap'
> >

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap'
  2021-06-03 20:05 ` Stephen Boyd
  2021-06-04  7:24   ` Linus Walleij
  2021-06-04  8:15   ` Lee Jones
@ 2021-06-07 14:21   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-06-07 14:21 UTC (permalink / raw)
  To: Stephen Boyd, Randy Dunlap
  Cc: Peter Collingbourne, kernel test robot, kbuild-all, linux-clk,
	linux-arm-kernel, Lee Jones, Linus Walleij

+Randy

On Thu, Jun 3, 2021 at 3:06 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting kernel test robot (2021-06-03 07:58:13)
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-versatile
> > head:   419b3ab6987f2a108cc4710030184365b17467ac
> > commit: 419b3ab6987f2a108cc4710030184365b17467ac [1/1] clk: versatile: remove dependency on ARCH_*
> > config: s390-allmodconfig (attached as .config)
> > compiler: s390-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?id=419b3ab6987f2a108cc4710030184365b17467ac
> >         git remote add clk https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
> >         git fetch --no-tags clk clk-versatile
> >         git checkout 419b3ab6987f2a108cc4710030184365b17467ac
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Probably ought to depend on HAS_IOMEM. Linus or Lee?

As you can see, there are lots of errors on s390 related to this.
Randy has been looking at these and I've suggested we add static
inlines. What makes HAS_IOMEM special compared to everywhere else we
have static inline stubs? It is mainly a kconfig hiding mechanism (for
UML and s390).

> ----8<----
> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
> index 792315d893db..481de5657d85 100644
> --- a/drivers/clk/versatile/Kconfig
> +++ b/drivers/clk/versatile/Kconfig
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>
>  menu "Clock driver for ARM Reference designs"
> +       depends on HAS_IOMEM
>
>  config ICST
>         bool "Clock driver for ARM Reference designs ICST"
>
> >
> > All errors (new ones prefixed by >>):
> >
> >    s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
> >    coherent.c:(.text+0x3bc): undefined reference to `memremap'
> >    s390-linux-ld: coherent.c:(.text+0x500): undefined reference to `memunmap'
> >    s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
> >    coherent.c:(.text+0xae6): undefined reference to `memunmap'
> >    s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
> >    irq-al-fic.c:(.init.text+0x98): undefined reference to `of_iomap'
> >    s390-linux-ld: irq-al-fic.c:(.init.text+0x596): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
> >    clk-fixed-mmio.c:(.text+0x9a): undefined reference to `of_iomap'
> >    s390-linux-ld: clk-fixed-mmio.c:(.text+0xe6): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clk/versatile/clk-versatile.o: in function `cm_osc_setup':
> > >> clk-versatile.c:(.init.text+0xbc): undefined reference to `of_iomap'
> >    s390-linux-ld: drivers/clk/versatile/clk-sp810.o: in function `clk_sp810_of_setup':
> > >> clk-sp810.c:(.init.text+0x174): undefined reference to `of_iomap'
> >    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
> >    timer-of.c:(.init.text+0xcc): undefined reference to `of_iomap'
> >    s390-linux-ld: timer-of.c:(.init.text+0x8ee): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
> >    timer-of.c:(.init.text+0xb9a): undefined reference to `iounmap'
> >    s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
> >    timer-microchip-pit64b.c:(.init.text+0x150): undefined reference to `of_iomap'
> >    s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0xc78): undefined reference to `iounmap'
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-07 14:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 14:58 [clk:clk-versatile 1/1] clk-versatile.c:undefined reference to `of_iomap' kernel test robot
2021-06-03 20:05 ` Stephen Boyd
2021-06-04  7:24   ` Linus Walleij
2021-06-04  8:15   ` Lee Jones
2021-06-07 14:21   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).