From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ECC6C07E94 for ; Fri, 4 Jun 2021 11:09:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 235EC61405 for ; Fri, 4 Jun 2021 11:09:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 235EC61405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U55lV5ScYWvcL0fYlASOxj7ZlW2iVZeHkOnPYcuipBI=; b=voPUNm1yJQKn0/ jvFyZ0MsKcHxyOzf8mgvLp+nMQqiz2YPSIQtD1LntcVg9swUbc5nVaKArfIZO2J39pcDCZYmy+jWb K+uPfeypu0IbOT+QbWBFkc4sINNl3WDJoeVDxP9nU7EcLkLLOshTndPblSKVZUKoJ2JjBYJe199Xx KNYLojJRlsGm8GCauV7TNV/0iWRFZ1ILhPT/3TW6C2TTxMJ4aIgLiD2asnWkR0Gu6viVYdSo7FCXh 14p4Fks+HvoHnnmEmGVy85Ib8A41Ym87F31EHkJ//DoYCEbKrQVzthPS5oTX0imNKbq/8aXos9Azv lqGo4K/kbrRcTS8Xet4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7fj-00D9wP-8K; Fri, 04 Jun 2021 11:07:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7DD-00D0VQ-BD for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 10:38:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DC0E56140F; Fri, 4 Jun 2021 10:37:57 +0000 (UTC) Date: Fri, 4 Jun 2021 11:37:55 +0100 From: Catalin Marinas To: Daniel Kiss Cc: will@kernel.org, Ard.Biesheuvel@arm.com, linux-arm-kernel@lists.infradead.org, pcc@google.com Subject: Re: [PATCH v5 1/2] arm64: Add ARM64_PTR_AUTH_KERNEL config option Message-ID: <20210604103755.GB31173@arm.com> References: <20210604100437.1658599-1-daniel.kiss@arm.com> <20210604100437.1658599-2-daniel.kiss@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604100437.1658599-2-daniel.kiss@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_033759_445496_6816EA91 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 12:04:36PM +0200, Daniel Kiss wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 9f1d8566bbf9..c0c0073a70c3 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1481,12 +1481,6 @@ menu "ARMv8.3 architectural features" > config ARM64_PTR_AUTH > bool "Enable support for pointer authentication" > default y [...] > +config ARM64_PTR_AUTH_KERNEL > + bool "Use pointer authentication for kernel" > + default y > + depends on ARM64_PTR_AUTH Nitpick: if you only apply this patch and disable ARM64_PTR_AUTH_KERNEL, I suspect it will go wrong. Maybe make it unselectable in this patch: config ARM64_PTR_AUTH_KERNEL bool default y depends on ARM64_PTR_AUTH and add the description in the next one, once all the other bits are in place (for bisectability reasons): With that: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel