From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6CAC07E94 for ; Fri, 4 Jun 2021 11:20:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 150EA6136E for ; Fri, 4 Jun 2021 11:20:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 150EA6136E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=95n0ewYh5jJGA5zDcaT5qsezp5cb1c9w6mVPMkvZEx4=; b=wG3oCedZj+jUasun0meYsZZfgL RRRvOHP9nNjKVLvq0zAGZyi4jYhZAbXwubDC5zKDYlasff6YHGtm20D2R01c59ApVrkp5RbuzR9I8 GhIbj8Q4eORiC31pBXX0UKQL7/5gSlCo2r8FDA+JOQYgn47Xudno1VvIYJEKnQMKrqDumN3P995EL hoYPa50IuOtMlbbR8HLZaElg58c0bI1HwuOvrN/qg095HlTB2bsEqsB6KrTlG2SLyuQBVumYfcRwc TuAnONq5eqqH7MjS7P1Af5Z8BCkJQt5GKiBBL3L5Iyy8QrZLvcziUp3IhPLWfnm2uWMfCjZb64q4j M1uREXfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7p4-00DECU-53; Fri, 04 Jun 2021 11:17:06 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7e7-00D97y-C8 for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 11:05:53 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id CC5DC1F438C5 Received: by earth.universe (Postfix, from userid 1000) id 2F3FF3C0C95; Fri, 4 Jun 2021 13:05:43 +0200 (CEST) Date: Fri, 4 Jun 2021 13:05:43 +0200 From: Sebastian Reichel To: Zhen Lei Subject: Re: [PATCH 1/1] power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe() Message-ID: <20210604110543.26za5xwuwbkufk2u@earth.universe> References: <20210511094919.4885-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210511094919.4885-1-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_040547_594488_2200BD62 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-pm , Ludovic Desroches , Claudiu Beznea , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============1381716986270836324==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1381716986270836324== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lrngh3i7mnsnhmgy" Content-Disposition: inline --lrngh3i7mnsnhmgy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, May 11, 2021 at 05:49:19PM +0800, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. >=20 > Therefore, remove the error printing here to simplify code and reduce the > binary size. >=20 > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- Thanks, queued. -- Sebastian > drivers/power/reset/at91-sama5d2_shdwc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/res= et/at91-sama5d2_shdwc.c > index 125e592af445e32..d8ecffe72f165cb 100644 > --- a/drivers/power/reset/at91-sama5d2_shdwc.c > +++ b/drivers/power/reset/at91-sama5d2_shdwc.c > @@ -351,10 +351,8 @@ static int __init at91_shdwc_probe(struct platform_d= evice *pdev) > =20 > res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > at91_shdwc->shdwc_base =3D devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(at91_shdwc->shdwc_base)) { > - dev_err(&pdev->dev, "Could not map reset controller address\n"); > + if (IS_ERR(at91_shdwc->shdwc_base)) > return PTR_ERR(at91_shdwc->shdwc_base); > - } > =20 > match =3D of_match_node(at91_shdwc_of_match, pdev->dev.of_node); > at91_shdwc->rcfg =3D match->data; > --=20 > 2.26.0.106.g9fadedd >=20 >=20 --lrngh3i7mnsnhmgy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmC6CQcACgkQ2O7X88g7 +ppvSA/+MGkYvO6jhWDe8+nVnCCEa4cz8c/8BzP9+56cWpMci+PHLKbDoPw0wBRA aKFKOzyrM0t6N8D+ZDAC0R871kw4TGMg/9HiXyEV8ZXW27xVB6WRZdlJRH3hkiFY jLVjJlXwlrw6U05VA4UwnZYdXNYcP1/9RCtWq0OGbgHdjpheFqQ2JmPillMLmBfI H/1nnvo6EXc8lEUoGeEVwspT0BoSiGndH6pPILflKajqAMPRT5ZiI8xko1K1T88u 89JRipnQ6tTZITYNawR/7U0TvuIAYp+LbiJCwa2OwWYayHS+eOOjG1I7F07seAyh NopGLKfhonoUGD7yyLAMqmEeIaAxTgqM1H1W1fLXafXP7Ff/2+lfk6UzCAbCFPq6 57vNN935fFSVttmYkPeeb4MUfM95N7BffPlJztR8fREsLSrFnkJDTYO9USQ1pV9f cCwe2pT3KrHL+y8pIVjbsCSKqQrije+nK4I2PWrwOrKhgZjv1Vws8GKzHKaFZb1R PeaZmlkeMXGCibrgErNO/HfUr7f0FouR5rabbpbB+2x9jEwvVwcYHw7dlWV6oSPg UXdAqg+jpkaDkNNmue11vR3Ibimzmk1aIiA3HoAegFiXzDmaB6Ewm8P+nnVdbrYa MGehF91zEqCaywIW7XXQi7ifsyPBEUwsm1DkbIaacxdBzqHbmrM= =K2JN -----END PGP SIGNATURE----- --lrngh3i7mnsnhmgy-- --===============1381716986270836324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1381716986270836324==--