From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B05C4743C for ; Fri, 4 Jun 2021 18:03:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43FF461402 for ; Fri, 4 Jun 2021 18:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43FF461402 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KkrWb2GmYlA/lPXF2k70fpxsIJO7NA2rszi6cM+/x0o=; b=p5sY8WgmmX92iY rKcrga4jetu6DG+Wepa+H1mZttyNoJz4tr475AxjD5Aa344repTEYHMTu+F7L4fJnsQM7CAMNypQB 6VCWFLNc6q/bo9XIckvjgl93s274dkhQaFzmjfvSCvKB9x+kVHiYuTJLCN35jUcSFvY5iqSkve8hr 7oVcH/yhPjtRoiWRIq6uCiOseUx0Y/BXrVxfXOjhHpK93G/1C4CSpMAASkLlZUlJO7XIW3FYvS6H+ 2VijKiSLPL2qwQ0/HQ72WtknZSNRaaQ8XxOuOyfV1PgVxdZz++FLC2lBK7L3KWEmKVE7xo3+CKdDM kMNqRYHBQY/08xf9XQ3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpE8t-00Emxm-RT; Fri, 04 Jun 2021 18:01:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpE8n-00Emwl-F3 for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 18:01:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F7902B; Fri, 4 Jun 2021 11:01:51 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.6.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E54DE3F73D; Fri, 4 Jun 2021 11:01:49 -0700 (PDT) Date: Fri, 4 Jun 2021 19:01:47 +0100 From: Mark Rutland To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, maz@kernel.org Subject: Re: [PATCH v3 08/20] arm64: entry: organise entry handlers consistently Message-ID: <20210604180147.GE73426@C02TD0UTHF1T.local> References: <20210525183302.56293-1-mark.rutland@arm.com> <20210525183302.56293-9-mark.rutland@arm.com> <20210604165141.GB3416@willie-the-truck> <20210604173959.GB73426@C02TD0UTHF1T.local> <20210604174452.GB3703@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604174452.GB3703@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_110153_574143_C01DBABF X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 06:44:53PM +0100, Will Deacon wrote: > On Fri, Jun 04, 2021 at 06:39:59PM +0100, Mark Rutland wrote: > > On Fri, Jun 04, 2021 at 05:51:41PM +0100, Will Deacon wrote: > > > On Tue, May 25, 2021 at 07:32:50PM +0100, Mark Rutland wrote: > > > > This patch organizes the entry handers consistently: > > > > * All handlers are given the same alignment, which was previously > > > > applied inconsitently. > > > > > > It's that word again. > > > > > > Anyway, why is this alignment needed in the first place? > > > > The alignemnt isn't functionally necessary. It's been there since day 1, > > in commit: > > > > 60ffc30d5652810d ("arm64: Exception handling") > > > > I'm happy to have them or delete them; I just need to make this > > consistent for when this gets templated. > > I agree that consistency is good here, so the "obvious" thing would be > to use SYM_CODE_START_LOCAL because we don't have any specific alignment > constraints, I think. Sounds good to me; done! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel