linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tobetter@gmail.com,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH v2 7/7] arm64: dts: meson-sm1-odroid-c4: remove invalid hub_5v regulator
Date: Mon,  7 Jun 2021 08:54:35 +0200	[thread overview]
Message-ID: <20210607065435.577334-8-narmstrong@baylibre.com> (raw)
In-Reply-To: <20210607065435.577334-1-narmstrong@baylibre.com>

Drop the hub_5v regulator which controls the HUB Reset line with GPIOH_4 which
is already controlled by a GPIO HOG.

Until we can properly describe how to control USB HUBs reset lines, keeping
the GPIO HOG is an acceptable solution we use on multiple boards.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../boot/dts/amlogic/meson-sm1-odroid-c4.dts    | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index 8c327c03d845..8c30ce63686e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -23,18 +23,6 @@ led-blue {
 		};
 	};
 
-	hub_5v: regulator-hub_5v {
-		compatible = "regulator-fixed";
-		regulator-name = "HUB_5V";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		vin-supply = <&vcc_5v>;
-
-		/* Connected to the Hub CHIPENABLE, LOW sets low power state */
-		gpio = <&gpio GPIOH_4 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
-	};
-
 	sound {
 		model = "ODROID-C4";
 	};
@@ -58,8 +46,3 @@ hog-0 {
 &ir {
 	linux,rc-map-name = "rc-odroid";
 };
-
-&usb2_phy1 {
-	/* Enable the hub which is connected to this port */
-	phy-supply = <&hub_5v>;
-};
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-06-07  6:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  6:54 [PATCH v2 0/7] arm64: dts: meson-sm1-odroid: various fixes for C4/HC4 Neil Armstrong
2021-06-07  6:54 ` [PATCH v2 1/7] arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator Neil Armstrong
2021-06-07  6:54 ` [PATCH v2 2/7] arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source Neil Armstrong
2021-06-07  6:54 ` [PATCH v2 3/7] arm64: dts: meson-sm1-odroid: add 5v regulator gpio Neil Armstrong
2021-06-12 19:49   ` Martin Blumenstingl
2021-06-07  6:54 ` [PATCH v2 4/7] arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0 Neil Armstrong
2021-06-07  6:54 ` [PATCH v2 5/7] arm64: dts: meson-sm1-odroid-hc4: add regulators controlled by GPIOH_8 Neil Armstrong
2021-06-07  6:54 ` [PATCH v2 6/7] arm64: dts: meson-sm1-odroid-hc4: add spifc node to ODROID-HC4 Neil Armstrong
2021-06-07  6:54 ` Neil Armstrong [this message]
2021-06-12 19:49   ` [PATCH v2 7/7] arm64: dts: meson-sm1-odroid-c4: remove invalid hub_5v regulator Martin Blumenstingl
2021-06-14  7:59 ` [PATCH v2 0/7] arm64: dts: meson-sm1-odroid: various fixes for C4/HC4 Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607065435.577334-8-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).