linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	ludovic.desroches@microchip.com,
	linux-arm-kernel@lists.infradead.org,
	cristian.birsan@microchip.com
Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses
Date: Wed, 9 Jun 2021 19:07:35 -0400	[thread overview]
Message-ID: <20210609230735.GA1861855@rowland.harvard.edu> (raw)
In-Reply-To: <20210609121027.70951-1-claudiu.beznea@microchip.com>

On Wed, Jun 09, 2021 at 03:10:27PM +0300, Claudiu Beznea wrote:
> On SAMA7G5 suspending ports will cut the access to OHCI registers and
> any subsequent access to them will lead to CPU being blocked trying to
> access that memory. Same thing happens on resume: if OHCI memory is
> accessed before resuming ports the CPU will block on that access. The
> OCHI memory is accessed on suspend/resume though
> ohci_suspend()/ohci_resume().

That sounds very strange.  Suppose one of the ports is suspended, so access to the 
OHCI registers is blocked.  Then how can you resume the port?  Don't you have to 
access the OHCI registers in order to tell the controller to do the port resume?

What happens when there's more than one port, and one of them is suspended while 
the other one is still running?  How can you communicate with the active port if 
access to the OHCI registers is blocked?

Alan Stern

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-06-09 23:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 12:10 [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Claudiu Beznea
2021-06-09 12:40 ` Nicolas Ferre
2021-06-09 23:07 ` Alan Stern [this message]
2021-06-23 12:47   ` Claudiu.Beznea
2021-06-23 13:59     ` Alan Stern
2021-06-23 14:09       ` Claudiu.Beznea
2021-06-23 14:19         ` Alan Stern
2021-06-23 14:33           ` Claudiu.Beznea
2021-06-23 16:41             ` Alan Stern
2021-06-24  6:40               ` Claudiu.Beznea
2021-06-24  6:54                 ` Claudiu.Beznea
2021-06-24 13:23                 ` Alan Stern
2021-06-30 14:46                   ` Claudiu.Beznea
2021-06-30 18:21                     ` Alan Stern
2021-07-01  5:45                       ` Claudiu.Beznea
2021-07-01 14:01                         ` Alan Stern
2021-06-30 14:47                   ` Claudiu.Beznea
2021-07-21  8:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609230735.GA1861855@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=cristian.birsan@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).