From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518B4C47094 for ; Thu, 10 Jun 2021 14:32:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13A3A613C6 for ; Thu, 10 Jun 2021 14:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13A3A613C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yEAvjtH8SehmrLQd8aA3fBqrb4LHB+jwFPhwcNJIZLs=; b=1W70pVEsfW5vZT 6q/syFHADAnaHiXqR2QR/ku47Flb5rXhErJDSO/RK9ITeWvL6WQWGpNAdFQ7uhAmCQmecHIDehGGp P6nXifvj/kRv5cX3K3nBVh8I2RaLDv7rFTY1kFzvdKvJIwAf7djAf8G9srVEWe1IvsWcnFtJZwF+K PFjSaSKzrFl2uxLpkQeAkYl5bGF+cP4R05pafKO5YzlJ4Dul99YTalgvluDQVhRLxJXp2Rxs1bk76 6vStDpDDqHoCaPJyqi5GbQMliEHmz4VR5uUapSY2xe820e3zNgJHkJtH2qr/I4K8aEFHNswqoOepx zwvyNTRmauGXfIvT/2+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrLi5-0018eW-64; Thu, 10 Jun 2021 14:31:05 +0000 Received: from mail-pj1-f48.google.com ([209.85.216.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrLi1-0018dg-Dh for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 14:31:02 +0000 Received: by mail-pj1-f48.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so3840691pjp.4 for ; Thu, 10 Jun 2021 07:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WAIw/Rwu5BfzassT+alfD6qJ0zIc5FQswOka0Hsn+Pg=; b=oAab248luw/C5YmYfz26rJUXz6+AudYZgoU4tBw4OAkwGUfZbTYC0PCUQCvmemil9s SlKYgcXVFiXYGxbNuzDLPru/ac9L6ZlviSO6mQabLWTjDL5A2dZJnFqX83Ic1IMOVO2y 5jK8L4OUBY90qde3m7NOkr6VihMxRANPf6sxHPM8b9mqI8GGVuxGEFf2gQjb07+XVOoO kdZC/amW8Ed49gMS24E1zjDmVIEOndDu6q6NhgoR1+frgiU3oaRXKGcGt2/jP4SmCveU X2XFTbWIFYh22WkwMlwR8UDGQvnHXmq66ukf0tskFtuJZZsKjckl25ggCr+Dha4NUwhr t3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WAIw/Rwu5BfzassT+alfD6qJ0zIc5FQswOka0Hsn+Pg=; b=WztAGxIRylGn9nNrTsq65VG5BvC7Z8Jm1+Vqo2pkQGRORl1IiWJRMTxSpU1Unf6r2W 9t54pFj2wv+6QYk1Cc1aT6Rh/o8ZJlNaamYbSwKCI5cnCYaaJcUSCIRhHMdk5J1Sifa5 /HYl9B/dIrgX6IZCqx4MuMiOB0rIujXsjBMBJDxd0FAz5WBCl///4TF5lMTW6zOeP0ny 35bphFN1xwdjJz/JznuRDpNJTmxNP2DjAudxrwGneqSz+CwCzZ7rPhyDu5AvwntpOCw7 PsD+TSETK4VAb+fiDSToK0Z/CNtm4p6jRSTnO9aTAsKe7ORrpL06M+SJXmuZEgWqG5O1 PZjw== X-Gm-Message-State: AOAM533EJCOFwH/UCrrBUBQDbkzrm+9CIRRXqyB2ku9wTNVqIM87P3+v OI0b7ze0J+xxh53xZ9/4NgYk X-Google-Smtp-Source: ABdhPJy5V2yMkuXeobYWfKg0xU3WwZDRykGMwSqfzVQPY47TpPPxpWkpgmeMmwq2ZBIT2d+aMmc9Zg== X-Received: by 2002:a17:90a:80c5:: with SMTP id k5mr3697723pjw.129.1623335400290; Thu, 10 Jun 2021 07:30:00 -0700 (PDT) Received: from thinkpad ([2409:4072:6d9e:80ad:d341:9a16:2c5c:2249]) by smtp.gmail.com with ESMTPSA id o3sm2715814pfd.41.2021.06.10.07.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 07:29:59 -0700 (PDT) Date: Thu, 10 Jun 2021 19:59:53 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210610142953.GA315240@thinkpad> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_073101_480566_CB3B98E3 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 27, 2021 at 04:16:40PM +0300, Cristian Ciocaltea wrote: > Drop the unsupported entries in the factor table used for the SD[0-2] > clocks definitions on the Actions Semi Owl S500 SoC. > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Changes in v2: > - Re-added entry "{ 24, 1, 25 }" to sd_factor_table, according to the > datasheet (V1.8+), this is a valid divider > > drivers/clk/actions/owl-s500.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > index 75b7186185b0..42abdf964044 100644 > --- a/drivers/clk/actions/owl-s500.c > +++ b/drivers/clk/actions/owl-s500.c > @@ -127,8 +127,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > + { 24, 1, 25 }, > > /* bit8: /128 */ > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > @@ -137,8 +136,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > + { 280, 1, 25 * 128 }, > { 0, 0, 0 }, > }; > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel