From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E50C47094 for ; Thu, 10 Jun 2021 16:25:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1F26613E1 for ; Thu, 10 Jun 2021 16:25:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F26613E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2di7HtPj5DFNm1THUIa39IKXbL7vIAxtxQB4zhvWas=; b=vZrk7eNBtifz8i URtf5oal54SEr2daCwyXLiokS9F6XXGnsLL2WTTwoSBWxAkB2IzKKpXFuXBXutjLqMDrfl0H7X2aH 7ibgcord2KXWHyT9+mZ6tzQfFonC8sWUcppNaMlTkfIhPDMU+4lLpckLB4V61XiqPvh6LEqh1r+Ac NrLysRbhpqYCmxIoJeoSfLjv3OCYTYWhOwu+eW4no4x4C5sfkENfJLq7kFXVbWbX4CoLuLboHCBpO aeti12e3vq5hhcDeXXQGOnb4JHHlPomqcyO2YjW3bhE34yjz2q3Xm0hWv6j6+uDWMsnMXKm5/p94R EkldJcwHJdjFYbAwdxag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNSs-001eQE-Uo; Thu, 10 Jun 2021 16:23:32 +0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNSn-001eOV-0N for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 16:23:26 +0000 Received: by mail-oi1-f173.google.com with SMTP id v22so2721362oic.2 for ; Thu, 10 Jun 2021 09:23:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ajFMbmV13rSn+GZr+FQLaWoaYSbQZYLeXPdRKVG1MtA=; b=anXSLDkH8UZrRfugZBB+h82+dJKUrLa7hD5NmCVaWuaO1VdJry7R847NSZg463ZInU GBJDzdvcR78OkCBLH5PBglhBxQsMQoWWYs7pC3o/Rk653db95CK9wrbybAj5EZ4gceVn 51gkPph5ZhmxiaLY4BnTBIQoaDLi1yyLWCjJie3+aPSr8qFwSIptkyHiBv0ETgUVmWBr b73/0oRv5rH8m9HIjQnJtVfhrrthYZaUn0+rWHS12VAWzkrr+JgKdzw7WEJJibgJpAIU gaK4rMo9q3qV/FNuGjpkRIa3NmkSmZN4CipadKJXcErFMKlRZSvRpNYN5dMDXsZbSJcj YL+w== X-Gm-Message-State: AOAM532Rcr2S3P7+BWKjHhzK+QsHBQXEStos5LVNW22bZ1xL86oZmQeC xus+WwQR/8wHeB2lSHnwYQ== X-Google-Smtp-Source: ABdhPJw4r/ruF84yQMzuAkmhN9owEOanbliqra7Rbz4SR5J1wnvK6z9pA0sJEYhLuP2q3B5VVOi5pw== X-Received: by 2002:aca:d485:: with SMTP id l127mr4034718oig.106.1623342203689; Thu, 10 Jun 2021 09:23:23 -0700 (PDT) Received: from robh.at.kernel.org ([172.58.99.113]) by smtp.gmail.com with ESMTPSA id x24sm674126otq.34.2021.06.10.09.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 09:23:23 -0700 (PDT) Received: (nullmailer pid 1916785 invoked by uid 1000); Thu, 10 Jun 2021 16:23:20 -0000 Date: Thu, 10 Jun 2021 11:23:20 -0500 From: Rob Herring To: Steven Lee Cc: Linus Walleij , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongweiz@ami.com, ryan_chen@aspeedtech.com, billy_tsai@aspeedtech.com Subject: Re: [PATCH v5 02/10] dt-bindings: aspeed-sgpio: Add ast2600 sgpio compatibles. Message-ID: <20210610162320.GA1910317@robh.at.kernel.org> References: <20210608102547.4880-1-steven_lee@aspeedtech.com> <20210608102547.4880-3-steven_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210608102547.4880-3-steven_lee@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_092325_090799_2254267E X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 08, 2021 at 06:25:37PM +0800, Steven Lee wrote: > AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one > with 80 pins. Add ast2600-sgpiom0-80 and ast2600-sgpiom-128 compatibles > and update descriptions to introduce the max number of available gpio > pins that AST2600 supported. > > Signed-off-by: Steven Lee > Reviewed-by: Andrew Jeffery > --- > Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml > index b2ae211411ff..0e42eded3c1e 100644 > --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml > @@ -10,9 +10,10 @@ maintainers: > - Andrew Jeffery > > description: > - This SGPIO controller is for ASPEED AST2500 SoC, it supports up to 80 full > - featured Serial GPIOs. Each of the Serial GPIO pins can be programmed to > - support the following options > + This SGPIO controller is for ASPEED AST2400, AST2500 and AST2600 SoC, > + AST2600 have two sgpio master one with 128 pins another one with 80 pins, > + AST2500/AST2400 have one sgpio master with 80 pins. Each of the Serial > + GPIO pins can be programmed to support the following options > - Support interrupt option for each input port and various interrupt > sensitivity option (level-high, level-low, edge-high, edge-low) > - Support reset tolerance option for each output port > @@ -25,6 +26,8 @@ properties: > enum: > - aspeed,ast2400-sgpio > - aspeed,ast2500-sgpio > + - aspeed,ast2600-sgpiom-80 > + - aspeed,ast2600-sgpiom-128 If the number of GPIOs is the only difference, then I don't think you should get rid of ngpios. It's one thing if it varies from one SoC to the next, but if something is per instance we should have a property. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel