From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F92C48BDF for ; Thu, 10 Jun 2021 17:05:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51C3E613C9 for ; Thu, 10 Jun 2021 17:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51C3E613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m4j+xoQDF4kzswI37m1AHzpfq2FtqvGfuJyj92Fyku4=; b=Zz5nXDuCXIhkaQ NhOo1eVsuVO+nOEH8XYDj9Ty/g6+c0uIadOQ5LEkofWf4jfsrR4TOOWQevGgfm6Pxhyq5oVSPNvnB /5NWRTU8lOjOiQdqmdj/ZFS48F0ce5iykAvrDQfq9XA1HVItgRPnQ0GJMQd6BXfLGWQUqiBItMFx8 hC9sOBZ53MTbUdpfsgum07oTUTk39YCcoizGkD9JTwZM+4XzAzsSX6yqFPPBYO7f0MnQ8zAY+OEuc JVUNt/hk25PkKAz+t1i8ZEjmcPnL6uvTD+Hejzy67oKhPuj5FCJugzMOYXhHwcrzlunAcZtk7lIZl Ac0uSqMg2O3prZlTFY8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrO5m-001roz-GY; Thu, 10 Jun 2021 17:03:43 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrO4m-001rWr-9k for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 17:02:42 +0000 Received: by mail-oi1-f182.google.com with SMTP id r16so2494613oiw.3 for ; Thu, 10 Jun 2021 10:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4a/91iYGoY9yr3GZI7DZxVbEUDYySZoo2P+z2xpl9o=; b=lMq69A76YuzGY/Wgk0kIZyiuwz6tjms3tCjl8qWAElBH0M1IwHkskV/gzgMJjsdvQV u5+M2kPgljsuTc3AIsNauusgsC3Y4FyfXyTicXiwvi9wr5wJp3wey29aU+0t4rJ7aJHg MCYqEWuuDLFu9RNjfWMBBaffxFM4NwC0ROTcSAG15I1mrHehGf+a2f1Am361HZWABHpm 5dgiR+wkG2d8J9pPsV6IBhYl0ZvwZ/eeTCpgYf0EJx5f7C4qWeEkymVXhrSdtlxG3X5W 0LQE6J4K0Krvy/dqD9W4Dj1MEXWuCgU2mwYIOrBLVxsTIpEYk3DZ8n82fKHZccQ2atJN 3dRw== X-Gm-Message-State: AOAM5326cs2FVOXkUzdebX/AyOELTFVFUfeoXGnZaGE6zV+P8LOzgxDu eAulIBalPymwJBQSKS0FhA== X-Google-Smtp-Source: ABdhPJyCN2rSyQvYwP+VJ4DJWxdMIfMOuh00l62oVRXcHyvCP+ksagzHArpBvff/UlxQnvCH8/uMrQ== X-Received: by 2002:aca:ea85:: with SMTP id i127mr4198702oih.176.1623344558097; Thu, 10 Jun 2021 10:02:38 -0700 (PDT) Received: from robh.at.kernel.org ([172.58.99.113]) by smtp.gmail.com with ESMTPSA id l128sm651998oif.16.2021.06.10.10.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 10:02:36 -0700 (PDT) Received: (nullmailer pid 1967937 invoked by uid 1000); Thu, 10 Jun 2021 17:02:33 -0000 Date: Thu, 10 Jun 2021 12:02:33 -0500 From: Rob Herring To: Martin Kepplinger Cc: festevam@gmail.com, krzk@kernel.org, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, kernel@pengutronix.de, kernel@puri.sm, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org, phone-devel@vger.kernel.org, shawnguo@kernel.org, slongerbeam@gmail.com Subject: Re: [PATCH v3 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller Message-ID: <20210610170233.GA1961013@robh.at.kernel.org> References: <20210608104128.1616028-1-martin.kepplinger@puri.sm> <20210608104128.1616028-2-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210608104128.1616028-2-martin.kepplinger@puri.sm> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_100240_374429_D2A6909B X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 08, 2021 at 12:41:26PM +0200, Martin Kepplinger wrote: > The i.MX8MQ SoC integrates a different MIPI CSI receiver as the i.MX8MM so > describe the DT bindings for it. > > Signed-off-by: Martin Kepplinger > --- > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 161 ++++++++++++++++++ > 1 file changed, 161 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > new file mode 100644 > index 000000000000..6eafdf803d36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > @@ -0,0 +1,161 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nxp,imx8mq-mipi-csi2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8MQ MIPI CSI-2 receiver > + > +maintainers: > + - Martin Kepplinger > + > +description: |- > + This binding covers the CSI-2 RX PHY and host controller included in the > + NXP i.MX8MQ SoC. It handles the sensor/image input and process for all the > + input imaging devices. > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-mipi-csi2 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: core is the RX Controller Core Clock input. This clock > + must be exactly equal to or faster than the receive > + byteclock from the RX DPHY. > + - description: esc is the Rx Escape Clock. This must be the same escape > + clock that the RX DPHY receives. > + - description: pxl is the pixel clock (phy_ref up to 333Mhz). > + - description: clko2 is the CLKO2 clock root. > + See the reference manual for details. > + > + clock-names: > + items: > + - const: core > + - const: esc > + - const: pxl > + - const: clko2 > + > + power-domains: > + maxItems: 1 > + > + reset: resets > + description: > + The phandle to the imx8mq reset-controller. Drop. What the reset controller is is out of scope for a binding. > + maxItems: 1 > + > + phy: phys? Assuming this is using the PHY binding. If it is not, then why not? > + description: > + The phandle to the imx8mq syscon iomux-gpr. > + maxItems: 1 > + > + interconnects: > + maxItems: 1 > + > + interconnect-names: > + const: dram > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port node, single endpoint describing the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + items: > + minItems: 1 > + maxItems: 4 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port node > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - power-domains > + - reset > + - phy > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + csi@30a70000 { > + compatible = "fsl,imx8mq-mipi-csi2"; > + reg = <0x30a70000 0x1000>; > + clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > + <&clk IMX8MQ_CLK_CSI1_ESC>, > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>, > + <&clk IMX8MQ_CLK_CLKO2>; > + clock-names = "core", "esc", "pxl", "clko2"; > + assigned-clocks = <&clk IMX8MQ_CLK_CSI1_CORE>, > + <&clk IMX8MQ_CLK_CSI1_PHY_REF>, > + <&clk IMX8MQ_CLK_CSI1_ESC>; > + assigned-clock-rates = <266000000>, <200000000>, <66000000>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_266M>, > + <&clk IMX8MQ_SYS2_PLL_1000M>, > + <&clk IMX8MQ_SYS1_PLL_800M>; > + power-domains = <&pgc_mipi_csi1>; > + reset = <&src>; > + phy = <&iomuxc_gpr>; > + interconnects = <&noc IMX8MQ_ICM_CSI1 &noc IMX8MQ_ICS_DRAM>; > + interconnect-names = "dram"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + imx8mm_mipi_csi_in: endpoint { > + remote-endpoint = <&imx477_out>; > + data-lanes = <1 2 3 4>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + imx8mm_mipi_csi_out: endpoint { > + remote-endpoint = <&csi_in>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel