Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver

From: Ioana Ciornei <ciorneiioana@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ioana Ciornei <ciorneiioana@gmail.com>,
	Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Calvin Johnson <calvin.johnson@nxp.com>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux.cj" <linux.cj@gmail.com>, netdev <netdev@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Len Brown <lenb@kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver
Date: Fri, 11 Jun 2021 12:17:32 +0300	[thread overview]
Message-ID: <20210611091732.wms3g3mnghvmcw3n@skbuf> (raw)
In-Reply-To: <CAHp75VfeyWYKRYuufd8CkCwjCWPRssuQVNfCSknnJWB9HvUcMA@mail.gmail.com>

On Fri, Jun 11, 2021 at 12:00:02PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote:
> >
> > From: Ioana Ciornei <ioana.ciornei@nxp.com>
> >
> > This patch set provides ACPI support to DPAA2 network drivers.
> >
> > It also introduces new fwnode based APIs to support phylink and phy
> > layers
> >     Following functions are defined:
> >       phylink_fwnode_phy_connect()
> >       fwnode_mdiobus_register_phy()
> >       fwnode_get_phy_id()
> >       fwnode_phy_find_device()
> >       device_phy_find_device()
> >       fwnode_get_phy_node()
> >       fwnode_mdio_find_device()
> >       acpi_get_local_address()
> >
> >     First one helps in connecting phy to phylink instance.
> >     Next three helps in getting phy_id and registering phy to mdiobus
> >     Next two help in finding a phy on a mdiobus.
> >     Next one helps in getting phy_node from a fwnode.
> >     Last one is used to get local address from _ADR object.
> >
> >     Corresponding OF functions are refactored.
> 
> In general it looks fine to me. What really worries me is the calls like
> 
> of_foo -> fwnode_bar -> of_baz.
> 
> As I have commented in one patch the idea of fwnode APIs is to have a
> common ground for all resource providers. So, at the end it shouldn't
> be a chain of calls like above mentioned. Either fix the name (so, the
> first one will be in fwnode or device namespace) or fix the API that
> it will be fwnode/device API.

These types of cyclic calls do not exist anymore.
The fwnode_mdio does not call back into of_mdio but instead it directly
implements any necessary operations using the fwnode_handle.

The only calls happening are 'of_mdio -> fwnode_mdio' so that we
leverage the common fwnode handling and do not duplicate code.

Ioana

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel