From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732F3C48BE0 for ; Fri, 11 Jun 2021 10:34:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F1A613DE for ; Fri, 11 Jun 2021 10:34:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32F1A613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JCQfxzpJ3RDsiNbuROw+/tmTWVSNnRYzk/kRBFYIEqk=; b=jeLOXkhvDwxU5Q 1T85kevo/g8fvu/A7/ICEHRrauLg20BIXbRp5+ZDbBAh2UL1FkJE2v9Fd/PWEHTPi0mjzQFa0VCIs Ypiwpr5XTHKIMxJ7HzTDUjmhrxH97Y9byGbNwbbSajMWjOM1czEgbACFUwAruTBOgyjGjy4XuVQme rh2TzRuwRIK/bT1xACbkSK7y5d8IfoeCXTFEycWaCFJQwKqYcbRfCYkFadef4PUDA2mP89pNtjQLX kskAhhpdbbB/zuHPpi51xJR3faAf+8PVXVl92+D/qpsTTqNWQQ2VkwfzUV2U/6Dq4AxxAztunK0iT NX2ZpxVAL8h0xLGS9EOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lreSj-004kOH-Io; Fri, 11 Jun 2021 10:32:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lreSf-004kMo-Ib for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 10:32:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31CD661029; Fri, 11 Jun 2021 10:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623407545; bh=/CQOsHwg/yOw2FDU3YrXjCu+y0Ik2X28NsqtPXbhA6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=npq7cLhUXsPk0RJBjvF1b/YxEEogwk0HgMimUI08IvHdOTu8u8rx6aSUFpLoqAJxS UM6K4zSGNRX9iOHnTHkw8uNL4uUbuQgoCjMwtm61sKUfNiQX1FUcYR/fsuZOly0nvk BR14ShuEsN2M6bNVYtydAg9KVCJI/O6I8L18mhO+nbUrnDgp1b+v2OMQyvNeg8BQLu 5dtriRIU7zxU144oI2iktLNzjA81YeSmQDD+nxDqiWsbElH1l8Mxg2LghUkO+oZmrr yaHpFPYcmsIK0tomykeq+nhvobzJgpTC9KrWcEr1054xTzh4nN9Sz6vm9wlFY2k1DC oBrVfTYUNiQAA== Date: Fri, 11 Jun 2021 11:32:20 +0100 From: Will Deacon To: Zhen Lei Cc: Robin Murphy , linux-arm-kernel , Joerg Roedel , iommu Subject: Re: [PATCH 1/1] iommu/arm-smmu-v3: remove unnecessary oom message Message-ID: <20210611103220.GB15274@willie-the-truck> References: <20210609125438.14369-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210609125438.14369-1-thunder.leizhen@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_033225_676923_7CCE95B7 X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 09, 2021 at 08:54:38PM +0800, Zhen Lei wrote: > Fixes scripts/checkpatch.pl warning: > WARNING: Possible unnecessary 'out of memory' message > > Remove it can help us save a bit of memory. > > Signed-off-by: Zhen Lei > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 2ddc3cd5a7d1..fd7c55b44881 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2787,10 +2787,8 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) > void *strtab = smmu->strtab_cfg.strtab; > > cfg->l1_desc = devm_kzalloc(smmu->dev, size, GFP_KERNEL); > - if (!cfg->l1_desc) { > - dev_err(smmu->dev, "failed to allocate l1 stream table desc\n"); > + if (!cfg->l1_desc) What error do you get if devm_kzalloc() fails? I'd like to make sure it's easy to track down _which_ allocation failed in that case -- does it give you a line number, for example? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel