From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<virtualization@lists.linux-foundation.org>,
<virtio-dev@lists.oasis-open.org>, <sudeep.holla@arm.com>,
<james.quinlan@broadcom.com>, <f.fainelli@gmail.com>,
<etienne.carriere@linaro.org>, <vincent.guittot@linaro.org>,
<souvik.chakravarty@arm.com>, <igor.skalkin@opensynergy.com>,
<peter.hilber@opensynergy.com>, <alex.bennee@linaro.org>,
<jean-philippe@linaro.org>, <mikhail.golubev@opensynergy.com>,
<anton.yakovlev@opensynergy.com>,
<Vasyl.Vavrychuk@opensynergy.com>,
<Andriy.Tryshnivskyy@opensynergy.com>
Subject: Re: [PATCH v4 03/16] firmware: arm_scmi: Add transport optional init/exit support
Date: Mon, 14 Jun 2021 14:29:56 +0100 [thread overview]
Message-ID: <20210614142956.000030f5@Huawei.com> (raw)
In-Reply-To: <20210611165937.701-4-cristian.marussi@arm.com>
On Fri, 11 Jun 2021 17:59:24 +0100
Cristian Marussi <cristian.marussi@arm.com> wrote:
> Some SCMI transport could need to perform some transport specific setup
> before they can be used by the SCMI core transport layer: typically this
> early setup consists in registering with some other kernel subsystem.
>
> Add the optional capability for a transport to provide a couple of .init
> and .exit functions that are assured to be called early during the SCMI
> core initialization phase, well before the SCMI core probing step.
>
> [ Peter: Adapted RFC patch by Cristian for submission to upstream. ]
> Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
> [ Cristian: Fixed scmi_transports_exit point of invocation ]
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Drive by comment inline. Feel free to ignore ;)
Jonathan
> ---
> drivers/firmware/arm_scmi/common.h | 8 ++++
> drivers/firmware/arm_scmi/driver.c | 59 ++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> index 7c2b9fd7e929..6bb734e0e3ac 100644
> --- a/drivers/firmware/arm_scmi/common.h
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -321,6 +321,12 @@ struct scmi_device *scmi_child_dev_find(struct device *parent,
> /**
> * struct scmi_desc - Description of SoC integration
> *
> + * @init: An optional function that a transport can provide to initialize some
> + * transport-specific setup during SCMI core initialization, so ahead of
> + * SCMI core probing.
> + * @exit: An optional function that a transport can provide to de-initialize
> + * some transport-specific setup during SCMI core de-initialization, so
> + * after SCMI core removal.
> * @ops: Pointer to the transport specific ops structure
> * @max_rx_timeout_ms: Timeout for communication with SoC (in Milliseconds)
> * @max_msg: Maximum number of messages that can be pending
> @@ -328,6 +334,8 @@ struct scmi_device *scmi_child_dev_find(struct device *parent,
> * @max_msg_size: Maximum size of data per message that can be handled.
> */
> struct scmi_desc {
> + int (*init)(void);
> + void (*exit)(void);
> const struct scmi_transport_ops *ops;
> int max_rx_timeout_ms;
> int max_msg;
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index f15d75af87ea..20f8f0581f3a 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -1594,10 +1594,67 @@ static struct platform_driver scmi_driver = {
> .remove = scmi_remove,
> };
>
> +/**
> + * __scmi_transports_setup - Common helper to call transport-specific
> + * .init/.exit code if provided.
> + *
> + * @init: A flag to distinguish between init and exit.
> + *
> + * Note that, if provided, we invoke .init/.exit functions for all the
> + * transports currently compiled in.
> + *
> + * Return: 0 on Success.
> + */
> +static inline int __scmi_transports_setup(bool init)
> +{
> + int ret = 0;
> + const struct of_device_id *trans;
> +
> + for (trans = scmi_of_match; trans->data; trans++) {
> + const struct scmi_desc *tdesc = trans->data;
> +
> + if ((init && !tdesc->init) || (!init && !tdesc->exit))
> + continue;
> +
> + pr_debug("SCMI %sInitializing %s transport\n",
> + init ? "" : "De-", trans->compatible);
Clever formatting can makes grepping for messages harder.
Perhaps
if (init)
pr_debug("SCMI Initializing %s transport\n",
trans->compatible);
else
pr_debug("SCMI Deinitializing %s transport\n",
trans->compatible);
would be nicer even though it burns some lines. Also avoids somewhat
ugly capitalization : De-Initializing xxx transport.
You could combine it with the convenient if(init) below
> +
> + if (init)
> + ret = tdesc->init();
> + else
> + tdesc->exit();
> +
> + if (ret) {
> + pr_err("SCMI transport %s FAILED initialization!\n",
> + trans->compatible);
> + break;
> + }
> + }
> +
> + return ret;
> +}
> +
> +static int __init scmi_transports_init(void)
> +{
> + return __scmi_transports_setup(true);
> +}
> +
> +static void __exit scmi_transports_exit(void)
> +{
> + __scmi_transports_setup(false);
> +}
> +
> static int __init scmi_driver_init(void)
> {
> + int ret;
> +
> scmi_bus_init();
>
> + /* Initialize any compiled-in transport which provided an init/exit */
> + ret = scmi_transports_init();
> + if (ret)
> + return ret;
> +
> scmi_base_register();
>
> scmi_clock_register();
> @@ -1626,6 +1683,8 @@ static void __exit scmi_driver_exit(void)
>
> scmi_bus_exit();
>
> + scmi_transports_exit();
> +
> platform_driver_unregister(&scmi_driver);
> }
> module_exit(scmi_driver_exit);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-14 13:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 16:59 [PATCH v4 00/16] Introduce SCMI VirtIO transport Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Cristian Marussi
2021-07-01 8:42 ` Peter Hilber
2021-07-01 10:04 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 02/16] firmware: arm_scmi: Add support for type handling in common functions Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 03/16] firmware: arm_scmi: Add transport optional init/exit support Cristian Marussi
2021-06-14 13:29 ` Jonathan Cameron [this message]
2021-06-16 9:04 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 04/16] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi
2021-06-14 13:53 ` Jonathan Cameron
2021-06-16 9:11 ` Cristian Marussi
2021-07-01 8:42 ` Peter Hilber
2021-07-01 10:16 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 05/16] firmware: arm_scmi: Introduce delegated xfers support Cristian Marussi
2021-07-01 8:42 ` Peter Hilber
2021-07-01 10:24 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 06/16] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional Cristian Marussi
2021-07-01 8:42 ` Peter Hilber
2021-07-01 10:27 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 07/16] firmware: arm_scmi: Add op to override max message # Cristian Marussi
2021-06-14 14:04 ` Jonathan Cameron
2021-06-16 9:13 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 08/16] [RFC][REWORK] " Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 09/16] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 10/16] firmware: arm_scmi: Add per-device transport private info Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 11/16] firmware: arm_scmi: Add is_scmi_protocol_device() Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 12/16] firmware: arm_scmi: Add message passing abstractions for transports Cristian Marussi
2021-06-14 14:10 ` Jonathan Cameron
2021-06-16 9:14 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 13/16] dt-bindings: arm: Add virtio transport for SCMI Cristian Marussi
2021-06-24 19:22 ` Rob Herring
2021-07-01 8:43 ` Peter Hilber
2021-07-01 10:31 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 14/16] firmware: arm_scmi: Add virtio transport Cristian Marussi
2021-06-14 14:23 ` Jonathan Cameron
2021-06-16 10:18 ` Cristian Marussi
2021-07-01 8:43 ` Peter Hilber
2021-07-01 10:34 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 15/16] [RFC][REWORK] firmware: arm_scmi: make virtio-scmi use delegated xfers Cristian Marussi
2021-07-01 8:43 ` Peter Hilber
2021-07-01 11:26 ` Cristian Marussi
2021-06-11 16:59 ` [PATCH v4 16/16] firmware: arm_scmi: Add polling mode to virtio transport Cristian Marussi
2021-06-14 11:43 ` [PATCH v4 00/16] Introduce SCMI VirtIO transport Christoph Hellwig
2021-06-14 14:03 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614142956.000030f5@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Andriy.Tryshnivskyy@opensynergy.com \
--cc=Vasyl.Vavrychuk@opensynergy.com \
--cc=alex.bennee@linaro.org \
--cc=anton.yakovlev@opensynergy.com \
--cc=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=igor.skalkin@opensynergy.com \
--cc=james.quinlan@broadcom.com \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail.golubev@opensynergy.com \
--cc=peter.hilber@opensynergy.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).